From 65c9fc5775715518b8d068425171d421e1386170 Mon Sep 17 00:00:00 2001 From: Yee Cheng Chin Date: Sat, 1 Feb 2025 00:20:59 -0800 Subject: [PATCH] ci: Don't run Vim non-src tests (indent/syntax etc) Currently Vim syntax tests are quite broken and keep failing in MacVim CI. There seems to be some Unicode / emoji handling bug causing tests to fail sporadically, and the syntax tests also spam the console output as they aren't redirecting output to /dev/null like normal Vim script tests. Just disable them for now until this is fixed. This should not cause much issues anyway. It's unlike MacVim will have any downstream syntax/indent bugs as those files are mostly merged from upstream as-is. --- .github/workflows/ci-macvim.yaml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci-macvim.yaml b/.github/workflows/ci-macvim.yaml index bc0ce94600..71a386d54c 100644 --- a/.github/workflows/ci-macvim.yaml +++ b/.github/workflows/ci-macvim.yaml @@ -375,14 +375,17 @@ jobs: - name: Test Vim if: startsWith(github.ref, 'refs/tags/') || !matrix.testgui - timeout-minutes: 25 + timeout-minutes: 30 run: | defaults delete org.vim.MacVim # Clean up stale states - make ${MAKE_BUILD_ARGS} test + # Currently we don't run any non-src tests, as syntax tests are fragile and prone to spamming escape codes. + # This needs to be investigated and fixed upstream. + # MacVim is unlikely to introduce breaking changes in runtime files anyway. + make ${MAKE_BUILD_ARGS} -C src test - name: Test Vim (GUI) if: startsWith(github.ref, 'refs/tags/') || matrix.testgui - timeout-minutes: 25 + timeout-minutes: 30 run: | defaults delete org.vim.MacVim # Clean up stale states make ${MAKE_BUILD_ARGS} -C src/testdir clean