MCLOUD-7442: Invalid volume name (#19)

oshmyheliuk · web-flow · commit 22fcd623dd46 · 2020-12-17T11:29:33.000-06:00
diff --git a/src/Compose/BuilderInterface.php b/src/Compose/BuilderInterface.php
@@ -48,9 +48,9 @@ interface BuilderInterface
     public const VOLUME_MAGENTO_DB_QUOTE = 'magento-db-quote';
     public const VOLUME_MAGENTO_DB_SALES = 'magento-db-sales';
     public const VOLUME_MAGENTO_DEV = './dev';
-    public const VOLUME_DOCKER_ETRYPOINT = '.docker/mysql/docker-entrypoint-initdb.d';
-    public const VOLUME_DOCKER_ETRYPOINT_QUOTE = '.docker/mysql-quote/docker-entrypoint-initdb.d';
-    public const VOLUME_DOCKER_ETRYPOINT_SALES = '.docker/mysql-sales/docker-entrypoint-initdb.d';
+    public const VOLUME_DOCKER_ENTRYPOINT = '.docker/mysql/docker-entrypoint-initdb.d';
+    public const VOLUME_DOCKER_ENTRYPOINT_QUOTE = '.docker/mysql-quote/docker-entrypoint-initdb.d';
+    public const VOLUME_DOCKER_ENTRYPOINT_SALES = '.docker/mysql-sales/docker-entrypoint-initdb.d';
 
     public const SYNC_ENGINE_NATIVE = 'native';
 
diff --git a/src/Compose/DeveloperBuilder.php b/src/Compose/DeveloperBuilder.php
@@ -7,7 +7,6 @@
 
 namespace Magento\CloudDocker\Compose;
 
-use Magento\CloudDocker\App\ConfigurationMismatchException;
 use Magento\CloudDocker\Compose\Php\ExtensionResolver;
 use Magento\CloudDocker\Config\Config;
 use Magento\CloudDocker\Config\Environment\Converter;
@@ -97,14 +96,6 @@ public function build(Config $config): Manager
             $volumes = [$volumePrefix . self::VOLUME_MAGENTO_SYNC . ':' . self::DIR_MAGENTO . ':nocopy'];
         }
 
-        if ($config->hasMariaDbConf()) {
-            $volumesList[$volumePrefix . self::VOLUME_MARIADB_CONF] = [];
-        }
-
-        if ($config->hasDbEntrypoint()) {
-            $volumesList[self::VOLUME_DOCKER_ETRYPOINT] = [];
-        }
-
         $manager->setVolumes($volumesList);
 
         /**
@@ -129,11 +120,11 @@ public function build(Config $config): Manager
         ];
 
         if ($config->hasMariaDbConf()) {
-            $dbVolumes[] = $volumePrefix . self::VOLUME_MARIADB_CONF . ':/etc/mysql/mariadb.conf.d';
+            $dbVolumes[] = self::VOLUME_MARIADB_CONF . ':/etc/mysql/mariadb.conf.d';
         }
 
         if ($config->hasDbEntrypoint()) {
-            $dbVolumes[] = self::VOLUME_DOCKER_ETRYPOINT . ':/docker-entrypoint-initdb.d';
+            $dbVolumes[] = self::VOLUME_DOCKER_ENTRYPOINT . ':/docker-entrypoint-initdb.d';
         }
 
         $manager->updateService(self::SERVICE_DB, [
diff --git a/src/Compose/ProductionBuilder/Service/Database/Db.php b/src/Compose/ProductionBuilder/Service/Database/Db.php
@@ -118,7 +118,7 @@ private function getMounts(Config $config): array
         $mounts[] = $config->getNameWithPrefix() . BuilderInterface::VOLUME_MAGENTO_DB . ':/var/lib/mysql';
 
         if ($config->hasDbEntrypoint()) {
-            $mounts[] = BuilderInterface::VOLUME_DOCKER_ETRYPOINT . ':/docker-entrypoint-initdb.d';
+            $mounts[] = BuilderInterface::VOLUME_DOCKER_ENTRYPOINT . ':/docker-entrypoint-initdb.d';
         }
 
         return $mounts;
diff --git a/src/Compose/ProductionBuilder/Service/Database/DbQuote.php b/src/Compose/ProductionBuilder/Service/Database/DbQuote.php
@@ -113,7 +113,7 @@ private function getMounts(Config $config): array
         }
 
         $mounts[] = BuilderInterface::VOLUME_MAGENTO_DB_QUOTE . ':/var/lib/mysql';
-        $mounts[] = BuilderInterface::VOLUME_DOCKER_ETRYPOINT_QUOTE . ':/docker-entrypoint-initdb.d';
+        $mounts[] = BuilderInterface::VOLUME_DOCKER_ENTRYPOINT_QUOTE . ':/docker-entrypoint-initdb.d';
 
         return $mounts;
     }
diff --git a/src/Compose/ProductionBuilder/Service/Database/DbSales.php b/src/Compose/ProductionBuilder/Service/Database/DbSales.php
@@ -113,7 +113,7 @@ private function getMounts(Config $config): array
         }
 
         $mounts[] = BuilderInterface::VOLUME_MAGENTO_DB_SALES . ':/var/lib/mysql';
-        $mounts[] = BuilderInterface::VOLUME_DOCKER_ETRYPOINT_SALES . ':/docker-entrypoint-initdb.d';
+        $mounts[] = BuilderInterface::VOLUME_DOCKER_ENTRYPOINT_SALES . ':/docker-entrypoint-initdb.d';
 
         return $mounts;
     }
diff --git a/src/Test/Integration/BuildComposeTest.php b/src/Test/Integration/BuildComposeTest.php
@@ -79,6 +79,14 @@ public function buildDataProvider(): array
                     [CliSource::OPTION_WITH_MARIADB_CONF, true]
                 ]
             ],
+            'cloud-base-developer' => [
+                __DIR__ . '/_files/cloud_base_developer',
+                [
+                    [CliSource::OPTION_MODE, BuilderFactory::BUILDER_DEVELOPER],
+                    [CliSource::OPTION_WITH_ENTRYPOINT, true],
+                    [CliSource::OPTION_WITH_MARIADB_CONF, true]
+                ]
+            ],
             'cloud-base-mftf' => [
                 __DIR__ . '/_files/cloud_base_mftf',
                 [
diff --git a/src/Test/Integration/_files/cloud_base_developer/.docker/.gitignore b/src/Test/Integration/_files/cloud_base_developer/.docker/.gitignore
diff --git a/src/Test/Integration/_files/cloud_base_developer/.docker/config.php.dist b/src/Test/Integration/_files/cloud_base_developer/.docker/config.php.dist
@@ -0,0 +1,47 @@
+<?php
+
+return [
+    'MAGENTO_CLOUD_RELATIONSHIPS' => base64_encode(json_encode([
+        'database' => [
+            [
+                'host' => 'db',
+                'path' => 'magento2',
+                'password' => 'magento2',
+                'username' => 'magento2',
+                'port' => '3306'
+            ]
+        ],
+        'redis' => [
+            [
+                'host' => 'redis',
+                'port' => '6379'
+            ]
+        ],
+        'elasticsearch' => [
+            [
+                'host' => 'elasticsearch',
+                'port' => '9200'
+            ]
+        ]
+    ])),
+    'MAGENTO_CLOUD_ROUTES' => base64_encode(json_encode([
+        'http://magento2.docker/' => [
+            'type' => 'upstream',
+            'original_url' => 'http://{default}'
+        ],
+        'https://magento2.docker/' => [
+            'type' => 'upstream',
+            'original_url' => 'https://{default}'
+        ]
+    ])),
+    'MAGENTO_CLOUD_VARIABLES' => base64_encode(json_encode([
+        'ADMIN_EMAIL' => 'admin@example.com',
+        'ADMIN_PASSWORD' => '123123q',
+        'ADMIN_URL' => 'admin'
+    ])),
+    'MAGENTO_CLOUD_APPLICATION' => base64_encode(json_encode([
+        'hooks' => [
+
+        ]
+    ])),
+];
diff --git a/src/Test/Integration/_files/cloud_base_developer/.magento.app.yaml b/src/Test/Integration/_files/cloud_base_developer/.magento.app.yaml
@@ -0,0 +1,29 @@
+name: mymagento
+
+type: php:7.3
+build:
+  flavor: composer
+
+runtime:
+  extensions:
+    - redis
+    - xsl
+    - json
+    - newrelic
+    - sodium
+
+relationships:
+  database: "mysql:mysql"
+  redis: "redis:redis"
+  elasticsearch: "elasticsearch:elasticsearch"
+
+mounts:
+  "var": "shared:files/var"
+  "app/etc": "shared:files/etc"
+  "pub/media": "shared:files/media"
+  "pub/static": "shared:files/static"
+
+crons:
+  cronrun:
+    spec: "* * * * *"
+    cmd: "php bin/magento cron:run"
diff --git a/src/Test/Integration/_files/cloud_base_developer/.magento/services.yaml b/src/Test/Integration/_files/cloud_base_developer/.magento/services.yaml
@@ -0,0 +1,14 @@
+mysql:
+  type: mysql:10.2
+  disk: 2048
+
+redis:
+  type: redis:5.0
+
+elasticsearch:
+  type: elasticsearch:6.5
+  disk: 1024
+  configuration:
+    plugins:
+      - plugin_1
+      - plugin_2
diff --git a/src/Test/Integration/_files/cloud_base_developer/composer.json b/src/Test/Integration/_files/cloud_base_developer/composer.json
@@ -0,0 +1,6 @@
+{
+  "name": "magento/project-enterprise-edition",
+  "description": "Composer file for integration tests",
+  "type": "project",
+  "version": "2.2.0"
+}
diff --git a/src/Test/Integration/_files/cloud_base_developer/docker-compose.exp.yml b/src/Test/Integration/_files/cloud_base_developer/docker-compose.exp.yml
@@ -0,0 +1,168 @@
+version: '2.1'
+services:
+  db:
+    hostname: db.magento2.docker
+    image: 'mariadb:10.2'
+    environment:
+      - MYSQL_ROOT_PASSWORD=magento2
+      - MYSQL_DATABASE=magento2
+      - MYSQL_USER=magento2
+      - MYSQL_PASSWORD=magento2
+    ports:
+      - '3306'
+    volumes:
+      - '.:/app:delegated'
+      - 'mymagento-magento-db:/var/lib/mysql'
+      - '.docker/mysql/mariadb.conf.d:/etc/mysql/mariadb.conf.d'
+      - '.docker/mysql/docker-entrypoint-initdb.d:/docker-entrypoint-initdb.d'
+    healthcheck:
+      test: 'mysqladmin ping -h localhost -pmagento2'
+      interval: 30s
+      timeout: 30s
+      retries: 3
+    networks:
+      magento:
+        aliases:
+          - db.magento2.docker
+  redis:
+    hostname: redis.magento2.docker
+    image: 'redis:5.0'
+    volumes:
+      - '.:/app:delegated'
+    ports:
+      - 6379
+    healthcheck:
+      test: 'redis-cli ping || exit 1'
+      interval: 30s
+      timeout: 30s
+      retries: 3
+    networks:
+      magento:
+        aliases:
+          - redis.magento2.docker
+  elasticsearch:
+    hostname: elasticsearch.magento2.docker
+    image: 'magento/magento-cloud-docker-elasticsearch:6.5-1.2.0'
+    environment:
+      - 'ES_PLUGINS=plugin_1 plugin_2'
+    networks:
+      magento:
+        aliases:
+          - elasticsearch.magento2.docker
+  fpm:
+    hostname: fpm.magento2.docker
+    image: 'magento/magento-cloud-docker-php:7.3-fpm-1.2.0'
+    extends: generic
+    volumes:
+      - '.:/app:delegated'
+    networks:
+      magento:
+        aliases:
+          - fpm.magento2.docker
+    depends_on:
+      db:
+        condition: service_healthy
+  web:
+    hostname: web.magento2.docker
+    image: 'magento/magento-cloud-docker-nginx:1.19-1.2.0'
+    extends: generic
+    volumes:
+      - '.:/app:delegated'
+    environment:
+      - WITH_XDEBUG=0
+      - NGINX_WORKER_PROCESSES=1
+      - NGINX_WORKER_CONNECTIONS=1024
+    networks:
+      magento:
+        aliases:
+          - web.magento2.docker
+    depends_on:
+      fpm:
+        condition: service_started
+  varnish:
+    hostname: varnish.magento2.docker
+    image: 'magento/magento-cloud-docker-varnish:6.2-1.2.0'
+    networks:
+      magento:
+        aliases:
+          - varnish.magento2.docker
+    depends_on:
+      web:
+        condition: service_started
+  tls:
+    hostname: tls.magento2.docker
+    image: 'magento/magento-cloud-docker-nginx:1.19-1.2.0'
+    extends: generic
+    networks:
+      magento:
+        aliases:
+          - magento2.docker
+    environment:
+      - NGINX_WORKER_PROCESSES=1
+      - NGINX_WORKER_CONNECTIONS=1024
+      - UPSTREAM_HOST=varnish
+      - UPSTREAM_PORT=80
+    ports:
+      - '80:80'
+      - '443:443'
+    depends_on:
+      varnish:
+        condition: service_started
+  generic:
+    hostname: generic.magento2.docker
+    image: 'magento/magento-cloud-docker-php:7.3-cli-1.2.0'
+    env_file: ./.docker/config.env
+    environment:
+      - MAGENTO_RUN_MODE=developer
+      - 'PHP_EXTENSIONS=bcmath bz2 calendar exif gd gettext intl mysqli pcntl pdo_mysql soap sockets sysvmsg sysvsem sysvshm opcache zip redis xsl sodium'
+  build:
+    hostname: build.magento2.docker
+    image: 'magento/magento-cloud-docker-php:7.3-cli-1.2.0'
+    extends: generic
+    volumes:
+      - '.:/app:delegated'
+    networks:
+      magento-build:
+        aliases:
+          - build.magento2.docker
+    depends_on:
+      db:
+        condition: service_healthy
+      redis:
+        condition: service_healthy
+      elasticsearch:
+        condition: service_healthy
+  deploy:
+    hostname: deploy.magento2.docker
+    image: 'magento/magento-cloud-docker-php:7.3-cli-1.2.0'
+    extends: generic
+    volumes:
+      - '.:/app:delegated'
+    networks:
+      magento:
+        aliases:
+          - deploy.magento2.docker
+    depends_on:
+      db:
+        condition: service_healthy
+      redis:
+        condition: service_healthy
+      elasticsearch:
+        condition: service_healthy
+  mailhog:
+    hostname: mailhog.magento2.docker
+    image: 'mailhog/mailhog:latest'
+    ports:
+      - '1025:1025'
+      - '8025:8025'
+    networks:
+      magento:
+        aliases:
+          - mailhog.magento2.docker
+volumes:
+  mymagento-magento-db: {  }
+networks:
+  magento:
+    driver: bridge
+  magento-build:
+    driver: bridge

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ private function getMounts(Config $config): array`
`118`	`118`	`$mounts[] = $config->getNameWithPrefix() . BuilderInterface::VOLUME_MAGENTO_DB . ':/var/lib/mysql';`
`119`	`119`
`120`	`120`	`if ($config->hasDbEntrypoint()) {`
`121`		`- $mounts[] = BuilderInterface::VOLUME_DOCKER_ETRYPOINT . ':/docker-entrypoint-initdb.d';`
	`121`	`+ $mounts[] = BuilderInterface::VOLUME_DOCKER_ENTRYPOINT . ':/docker-entrypoint-initdb.d';`
`122`	`122`	`}`
`123`	`123`
`124`	`124`	`return $mounts;`
Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ private function getMounts(Config $config): array`
`113`	`113`	`}`
`114`	`114`
`115`	`115`	`$mounts[] = BuilderInterface::VOLUME_MAGENTO_DB_QUOTE . ':/var/lib/mysql';`
`116`		`- $mounts[] = BuilderInterface::VOLUME_DOCKER_ETRYPOINT_QUOTE . ':/docker-entrypoint-initdb.d';`
	`116`	`+ $mounts[] = BuilderInterface::VOLUME_DOCKER_ENTRYPOINT_QUOTE . ':/docker-entrypoint-initdb.d';`
`117`	`117`
`118`	`118`	`return $mounts;`
`119`	`119`	`}`