B2B-2423: Optimize addProductsToCart operations

Roman Hanin · Roman Hanin · commit 302c0afd6ba8 · 2022-09-19T11:43:29.000-05:00
- CR fixes
diff --git a/app/code/Magento/Quote/Model/Quote.php b/app/code/Magento/Quote/Model/Quote.php
@@ -1844,7 +1844,7 @@ public function updateItem($itemId, $buyRequest, $params = null)
     public function getItemByProduct($product)
     {
         /** @var \Magento\Quote\Model\Quote\Item[] $items */
-        $items = $this->getItemsCollection()->getItemsByColumnValue('product_id', $product->getId()) ?? null;
+        $items = $this->getItemsCollection()->getItemsByColumnValue('product_id', $product->getId()) ?? [];
         foreach ($items as $item) {
             if (!$item->isDeleted()
                 && $item->getProduct()

Original file line number	Diff line number	Diff line change
`@@ -1844,7 +1844,7 @@ public function updateItem($itemId, $buyRequest, $params = null)`
`1844`	`1844`	`public function getItemByProduct($product)`
`1845`	`1845`	`{`
`1846`	`1846`	`/** @var \Magento\Quote\Model\Quote\Item[] $items */`
`1847`		`- $items = $this->getItemsCollection()->getItemsByColumnValue('product_id', $product->getId()) ?? null;`
	`1847`	`+ $items = $this->getItemsCollection()->getItemsByColumnValue('product_id', $product->getId()) ?? [];`
`1848`	`1848`	`foreach ($items as $item) {`
`1849`	`1849`	`if (!$item->isDeleted()`
`1850`	`1850`	`&& $item->getProduct()`