ACP2E-1972: add integration test; fixed unit test

Author: alzota

app/code/Magento/Customer/Test/Unit/Controller/Account/LoginPostTest.php

@@ -24,6 +24,7 @@
 use Magento\Framework\Exception\EmailNotConfirmedException;
 use Magento\Framework\Exception\State\UserLockedException;
 use Magento\Framework\Message\ManagerInterface;
+use Magento\Framework\Session\Generic;
 use Magento\Framework\Stdlib\Cookie\CookieMetadata;
 use Magento\Framework\Stdlib\Cookie\CookieMetadataFactory;
 use Magento\Framework\Stdlib\Cookie\PhpCookieManager;
@@ -102,6 +103,11 @@ class LoginPostTest extends TestCase
      */
     protected $scopeConfig;
 
+    /**
+     * @var Generic|MockObject
+     */
+    private $generic;
+
     protected function setUp(): void
     {
         $this->prepareContext();
@@ -135,13 +141,18 @@ protected function setUp(): void
         $this->scopeConfig = $this->getMockBuilder(ScopeConfigInterface::class)
             ->getMockForAbstractClass();
 
+        $this->generic = $this->getMockBuilder(Generic::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
         $this->controller = new LoginPost(
             $this->context,
             $this->session,
             $this->accountManagement,
             $this->url,
             $this->formkeyValidator,
-            $this->accountRedirect
+            $this->accountRedirect,
+            $this->generic
         );
         $reflection = new \ReflectionClass(get_class($this->controller));
         $reflectionProperty = $reflection->getProperty('scopeConfig');

dev/tests/integration/testsuite/Magento/Customer/Controller/Account/LoginPostTest.php

@@ -12,6 +12,7 @@
 use Magento\Framework\App\Request\Http as HttpRequest;
 use Magento\Framework\Message\MessageInterface;
 use Magento\Framework\Phrase;
+use Magento\Framework\Session\Generic;
 use Magento\Framework\Url\EncoderInterface;
 use Magento\TestFramework\TestCase\AbstractController;
 
@@ -33,6 +34,11 @@ class LoginPostTest extends AbstractController
      */
     private $customerUrl;
 
+    /**
+     * @var Generic
+     */
+    private $generic;
+
     /**
      * @inheritdoc
      */
@@ -43,6 +49,7 @@ protected function setUp(): void
         $this->session = $this->_objectManager->get(Session::class);
         $this->urlEncoder = $this->_objectManager->get(EncoderInterface::class);
         $this->customerUrl = $this->_objectManager->get(Url::class);
+        $this->generic = $this->_objectManager->get(Generic::class);
     }
 
     /**
@@ -220,6 +227,24 @@ public function testNoFormKeyLoginPostAction(): void
         );
     }
 
+    /**
+     * @magentoConfigFixture current_store customer/startup/redirect_dashboard 1
+     * @magentoConfigFixture current_store customer/captcha/enable 0
+     *
+     * @magentoDataFixture Magento/Customer/_files/customer.php
+     *
+     * @return void
+     */
+    public function testVisitorForCustomerLoginPostAction(): void
+    {
+        $this->prepareRequest('customer@example.com', 'password');
+        $this->dispatch('customer/account/loginPost');
+        $this->assertTrue($this->session->isLoggedIn());
+        $this->assertRedirect($this->stringContains('customer/account/'));
+        $this->assertNotEmpty($this->generic->getVisitorData()['visitor_id']);
+        $this->assertNotEmpty($this->generic->getVisitorData()['customer_id']);
+    }
+
     /**
      * Prepare request
      *