Fixed unique id,aria-label and disabled attribute warnings (#4395)

Author: del22123

packages/venia-ui/lib/components/CreateAccount/createAccount.js

@@ -46,7 +46,7 @@ const CreateAccount = props => {
         <Button
             data-cy="CreateAccount-cancelButton"
             className={classes.cancelButton}
-            disabled={isDisabled}
+            disabled={Boolean(isDisabled)}
             type="button"
             priority="low"
             onClick={handleCancel}
@@ -62,7 +62,7 @@ const CreateAccount = props => {
     const submitButton = (
         <Button
             className={classes.submitButton}
-            disabled={isDisabled}
+            disabled={Boolean(isDisabled)}
             type="submit"
             priority="high"
             onKeyDown={handleEnterKeyPress}

packages/venia-ui/lib/components/FilterModal/CurrentFilters/currentFilter.js

@@ -44,7 +44,7 @@ const CurrentFilter = props => {
         <span className={classes.root} data-cy="CurrentFilter-root">
             <Trigger
                 action={handleClick}
-                ariaLabel={ariaLabel}
+                aria-label={ariaLabel}
                 data-cy="CurrentFilter-trigger"
             >
                 <Icon size={20} src={Remove} />

packages/venia-ui/lib/components/Newsletter/__tests__/__snapshots__/newsletter.spec.js.snap

@@ -39,7 +39,7 @@ exports[`#Newsletter display renders correctly 1`] = `
     >
       <label
         className="label"
-        htmlFor="email"
+        htmlFor="emailNews"
       >
         Email
       </label>
@@ -58,7 +58,7 @@ exports[`#Newsletter display renders correctly 1`] = `
           <input
             autoComplete="email"
             className="input"
-            id="email"
+            id="emailNews"
             name="email"
             onBlur={[Function]}
             onChange={[Function]}
@@ -126,7 +126,7 @@ exports[`#Newsletter submit displays an error message if the email already subsc
     >
       <label
         className="label"
-        htmlFor="email"
+        htmlFor="emailNews"
       >
         Email
       </label>
@@ -145,7 +145,7 @@ exports[`#Newsletter submit displays an error message if the email already subsc
           <input
             autoComplete="email"
             className="input"
-            id="email"
+            id="emailNews"
             name="email"
             onBlur={[Function]}
             onChange={[Function]}

packages/venia-ui/lib/components/Newsletter/newsletter.js

@@ -96,7 +96,7 @@ const Newsletter = props => {
                 onSubmit={handleSubmit}
             >
                 <Field
-                    id="email"
+                    id="emailNews"
                     label={formatMessage({
                         id: 'global.email',
                         defaultMessage: 'Email'
@@ -105,7 +105,7 @@ const Newsletter = props => {
                     <TextInput
                         autoComplete="email"
                         field="email"
-                        id="email"
+                        id="emailNews"
                         validate={isRequired}
                     />
                 </Field>

packages/venia-ui/lib/components/SignIn/__tests__/__snapshots__/signIn.spec.js.snap

@@ -37,7 +37,7 @@ exports[`displays an error message if there is a sign in error 1`] = `
     >
       <label
         className="label"
-        htmlFor="email"
+        htmlFor="emailSignIn"
       >
         Email address
       </label>
@@ -57,7 +57,7 @@ exports[`displays an error message if there is a sign in error 1`] = `
             aria-label="Email Required"
             autoComplete="email"
             className="input"
-            id="email"
+            id="emailSignIn"
             name="email"
             onBlur={[Function]}
             onChange={[Function]}
@@ -169,7 +169,7 @@ exports[`renders correctly 1`] = `
     >
       <label
         className="label"
-        htmlFor="email"
+        htmlFor="emailSignIn"
       >
         Email address
       </label>
@@ -189,7 +189,7 @@ exports[`renders correctly 1`] = `
             aria-label="Email Required"
             autoComplete="email"
             className="input"
-            id="email"
+            id="emailSignIn"
             name="email"
             onBlur={[Function]}
             onChange={[Function]}
@@ -301,7 +301,7 @@ exports[`renders prefilled form with initial values 1`] = `
     >
       <label
         className="label"
-        htmlFor="email"
+        htmlFor="emailSignIn"
       >
         Email address
       </label>
@@ -321,7 +321,7 @@ exports[`renders prefilled form with initial values 1`] = `
             aria-label="Email Required"
             autoComplete="email"
             className="input"
-            id="email"
+            id="emailSignIn"
             name="email"
             onBlur={[Function]}
             onChange={[Function]}

packages/venia-ui/lib/components/SignIn/signIn.js

@@ -67,14 +67,14 @@ const SignIn = props => {
                 initialValues={initialValues && initialValues}
             >
                 <Field
-                    id="email"
+                    id="emailSignIn"
                     label={formatMessage({
                         id: 'signIn.emailAddressText',
                         defaultMessage: 'Email address'
                     })}
                 >
                     <TextInput
-                        id="email"
+                        id="emailSignIn"
                         data-cy="SignIn-email"
                         autoComplete="email"
                         field="email"
@@ -124,7 +124,7 @@ const SignIn = props => {
                         type="submit"
                         onKeyDown={signinHandleEnterKeyPress}
                         data-cy="SignInButton-root_highPriority"
-                        disabled={isBusy}
+                        disabled={Boolean(isBusy)}
                     >
                         <FormattedMessage
                             id={'signIn.signInText'}