From 793c7bd1e93861d5a18147af71d25ced322186d8 Mon Sep 17 00:00:00 2001 From: Tom Tan Date: Wed, 28 May 2025 15:18:55 -0700 Subject: [PATCH] [BUILD] Propagate INTERFACE_COMPILE_DEFINITIONS from API through common_foo_library (#3440) --- CHANGELOG.md | 3 +++ examples/common/foo_library/CMakeLists.txt | 2 +- examples/common/logs_foo_library/CMakeLists.txt | 2 +- examples/common/metrics_foo_library/CMakeLists.txt | 2 +- 4 files changed, 6 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 13f9335703..3c7990bc65 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,9 @@ Increment the: ## [Unreleased] +* [BUILD] Propagate INTERFACE_COMPILE_DEFINITIONS from API through common_foo_library + [#3440](https://github.com/open-telemetry/opentelemetry-cpp/pull/3440) + * [BUILD] Error out when building DLL without MSVC [#3438](https://github.com/open-telemetry/opentelemetry-cpp/pull/3438) diff --git a/examples/common/foo_library/CMakeLists.txt b/examples/common/foo_library/CMakeLists.txt index 7306c3a5af..58cb179f81 100644 --- a/examples/common/foo_library/CMakeLists.txt +++ b/examples/common/foo_library/CMakeLists.txt @@ -12,4 +12,4 @@ endif() target_include_directories(common_foo_library PUBLIC "$") -target_link_libraries(common_foo_library PRIVATE opentelemetry-cpp::api) +target_link_libraries(common_foo_library PUBLIC opentelemetry-cpp::api) diff --git a/examples/common/logs_foo_library/CMakeLists.txt b/examples/common/logs_foo_library/CMakeLists.txt index 5d66099e8a..af6207ca96 100644 --- a/examples/common/logs_foo_library/CMakeLists.txt +++ b/examples/common/logs_foo_library/CMakeLists.txt @@ -13,4 +13,4 @@ endif() target_include_directories(common_logs_foo_library PUBLIC $) -target_link_libraries(common_logs_foo_library PRIVATE opentelemetry-cpp::api) +target_link_libraries(common_logs_foo_library PUBLIC opentelemetry-cpp::api) diff --git a/examples/common/metrics_foo_library/CMakeLists.txt b/examples/common/metrics_foo_library/CMakeLists.txt index 1c9e388966..64a4b53aca 100644 --- a/examples/common/metrics_foo_library/CMakeLists.txt +++ b/examples/common/metrics_foo_library/CMakeLists.txt @@ -13,4 +13,4 @@ endif() target_include_directories(common_metrics_foo_library PUBLIC $) -target_link_libraries(common_metrics_foo_library PRIVATE opentelemetry-cpp::api) +target_link_libraries(common_metrics_foo_library PUBLIC opentelemetry-cpp::api)