Skip to content

Commit 8aeae0d

Browse files
author
Marcel Schnelle
authored
Remove dependency on deprecated junit-platform-gradle-plugin by migrating Extensions to Kotlin (#69)
1 parent 00147e9 commit 8aeae0d

File tree

20 files changed

+937
-719
lines changed

20 files changed

+937
-719
lines changed

android-junit5-tests/src/test/kotlin/de/mannodermaus/gradle/plugins/junit5/ExtensionSpec.kt

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
package de.mannodermaus.gradle.plugins.junit5
22

33
import com.android.build.gradle.api.BaseVariant
4+
import de.mannodermaus.gradle.plugins.junit5.internal.ConfigurationKind
5+
import de.mannodermaus.gradle.plugins.junit5.internal.ConfigurationScope
6+
import de.mannodermaus.gradle.plugins.junit5.internal.find
47
import org.assertj.core.api.Assertions.assertThat
58
import org.gradle.api.artifacts.Configuration
69
import org.jetbrains.spek.api.Spek
@@ -17,7 +20,7 @@ import org.mockito.Mockito
1720
*/
1821
class ExtensionSpec : Spek({
1922

20-
describe("tests for ConfigurationContainer#findConfiguration()") {
23+
describe("tests for ConfigurationContainer#find()") {
2124

2225
// Quick-hand mock creator for Configurations
2326
fun mockConfiguration(name: String): Configuration =
@@ -137,7 +140,7 @@ class ExtensionSpec : Spek({
137140
pairs.forEach { (kind, expected) ->
138141

139142
it("finds configuration '${expected.name}' for kind == $kind") {
140-
assertThat(container.findConfiguration(
143+
assertThat(container.find(
141144
variant = variant,
142145
kind = kind,
143146
scope = scope))

android-junit5-tests/src/test/kotlin/de/mannodermaus/gradle/plugins/junit5/PluginSpec.kt

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,10 @@
22

33
package de.mannodermaus.gradle.plugins.junit5
44

5-
import de.mannodermaus.gradle.plugins.junit5.ConfigurationKind.ANDROID_TEST
6-
import de.mannodermaus.gradle.plugins.junit5.ConfigurationScope.RUNTIME_ONLY
5+
import de.mannodermaus.gradle.plugins.junit5.internal.ConfigurationKind.ANDROID_TEST
6+
import de.mannodermaus.gradle.plugins.junit5.internal.ConfigurationScope.RUNTIME_ONLY
7+
import de.mannodermaus.gradle.plugins.junit5.internal.android
8+
import de.mannodermaus.gradle.plugins.junit5.internal.find
79
import de.mannodermaus.gradle.plugins.junit5.tasks.AndroidJUnit5JacocoReport
810
import de.mannodermaus.gradle.plugins.junit5.tasks.AndroidJUnit5UnitTest
911
import de.mannodermaus.gradle.plugins.junit5.util.TestEnvironment
@@ -259,7 +261,7 @@ class PluginSpec : Spek({
259261
}
260262

261263
it("automatically includes instrumentation-test-runner at runtime") {
262-
val androidTestRuntimeOnly = project.configurations.findConfiguration(
264+
val androidTestRuntimeOnly = project.configurations.find(
263265
kind = ANDROID_TEST, scope = RUNTIME_ONLY)
264266

265267
assertThat(androidTestRuntimeOnly.dependencies
@@ -679,7 +681,7 @@ class PluginSpec : Spek({
679681
on("replacing class rules") {
680682
project.android.testOptions.junitPlatform {
681683
jacocoOptions {
682-
excludedClasses = emptyList()
684+
excludedClasses = mutableListOf()
683685
}
684686
}
685687

android-junit5/build.gradle

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,13 +75,14 @@ task test(overwrite: true) {}
7575

7676
dependencies {
7777
// Language Support
78-
compile gradleApi()
79-
compile "org.codehaus.groovy:groovy:$GROOVY_VERSION"
80-
compile "org.jetbrains.kotlin:kotlin-stdlib:$KOTLIN_VERSION"
78+
implementation gradleApi()
79+
implementation "org.codehaus.groovy:groovy:$GROOVY_VERSION"
80+
implementation "org.jetbrains.kotlin:kotlin-stdlib:$KOTLIN_VERSION"
8181

8282
// Dependent Plugins
83-
compile "org.junit.platform:junit-platform-gradle-plugin:$JUNIT_PLATFORM_VERSION"
84-
compile "com.android.tools.build:gradle:$ANDROID_PLUGIN_VERSION"
83+
implementation "org.junit.platform:junit-platform-console:$JUNIT_PLATFORM_VERSION"
84+
implementation "org.junit.platform:junit-platform-commons:$JUNIT_PLATFORM_VERSION"
85+
implementation "com.android.tools.build:gradle:$ANDROID_PLUGIN_VERSION"
8586
compileOnly "org.jetbrains.kotlin:kotlin-gradle-plugin:$KOTLIN_VERSION"
8687
}
8788

android-junit5/src/main/groovy/de/mannodermaus/gradle/plugins/junit5/AndroidJUnitPlatformExtension.groovy

Lines changed: 0 additions & 281 deletions
This file was deleted.

0 commit comments

Comments
 (0)