test: add tests for kube-version handling in install and upgrade commands

Author: manusa

helm-java/src/test/java/com/marcnuri/helm/HelmInstallTest.java

@@ -230,18 +230,18 @@ void withDisableOpenApiValidation() {
         .hasFieldOrPropertyWithValue("status", "deployed");
     }
 
-      @Test
-      void withKubeVersion() {
-          final Release result = helm.install()
-                  .clientOnly()
-                  .debug()
-                  .withName("test-kube-version")
-                  .withKubeVersion("1.21.0")
-                  .call();
-          assertThat(result)
-                  .returns("test-kube-version", Release::getName)
-                  .returns("deployed", Release::getStatus);
-      }
+    @Test
+    void withKubeVersion() {
+      final Release result = helm.install()
+        .clientOnly()
+        .debug()
+        .withName("test-kube-version")
+        .withKubeVersion("1.21.0")
+        .call();
+      assertThat(result)
+        .returns("test-kube-version", Release::getName)
+        .returns("deployed", Release::getStatus);
+    }
 
     @Test
     void skipCrdsWithoutCrdsInChart() {
@@ -322,7 +322,10 @@ void withInvalidKubeVersion() {
         .withKubeVersion("invalid");
       assertThatThrownBy(install::call)
         .isInstanceOf(IllegalStateException.class)
-        .hasMessageContaining("Invalid semantic version");
+        .message().containsAnyOf(
+  "Invalid semantic version",
+          "could not parse \"invalid\" as version"
+        );
     }
 
 //    @Test

helm-java/src/test/java/com/marcnuri/helm/HelmKubernetesTest.java

@@ -570,6 +570,19 @@ void withInstall() {
           .returns("deployed", Release::getStatus);
       }
 
+      @Test
+      void withInstallAndKubeVersion() {
+        final Release result = helm.upgrade()
+          .withKubeConfig(kubeConfigFile)
+          .install()
+          .withName("upgrade-with-kube-version")
+          .withKubeVersion("v1.21.0")
+          .call();
+        assertThat(result)
+          .returns("1", Release::getRevision)
+          .returns("deployed", Release::getStatus);
+      }
+
       @Test
       void withPriorInstall() {
         helm.install().withName("upgrade-prior-install").withKubeConfig(kubeConfigFile).call();
@@ -732,6 +745,18 @@ void lowTimeout() {
           .message()
           .contains("context deadline exceeded");
       }
+
+      @Test
+      void withInstallAndInvalidKubeVersion() {
+        final UpgradeCommand upgrade = helm.upgrade()
+          .withKubeConfig(kubeConfigFile)
+          .install()
+          .withName("upgrade-invalid-kube-version")
+          .withKubeVersion("invalid");
+        assertThatThrownBy(upgrade::call)
+          .isInstanceOf(IllegalStateException.class)
+          .hasMessageContaining("Invalid semantic version");
+      }
     }
   }
 }

helm-java/src/test/java/com/marcnuri/helm/HelmTemplateTest.java

@@ -109,14 +109,14 @@ void withInvalidValuesAndDebug() {
         .hasMessageContaining("name: release-name-local-chart-test");
     }
 
-      @Test
-      void withKubeVersion() {
-          final String result = helm.template()
-                  .withKubeVersion("1.21.0")
-                  .call();
-          assertThat(result)
-                  .contains("name: release-name-local-chart-test");
-      }
+    @Test
+    void withKubeVersion() {
+      final String result = helm.template()
+        .withKubeVersion("1.21.0")
+        .call();
+      assertThat(result)
+        .contains("name: release-name-local-chart-test");
+    }
 
     @Test
     void skipCrdsWithoutCrdsInChart() {