added validate path tests and settings

Author: marcanuy

dynamic_breadcrumbs/utils.py

@@ -33,10 +33,11 @@ def validate_path(path):
         logger.warning("Invalid path type provided: %s", type(path))
         return ""
 
-    # Ensure the path contains only alphanumeric characters, dashes, underscores, and slashes
-    if not re.match(r'^[a-zA-Z0-9_\-/]*$', path):
-        logger.warning("Invalid path provided: %s", path)
-        return ""
+    if app_settings.PATH_ONLY_ALPHANUMERIC:
+        # Ensure the path contains only alphanumeric characters, dashes, underscores, and slashes
+        if not re.match(r'^[a-zA-Z0-9_\-/]*$', path):
+            logger.warning("Invalid path provided: %s", path)
+            return ""
 
     components = path.split('/')
     # Check path depth

tests/tests.py

@@ -4,8 +4,9 @@
 from dynamic_breadcrumbs import app_settings
 from django.conf import settings
 from django.http import HttpResponse, HttpRequest
+from dynamic_breadcrumbs import app_settings
 
-@override_settings(ALLOWED_HOSTS="www.example.com")
+@override_settings(ALLOWED_HOSTS=["www.example.com"])
 class SanitizeUrlTests(TestCase):
 
     def test_sanitize_base_urls_host_in_allowed_hosts_keeps_url(self):
@@ -22,13 +23,29 @@ def test_sanitize_base_urls_host_not_in_allowed_hosts_returns_empty_string(self)
 
         self.assertEqual(result, "")
 
-# class ValidatePathTests(GenericModelTestCase):
-#     def test_sanitize_base_urls_host_in_allowed_hosts_keeps_url(self):
-#         path= f"https://{settings.ALLOWED_HOSTS[0]}"
+class ValidatePathTests(TestCase):
+    def test_validate_path_not_string_returns_empty_string(self):
+        path=3.1416
+        
+        result = validate_path(path=path)
+        
+        self.assertEqual(result, "")
+
+    def test_validate_path_check_alphanumeric_returns_empty_string(self):
+        app_settings.PATH_ALPHANUMERIC=True
+        path="*%#$@@#*(/%#%_)*"
+        
+        result = validate_path(path=path)
+        
+        self.assertEqual(result, "")
+    
+    def test_validate_path_non_check_alphanumeric_returns_path(self):
+        app_settings.PATH_ALPHANUMERIC=False
+        path="*%#$@@#*(/%#%_)*"
 
-#         result = sanitize_url(url=base_url)
+        result = validate_path(path=path)
 
-#         self.assertEqual(result, base_url)
+        self.assertEqual(result, path)
 
 
 class BreadcrumbsTests(TestCase):