Skip to content

Commit 7ba442d

Browse files
no message
1 parent 3dd6f98 commit 7ba442d

File tree

12 files changed

+50
-41
lines changed

12 files changed

+50
-41
lines changed

tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/JsonObjectAggTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ protected function getStringFunctions(): array
1717
}
1818

1919
#[Test]
20-
public function json_object_agg_simple(): void
20+
public function can_aggregate_key_value_pairs_to_json_object(): void
2121
{
2222
$dql = "SELECT JSON_OBJECT_AGG('key', t.object1) as result
2323
FROM Fixtures\\MartinGeorgiev\\Doctrine\\Entity\\ContainsJsons t

tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/JsonbObjectKeysTest.php

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,21 @@ protected function getStringFunctions(): array
1717
}
1818

1919
#[Test]
20-
public function can_extract_object_keys_from_jsonb(): void
20+
public function extracts_object_keys_from_jsonb(): void
2121
{
2222
$dql = 'SELECT JSONB_OBJECT_KEYS(t.object1) as result
2323
FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsJsons t
2424
WHERE t.id = 1';
2525
$result = $this->executeDqlQuery($dql);
2626
$this->assertIsString($result[0]['result']);
27+
28+
$keys = $this->transformPostgresArray($result[0]['result']);
29+
$this->assertIsArray($keys);
30+
$this->assertCount(4, $keys);
31+
32+
$expectedKeys = ['name', 'age', 'address', 'tags'];
33+
foreach ($expectedKeys as $expectedKey) {
34+
$this->assertContains($expectedKey, $keys, "Expected key '{$expectedKey}' should be present in the extracted keys");
35+
}
2736
}
2837
}

tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/JsonbPathExistsTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ protected function getStringFunctions(): array
1717
}
1818

1919
#[Test]
20-
public function jsonb_path_exists_with_simple_path(): void
20+
public function can_check_simple_path_exists(): void
2121
{
2222
$dql = 'SELECT JSONB_PATH_EXISTS(:json, :path) as result
2323
FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsJsons t
@@ -30,7 +30,7 @@ public function jsonb_path_exists_with_simple_path(): void
3030
}
3131

3232
#[Test]
33-
public function jsonb_path_exists_with_nested_path(): void
33+
public function can_check_nested_path_exists(): void
3434
{
3535
$dql = 'SELECT JSONB_PATH_EXISTS(:json, :path) as result
3636
FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsJsons t
@@ -43,7 +43,7 @@ public function jsonb_path_exists_with_nested_path(): void
4343
}
4444

4545
#[Test]
46-
public function jsonb_path_exists_with_missing_path(): void
46+
public function returns_false_for_missing_path(): void
4747
{
4848
$dql = 'SELECT JSONB_PATH_EXISTS(:json, :path) as result
4949
FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsJsons t
@@ -56,7 +56,7 @@ public function jsonb_path_exists_with_missing_path(): void
5656
}
5757

5858
#[Test]
59-
public function jsonb_path_exists_with_column_reference(): void
59+
public function can_check_path_exists_in_column_reference(): void
6060
{
6161
$dql = 'SELECT JSONB_PATH_EXISTS(t.object1, :path) as result
6262
FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsJsons t

tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/JsonbSetLaxTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ protected function getStringFunctions(): array
1717
}
1818

1919
#[Test]
20-
public function jsonb_set_lax_update_existing_value(): void
20+
public function can_update_existing_value(): void
2121
{
2222
$dql = 'SELECT JSONB_SET_LAX(t.object1, :path, :value) as result
2323
FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsJsons t
@@ -34,7 +34,7 @@ public function jsonb_set_lax_update_existing_value(): void
3434
}
3535

3636
#[Test]
37-
public function jsonb_set_lax_add_new_value(): void
37+
public function can_add_new_value(): void
3838
{
3939
$dql = 'SELECT JSONB_SET_LAX(t.object1, :path, :value) as result
4040
FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsJsons t
@@ -51,7 +51,7 @@ public function jsonb_set_lax_add_new_value(): void
5151
}
5252

5353
#[Test]
54-
public function jsonb_set_lax_nested_path(): void
54+
public function can_set_nested_path(): void
5555
{
5656
$dql = 'SELECT JSONB_SET_LAX(t.object1, :path, :value) as result
5757
FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsJsons t
@@ -70,7 +70,7 @@ public function jsonb_set_lax_nested_path(): void
7070
}
7171

7272
#[Test]
73-
public function jsonb_set_lax_with_invalid_path(): void
73+
public function does_not_add_value_for_invalid_path(): void
7474
{
7575
$dql = 'SELECT JSONB_SET_LAX(t.object1, :path, :value) as result
7676
FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsJsons t
@@ -82,6 +82,6 @@ public function jsonb_set_lax_with_invalid_path(): void
8282
$this->assertIsString($result[0]['result']);
8383
$decoded = \json_decode($result[0]['result'], true);
8484
$this->assertIsArray($decoded);
85-
self::assertArrayNotHasKey('invalid', $decoded);
85+
$this->assertArrayNotHasKey('invalid', $decoded);
8686
}
8787
}

tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/JsonbSetTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ protected function getStringFunctions(): array
1717
}
1818

1919
#[Test]
20-
public function jsonb_set_update_existing_value(): void
20+
public function can_update_existing_value(): void
2121
{
2222
$dql = 'SELECT JSONB_SET(t.object1, :path, :value) as result
2323
FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsJsons t
@@ -34,7 +34,7 @@ public function jsonb_set_update_existing_value(): void
3434
}
3535

3636
#[Test]
37-
public function jsonb_set_add_new_value(): void
37+
public function can_add_new_value(): void
3838
{
3939
$dql = 'SELECT JSONB_SET(t.object1, :path, :value) as result
4040
FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsJsons t
@@ -51,7 +51,7 @@ public function jsonb_set_add_new_value(): void
5151
}
5252

5353
#[Test]
54-
public function jsonb_set_nested_path(): void
54+
public function can_set_nested_path(): void
5555
{
5656
$dql = 'SELECT JSONB_SET(t.object1, :path, :value) as result
5757
FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsJsons t
@@ -70,7 +70,7 @@ public function jsonb_set_nested_path(): void
7070
}
7171

7272
#[Test]
73-
public function jsonb_set_with_create_missing_false(): void
73+
public function does_not_create_missing_key_when_create_missing_is_false(): void
7474
{
7575
$dql = "SELECT JSONB_SET(t.object1, :path, :value, 'false') as result
7676
FROM Fixtures\\MartinGeorgiev\\Doctrine\\Entity\\ContainsJsons t
@@ -82,6 +82,6 @@ public function jsonb_set_with_create_missing_false(): void
8282
$this->assertIsString($result[0]['result']);
8383
$decoded = \json_decode($result[0]['result'], true);
8484
$this->assertIsArray($decoded);
85-
self::assertArrayNotHasKey('nonexistent', $decoded);
85+
$this->assertArrayNotHasKey('nonexistent', $decoded);
8686
}
8787
}

tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/NumrangeTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,15 @@ protected function getStringFunctions(): array
1717
}
1818

1919
#[Test]
20-
public function numrange(): void
20+
public function can_create_range_with_default_bounds(): void
2121
{
2222
$dql = 'SELECT NUMRANGE(t.decimal1, t.decimal2) as result FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsNumerics t WHERE t.id = 1';
2323
$result = $this->executeDqlQuery($dql);
2424
$this->assertSame('[10.5,20.5)', $result[0]['result']);
2525
}
2626

2727
#[Test]
28-
public function numrange_with_bounds(): void
28+
public function can_create_range_with_custom_bounds(): void
2929
{
3030
$dql = "SELECT NUMRANGE(t.decimal1, t.decimal2, '(]') as result FROM Fixtures\\MartinGeorgiev\\Doctrine\\Entity\\ContainsNumerics t WHERE t.id = 1";
3131
$result = $this->executeDqlQuery($dql);

tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/PowerTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ protected function getStringFunctions(): array
1717
}
1818

1919
#[Test]
20-
public function power_with_integer_exponent(): void
20+
public function can_calculate_with_integer_exponent(): void
2121
{
2222
$dql = 'SELECT POWER(2, 3) as result
2323
FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsNumerics n
@@ -27,7 +27,7 @@ public function power_with_integer_exponent(): void
2727
}
2828

2929
#[Test]
30-
public function power_with_fractional_exponent(): void
30+
public function can_calculate_with_fractional_exponent(): void
3131
{
3232
$dql = 'SELECT POWER(9, 0.5) as result
3333
FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsNumerics n
@@ -37,7 +37,7 @@ public function power_with_fractional_exponent(): void
3737
}
3838

3939
#[Test]
40-
public function power_with_negative_base(): void
40+
public function can_calculate_with_negative_base(): void
4141
{
4242
$dql = 'SELECT POWER((-2), 3) as result
4343
FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsNumerics n
@@ -47,7 +47,7 @@ public function power_with_negative_base(): void
4747
}
4848

4949
#[Test]
50-
public function power_with_negative_exponent(): void
50+
public function can_calculate_with_negative_exponent(): void
5151
{
5252
$dql = 'SELECT POWER(2, (-2)) as result
5353
FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsNumerics n
@@ -57,7 +57,7 @@ public function power_with_negative_exponent(): void
5757
}
5858

5959
#[Test]
60-
public function power_with_column_values(): void
60+
public function can_calculate_with_column_values(): void
6161
{
6262
$dql = 'SELECT POWER(n.decimal1, n.decimal2) as result
6363
FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsNumerics n

tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/RadiansTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,15 @@ protected function getStringFunctions(): array
1717
}
1818

1919
#[Test]
20-
public function radians(): void
20+
public function can_convert_degrees_to_radians(): void
2121
{
2222
$dql = 'SELECT RADIANS(180) as result FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsNumerics t WHERE t.id = 1';
2323
$result = $this->executeDqlQuery($dql);
2424
$this->assertEqualsWithDelta(3.141592653589793, $result[0]['result'], 0.0001);
2525
}
2626

2727
#[Test]
28-
public function radians_with_entity_property(): void
28+
public function can_convert_decimal_entity_property_to_radians(): void
2929
{
3030
$dql = 'SELECT RADIANS(n.decimal1) as result FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsNumerics n WHERE n.id = 1';
3131
$result = $this->executeDqlQuery($dql);

tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/RoundTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ protected function getStringFunctions(): array
1717
}
1818

1919
#[Test]
20-
public function round_with_positive_number(): void
20+
public function can_round_positive_number(): void
2121
{
2222
$dql = 'SELECT ROUND(:number) as result
2323
FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsNumerics t
@@ -27,7 +27,7 @@ public function round_with_positive_number(): void
2727
}
2828

2929
#[Test]
30-
public function round_with_negative_number(): void
30+
public function can_round_negative_number(): void
3131
{
3232
$dql = 'SELECT ROUND(:number) as result
3333
FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsNumerics t
@@ -37,7 +37,7 @@ public function round_with_negative_number(): void
3737
}
3838

3939
#[Test]
40-
public function round_with_precision(): void
40+
public function can_round_with_precision(): void
4141
{
4242
$dql = 'SELECT ROUND(:number, :precision) as result
4343
FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsNumerics t
@@ -50,7 +50,7 @@ public function round_with_precision(): void
5050
}
5151

5252
#[Test]
53-
public function round_with_negative_precision(): void
53+
public function can_round_with_negative_precision(): void
5454
{
5555
$dql = 'SELECT ROUND(:number, :precision) as result
5656
FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsNumerics t
@@ -63,7 +63,7 @@ public function round_with_negative_precision(): void
6363
}
6464

6565
#[Test]
66-
public function round_with_column_value(): void
66+
public function can_round_column_value(): void
6767
{
6868
$dql = 'SELECT ROUND(t.decimal1) as result
6969
FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsNumerics t

tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/ToDateTest.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,39 +19,39 @@ protected function getStringFunctions(): array
1919
}
2020

2121
#[Test]
22-
public function todate(): void
22+
public function can_convert_string_to_date(): void
2323
{
2424
$dql = "SELECT TO_DATE('05 Dec 2000', 'DD Mon YYYY') as result FROM Fixtures\\MartinGeorgiev\\Doctrine\\Entity\\ContainsTexts t WHERE t.id = 1";
2525
$result = $this->executeDqlQuery($dql);
26-
static::assertSame('2000-12-05', $result[0]['result']);
26+
$this->assertSame('2000-12-05', $result[0]['result']);
2727
}
2828

2929
#[Test]
30-
public function todate_throws_with_invalid_input(): void
30+
public function throws_exception_for_invalid_date_input(): void
3131
{
3232
$this->expectException(DriverException::class);
3333
$dql = "SELECT TO_DATE('invalid_date', 'DD Mon YYYY') as result FROM Fixtures\\MartinGeorgiev\\Doctrine\\Entity\\ContainsTexts t WHERE t.id = 1";
3434
$this->executeDqlQuery($dql);
3535
}
3636

3737
#[Test]
38-
public function todate_with_invalid_format(): void
38+
public function returns_default_date_for_invalid_format(): void
3939
{
4040
$dql = "SELECT TO_DATE('05 Dec 2000', 'invalid_format') as result FROM Fixtures\\MartinGeorgiev\\Doctrine\\Entity\\ContainsTexts t WHERE t.id = 1";
4141
$result = $this->executeDqlQuery($dql);
42-
static::assertSame('2005-01-01', $result[0]['result']);
42+
$this->assertSame('2005-01-01', $result[0]['result']);
4343
}
4444

4545
#[Test]
46-
public function todate_throws_with_unsupported_format_type(): void
46+
public function throws_exception_for_unsupported_format_type(): void
4747
{
4848
$this->expectException(QueryException::class);
4949
$dql = "SELECT TO_DATE('05 Dec 2000', 1) as result FROM Fixtures\\MartinGeorgiev\\Doctrine\\Entity\\ContainsTexts t WHERE t.id = 1";
5050
$this->executeDqlQuery($dql);
5151
}
5252

5353
#[Test]
54-
public function todate_throws_with_unsupported_null_input(): void
54+
public function throws_exception_for_null_input(): void
5555
{
5656
$this->expectException(QueryException::class);
5757
$dql = "SELECT TO_DATE(null, 'DD Mon YYYY') as result FROM Fixtures\\MartinGeorgiev\\Doctrine\\Entity\\ContainsTexts t WHERE t.id = 1";

0 commit comments

Comments
 (0)