fix: improve type validation in LtreeTypeTest

Author: landure

tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/LtreeTypeTest.php

@@ -51,16 +51,20 @@ public function can_handle_string_values(): void
      */
     protected function assertTypeValueEquals(mixed $expected, mixed $actual, string $typeName): void
     {
-        if (!$expected instanceof LtreeValueObject && !\is_string($expected) || !$actual instanceof LtreeValueObject) {
-            throw new \InvalidArgumentException('LtreeTypeTest expects Ltree value objects.');
+        if (!$actual instanceof LtreeValueObject) {
+            throw new \InvalidArgumentException('LtreeTypeTest expects actual value to be a Ltree object');
+        }
+
+        if (!$expected instanceof LtreeValueObject && !\is_string($expected)) {
+            throw new \InvalidArgumentException('LtreeTypeTest expects expected value to be a Ltree object or string');
         }
 
         $this->assertLtreeEquals($expected, $actual, $typeName);
     }
 
     #[DataProvider('provideValidTransformations')]
     #[Test]
-    public function can_handle_ltree_values(string $testName, LtreeValueObject $ltreeValueObject): void
+    public function can_handle_ltree_values(LtreeValueObject $ltreeValueObject): void
     {
         $typeName = $this->getTypeName();
         $columnType = $this->getPostgresTypeName();
@@ -69,15 +73,15 @@ public function can_handle_ltree_values(string $testName, LtreeValueObject $ltre
     }
 
     /**
-     * @return array<string, array{string, ?LtreeValueObject}>
+     * @return array<string, array{LtreeValueObject}>
      */
     public static function provideValidTransformations(): array
     {
         return [
-            'ltree simple string' => ['ltree simple string', new LtreeValueObject(['foo', 'bar', 'baz'])],
-            'ltree simple numeric' => ['ltree simple numeric', new LtreeValueObject(['1', '2', '3'])],
-            'ltree single numeric' => ['ltree single numeric', new LtreeValueObject(['1'])],
-            'ltree empty' => ['ltree empty', new LtreeValueObject([])],
+            'ltree simple string' => [new LtreeValueObject(['foo', 'bar', 'baz'])],
+            'ltree simple numeric' => [new LtreeValueObject(['1', '2', '3'])],
+            'ltree single numeric' => [new LtreeValueObject(['1'])],
+            'ltree empty' => [new LtreeValueObject([])],
         ];
     }