Skip to content

Commit 82fe9c8

Browse files
committed
refactor(when): adapt with dependencies upgrade
1 parent b680b15 commit 82fe9c8

File tree

1 file changed

+13
-12
lines changed

1 file changed

+13
-12
lines changed

src/when.ts

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,42 +1,43 @@
1-
import { Level, Rule } from '@commitlint/load';
1+
import type { RuleConfigTuple } from '@commitlint/types';
2+
import { RuleConfigSeverity } from '@commitlint/types';
23

3-
export function enumWhen(rule: Rule<string[]> | undefined) {
4-
if (rule == null) {
4+
export function enumWhen(rule: RuleConfigTuple<string[]> | undefined): boolean {
5+
if (rule === undefined) {
56
return true;
67
}
78

89
const [level, applicable, value] = rule;
910

10-
if (level == Level.Disable) {
11+
if (level === RuleConfigSeverity.Disabled) {
1112
return true;
1213
}
1314

14-
const emptyEnum = value.length == 0;
15+
const emptyEnum = value?.length === 0;
1516

16-
if (applicable == 'always') {
17+
if (applicable === 'always') {
1718
return !emptyEnum;
1819
}
1920

2021
return true;
2122
}
2223

23-
export function emptyWhen(rule: Rule<undefined> | undefined) {
24-
if (rule == null) {
24+
export function emptyWhen(rule: RuleConfigTuple<undefined> | undefined): boolean {
25+
if (rule === undefined) {
2526
return true;
2627
}
2728

2829
const [level, applicable] = rule;
2930

30-
if (level == Level.Disable) {
31+
if (level === RuleConfigSeverity.Disabled) {
3132
return true;
3233
}
3334

34-
return applicable == 'never';
35+
return applicable === 'never';
3536
}
3637

3738
export function whenFactory(
38-
enumRule: Rule<string[]> | undefined,
39-
emptyRule: Rule<undefined> | undefined
39+
enumRule: RuleConfigTuple<string[]> | undefined,
40+
emptyRule: RuleConfigTuple<undefined> | undefined
4041
): () => boolean {
4142
return () => {
4243
// return false if either of the rules return false

0 commit comments

Comments
 (0)