Skip to content

Commit ba696b6

Browse files
ymariancketcham
authored andcommitted
Verify typography subsystem is complete for Bottom Navigation
PiperOrigin-RevId: 204798141
1 parent 5b2d4d6 commit ba696b6

File tree

2 files changed

+11
-26
lines changed

2 files changed

+11
-26
lines changed

lib/java/com/google/android/material/bottomnavigation/BottomNavigationView.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,9 @@ public BottomNavigationView(Context context, AttributeSet attrs, int defStyleAtt
140140
attrs,
141141
R.styleable.BottomNavigationView,
142142
defStyleAttr,
143-
R.style.Widget_Design_BottomNavigationView);
143+
R.style.Widget_Design_BottomNavigationView,
144+
R.styleable.BottomNavigationView_itemTextAppearanceInactive,
145+
R.styleable.BottomNavigationView_itemTextAppearanceActive);
144146

145147
if (a.hasValue(R.styleable.BottomNavigationView_itemIconTint)) {
146148
menuView.setIconTintList(a.getColorStateList(R.styleable.BottomNavigationView_itemIconTint));

lib/java/com/google/android/material/bottomnavigation/res/values/styles.xml

Lines changed: 8 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -18,25 +18,23 @@
1818

1919
<style name="Widget.Design.BottomNavigationView" parent="">
2020
<item name="elevation">@dimen/design_bottom_navigation_elevation</item>
21-
<item name="labelVisibilityMode">auto</item>
2221
<item name="itemBackground">?attr/selectableItemBackgroundBorderless</item>
2322
<item name="itemHorizontalTranslationEnabled">true</item>
2423
<item name="itemIconSize">@dimen/design_bottom_navigation_icon_size</item>
24+
<item name="labelVisibilityMode">auto</item>
2525
</style>
2626

2727
<!-- Default style for BottomNavigationViews.
2828
Use the default style to get the default bottom navigation bar with a white background and
2929
colorPrimary for the icon and text colors. -->
3030
<style name="Widget.MaterialComponents.BottomNavigationView" parent="Widget.Design.BottomNavigationView">
3131
<item name="android:background">@android:color/white</item>
32+
<item name="enforceTextAppearance">true</item>
3233
<item name="itemHorizontalTranslationEnabled">false</item>
3334
<item name="itemIconTint">@color/mtrl_bottom_nav_item_tint</item>
34-
<item name="itemTextAppearanceInactive">
35-
@style/TextAppearance.MaterialComponents.BottomNavigationView
36-
</item>
37-
<item name="itemTextAppearanceActive">
38-
@style/TextAppearance.MaterialComponents.BottomNavigationView.Active
39-
</item>
35+
<item name="itemTextAppearanceInactive">?attr/textAppearanceCaption</item>
36+
<item name="itemTextAppearanceActive">?attr/textAppearanceCaption</item>
37+
<item name="itemTextColor">@color/mtrl_bottom_nav_item_tint</item>
4038
</style>
4139

4240
<!-- Colored style for Bottom NavigationViews.
@@ -45,24 +43,9 @@
4543
<style name="Widget.MaterialComponents.BottomNavigationView.Colored">
4644
<item name="android:background">?attr/colorPrimary</item>
4745
<item name="itemIconTint">@color/mtrl_bottom_nav_colored_item_tint</item>
48-
<item name="itemTextAppearanceInactive">
49-
@style/TextAppearance.MaterialComponents.BottomNavigationView.Colored
50-
</item>
51-
<item name="itemTextAppearanceActive">
52-
@style/TextAppearance.MaterialComponents.BottomNavigationView.Colored.Active
53-
</item>
54-
</style>
55-
56-
<style name="TextAppearance.MaterialComponents.BottomNavigationView" parent="TextAppearance.AppCompat.Caption">
57-
<item name="android:textColor">@color/mtrl_bottom_nav_item_tint</item>
46+
<item name="itemTextAppearanceInactive">?attr/textAppearanceCaption</item>
47+
<item name="itemTextAppearanceActive">?attr/textAppearanceCaption</item>
48+
<item name="itemTextColor">@color/mtrl_bottom_nav_colored_item_tint</item>
5849
</style>
5950

60-
<style name="TextAppearance.MaterialComponents.BottomNavigationView.Active"/>
61-
62-
<style name="TextAppearance.MaterialComponents.BottomNavigationView.Colored">
63-
<item name="android:textColor">@color/mtrl_bottom_nav_colored_item_tint</item>
64-
</style>
65-
66-
<style name="TextAppearance.MaterialComponents.BottomNavigationView.Colored.Active"/>
67-
6851
</resources>

0 commit comments

Comments
 (0)