Skip to content

Commit c3d6042

Browse files
dsn5ftgsajith
authored andcommitted
Remove default Theme Switcher color options in favor of Reset option (helps for dark theme)
PiperOrigin-RevId: 219160833
1 parent 3637c23 commit c3d6042

File tree

5 files changed

+21
-22
lines changed

5 files changed

+21
-22
lines changed

catalog/java/io/material/catalog/themeswitcher/ThemeSwitcherDialogFragment.java

Lines changed: 20 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -64,11 +64,17 @@ public Dialog onCreateDialog(Bundle bundle) {
6464
.setView(onCreateDialogView(getActivity().getLayoutInflater()))
6565
.setPositiveButton(
6666
R.string.mtrl_theme_switcher_save,
67-
(dialog, id) -> {
67+
(dialog, which) -> {
6868
dialog.dismiss();
6969
applyThemeOverlays();
7070
})
71-
.setNegativeButton(R.string.mtrl_theme_switcher_cancel, null);
71+
.setNegativeButton(R.string.mtrl_theme_switcher_cancel, null)
72+
.setNeutralButton(
73+
R.string.mtrl_theme_switcher_reset,
74+
(dialog, which) -> {
75+
dialog.dismiss();
76+
ThemeOverlayUtils.setThemeOverlays(getActivity(), 0, 0);
77+
});
7278
return builder.create();
7379
}
7480

@@ -97,13 +103,18 @@ private View onCreateDialogView(LayoutInflater layoutInflater) {
97103
}
98104

99105
private void applyThemeOverlays() {
100-
ColorPalette primaryPalette =
101-
(ColorPalette) getDialog().findViewById(primaryGroup.getCheckedRadioButtonId()).getTag();
102-
ColorPalette secondaryPalette =
103-
(ColorPalette) getDialog().findViewById(secondaryGroup.getCheckedRadioButtonId()).getTag();
104-
105106
ThemeOverlayUtils.setThemeOverlays(
106-
getActivity(), primaryPalette.themeOverlay, secondaryPalette.themeOverlay);
107+
getActivity(), getThemeOverlayResId(primaryGroup), getThemeOverlayResId(secondaryGroup));
108+
}
109+
110+
private int getThemeOverlayResId(RadioGroup radioGroup) {
111+
if (radioGroup.getCheckedRadioButtonId() == View.NO_ID) {
112+
return 0;
113+
} else {
114+
ColorPalette colorPalette =
115+
(ColorPalette) getDialog().findViewById(radioGroup.getCheckedRadioButtonId()).getTag();
116+
return colorPalette.themeOverlay;
117+
}
107118
}
108119

109120
private void initializeColors(
@@ -131,7 +142,7 @@ private void initializeColors(
131142

132143
group.addView(button);
133144

134-
if (palette.themeOverlay == currentThemeOverlay || (i == 0 && currentThemeOverlay == 0)) {
145+
if (palette.themeOverlay == currentThemeOverlay) {
135146
group.check(button.getId());
136147
}
137148
}

catalog/java/io/material/catalog/themeswitcher/res/values/arrays.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
<resources>
1818

1919
<array name="mtrl_primary_palettes">
20-
<item>@style/ThemeOverlay.PrimaryPalette.Default</item>
2120
<item>@style/ThemeOverlay.PrimaryPalette.Red</item>
2221
<item>@style/ThemeOverlay.PrimaryPalette.Purple</item>
2322
<item>@style/ThemeOverlay.PrimaryPalette.Indigo</item>
@@ -31,7 +30,6 @@
3130
</array>
3231

3332
<array name="mtrl_secondary_palettes">
34-
<item>@style/ThemeOverlay.SecondaryPalette.Default</item>
3533
<item>@style/ThemeOverlay.SecondaryPalette.Red</item>
3634
<item>@style/ThemeOverlay.SecondaryPalette.Purple</item>
3735
<item>@style/ThemeOverlay.SecondaryPalette.Indigo</item>
@@ -45,7 +43,6 @@
4543
</array>
4644

4745
<array name="mtrl_palettes_content_description">
48-
<item>@string/mtrl_default_color</item>
4946
<item>@string/mtrl_red</item>
5047
<item>@string/mtrl_purple</item>
5148
<item>@string/mtrl_indigo</item>

catalog/java/io/material/catalog/themeswitcher/res/values/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
<string name="mtrl_theme_switcher_title">Theme Switcher</string>
2020
<string name="mtrl_theme_switcher_save">Save</string>
2121
<string name="mtrl_theme_switcher_cancel">Cancel</string>
22+
<string name="mtrl_theme_switcher_reset">Reset</string>
2223

23-
<string name="mtrl_default_color">Default color</string>
2424
<string name="mtrl_red">Red</string>
2525
<string name="mtrl_purple">Purple</string>
2626
<string name="mtrl_indigo">Indigo</string>

catalog/java/io/material/catalog/themeswitcher/res/values/themes_overlays_primary.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,6 @@
1616
-->
1717
<resources>
1818

19-
<style name="ThemeOverlay.PrimaryPalette.Default" parent="">
20-
<item name="colorPrimary">@color/cat_color_primary</item>
21-
<item name="colorPrimaryDark">@color/cat_color_primary_dark</item>
22-
</style>
23-
2419
<style name="ThemeOverlay.PrimaryPalette.Red" parent="">
2520
<item name="colorPrimary">#e53935</item>
2621
<item name="colorPrimaryDark">#ab000d</item>

catalog/java/io/material/catalog/themeswitcher/res/values/themes_overlays_secondary.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@
1616
-->
1717
<resources>
1818

19-
<style name="ThemeOverlay.SecondaryPalette.Default" parent="">
20-
<item name="colorSecondary">@color/cat_color_secondary</item>
21-
</style>
22-
2319
<style name="ThemeOverlay.SecondaryPalette.Red" parent="">
2420
<item name="colorSecondary">#e53935</item>
2521
</style>

0 commit comments

Comments
 (0)