Merge pull request jxmorris12#135 from mdevolde/ruff

feat (ruff): added some rules to ruff (N, S, BLE), corrected S and N warns

Author: mdevolde

language_tool_python/download_lt.py

@@ -101,7 +101,7 @@ def confirm_java_compatibility(
 
     logger.debug("Found java executable at %s", java_path)
 
-    output = subprocess.check_output(
+    output = subprocess.check_output(  # noqa: S603  # java_path come from shutil.which -> trusted
         [java_path, "-version"],
         stderr=subprocess.STDOUT,
         universal_newlines=True,
@@ -170,10 +170,15 @@ def http_get(
     :type out_file: IO[bytes]
     :param proxies: Optional dictionary of proxies to use for the request.
     :type proxies: Optional[Dict[str, str]]
+    :raises TimeoutError: If the request times out.
     :raises PathError: If the file could not be found at the given URL (HTTP 404).
     """
     logger.info("Starting download from %s", url)
-    req = requests.get(url, stream=True, proxies=proxies)
+    try:
+        req = requests.get(url, stream=True, proxies=proxies, timeout=60)
+    except requests.exceptions.Timeout as e:
+        err = f"Request to {url} timed out."
+        raise TimeoutError(err) from e
     content_length = req.headers.get("Content-Length")
     total = int(content_length) if content_length is not None else None
     if req.status_code == 404:

language_tool_python/server.py

@@ -628,7 +628,7 @@ def _start_local_server(self) -> None:
             )
             raise PathError(err) from e
         else:
-            self._server = subprocess.Popen(
+            self._server = subprocess.Popen(  # noqa: S603  # server_cmd is constructed internally -> trusted
                 server_cmd,
                 stdin=subprocess.PIPE,
                 stdout=subprocess.DEVNULL,

pyproject.toml

@@ -74,7 +74,10 @@ packages = { find = { include = ["language_tool_python*"] } }
 language_tool_python = ["py.typed", "logging.toml"]
 
 [tool.ruff.lint]
-select = ["F", "W", "I", "B", "SIM", "RET", "Q"]
+select = ["F", "W", "I", "B", "SIM", "RET", "Q", "N", "S", "BLE"]
+
+[tool.ruff.lint.per-file-ignores]
+"tests/*.py" = ["S101"]
 
 [tool.mypy]
 files = ["language_tool_python"]

tests/test_major_functionality.py

@@ -370,8 +370,8 @@ def test_session_only_new_spellings():
 def test_disabled_rule_in_config():
     import language_tool_python
 
-    GRAMMAR_TOOL_CONFIG = {"disabledRuleIds": ["MORFOLOGIK_RULE_EN_US"]}
-    with language_tool_python.LanguageTool("en-US", config=GRAMMAR_TOOL_CONFIG) as tool:
+    grammar_tool_config = {"disabledRuleIds": ["MORFOLOGIK_RULE_EN_US"]}
+    with language_tool_python.LanguageTool("en-US", config=grammar_tool_config) as tool:
         text = "He realised that the organization was in jeopardy."
         matches = tool.check(text)
         assert len(matches) == 0