Skip to content

Commit 2df3d20

Browse files
committed
fix: wait for process terminaison to avoid zombies
1 parent 73a697d commit 2df3d20

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

language_tool_python/server.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,12 @@ def _kill_processes(processes: List[subprocess.Popen[str]]) -> None:
5555
:param processes: A list of subprocess.Popen objects representing the running server processes.
5656
:type processes: List[subprocess.Popen]
5757
"""
58-
for pid in [p.pid for p in processes]:
58+
for p in processes:
5959
with contextlib.suppress(psutil.NoSuchProcess):
60-
kill_process_force(pid=pid)
60+
kill_process_force(pid=p.pid)
61+
# Wait to avoid zombies
62+
with contextlib.suppress(subprocess.TimeoutExpired):
63+
p.wait(timeout=5)
6164

6265

6366
class LanguageTool:

0 commit comments

Comments
 (0)