fix: Resolve an incompatibility of the _unregister_spellings function with windows, resolve an incomatibilty of a test with windows

Author: mdevolde

language_tool_python/server.py

@@ -78,7 +78,7 @@ def __init__(
                 language = FAILSAFE_LANGUAGE
         if newSpellings:
             self._new_spellings = newSpellings
-            self._register_spellings(self._new_spellings)
+            self._register_spellings()
         self._language = LanguageTag(language, self._get_languages())
         self.motherTongue = motherTongue
         self.disabled_rules = set()
@@ -191,33 +191,36 @@ def _get_valid_spelling_file_path() -> str:
                 .format(spelling_file_path))
         return spelling_file_path
 
-    def _register_spellings(self, spellings):
+    def _register_spellings(self):
         spelling_file_path = self._get_valid_spelling_file_path()
-        with (
-            open(spelling_file_path, "a+", encoding='utf-8')
-        ) as spellings_file:
-            spellings_file.write(
-                "\n" + "\n".join([word for word in spellings])
-            )
+        with open(spelling_file_path, "r+", encoding='utf-8') as spellings_file:
+            existing_spellings = set(line.strip() for line in spellings_file.readlines())
+            new_spellings = [word for word in self._new_spellings if word not in existing_spellings]
+            self._new_spellings = new_spellings
+            if new_spellings:
+                if len(existing_spellings) > 0:
+                    spellings_file.write("\n")
+                spellings_file.write("\n".join(new_spellings))
         if DEBUG_MODE:
             print("Registered new spellings at {}".format(spelling_file_path))
 
     def _unregister_spellings(self):
         spelling_file_path = self._get_valid_spelling_file_path()
-        with (
-            open(spelling_file_path, 'r+', encoding='utf-8')
-        ) as spellings_file:
-            spellings_file.seek(0, os.SEEK_END)
-            for _ in range(len(self._new_spellings)):
-                while spellings_file.read(1) != '\n':
-                    spellings_file.seek(spellings_file.tell() - 2, os.SEEK_SET)
-                spellings_file.seek(spellings_file.tell() - 2, os.SEEK_SET)
-            spellings_file.seek(spellings_file.tell() + 1, os.SEEK_SET)
-            spellings_file.truncate()
+
+        with open(spelling_file_path, 'r', encoding='utf-8') as spellings_file:
+            lines = spellings_file.readlines()
+
+        updated_lines = [
+            line for line in lines if line.strip() not in self._new_spellings
+        ]
+        if updated_lines and updated_lines[-1].endswith('\n'):
+           updated_lines[-1] = updated_lines[-1].strip()
+
+        with open(spelling_file_path, 'w', encoding='utf-8', newline='\n') as spellings_file:
+            spellings_file.writelines(updated_lines)
+
         if DEBUG_MODE:
-            print(
-                "Unregistered new spellings at {}".format(spelling_file_path)
-            )
+            print(f"Unregistered new spellings at {spelling_file_path}")
 
     def _get_languages(self) -> set:
         """Get supported languages (by querying the server)."""

tests/test_major_functionality.py

@@ -95,7 +95,7 @@ def test_process_starts_and_stops_on_close():
 
 def test_local_client_server_connection():
     import language_tool_python
-    tool1 = language_tool_python.LanguageTool('en-US', host='0.0.0.0')
+    tool1 = language_tool_python.LanguageTool('en-US', host='127.0.0.1')
     url = 'http://{}:{}/'.format(tool1._host, tool1._port)
     tool2 = language_tool_python.LanguageTool('en-US', remote_server=url)
     assert len(tool2.check('helo darknes my old frend'))