Skip to content

Commit e7a653d

Browse files
authored
Dev (#10)
* cleanup files * add jupyterlab as dev dependency * remove pre-commit from CI as it's enabled at pre-commit.ci
1 parent d7ee3f4 commit e7a653d

File tree

5 files changed

+12
-36
lines changed

5 files changed

+12
-36
lines changed

.github/workflows/ci.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ env:
1818
FORCE_COLOR: 3
1919

2020
jobs:
21-
pre-commit:
22-
name: Format
21+
lint:
22+
name: Pylint
2323
runs-on: ubuntu-latest
2424
steps:
2525
- uses: actions/checkout@v4
@@ -28,19 +28,19 @@ jobs:
2828
- uses: actions/setup-python@v5
2929
with:
3030
python-version: "3.x"
31-
3231
- uses: astral-sh/setup-uv@v6
3332

34-
- uses: pre-commit/action@v3.0.1
35-
with:
36-
extra_args: --hook-stage manual --all-files
33+
# comment out the below 3 lines if your set up pre-commit in pre-commit.ci
34+
# - uses: pre-commit/action@v3.0.1
35+
# with:
36+
# extra_args: --hook-stage manual --all-files
37+
3738
- name: Run Pylint
3839
run: uvx nox -s pylint -- --output-format=github
3940

4041
checks:
4142
name: Check Python ${{ matrix.python-version }} on ${{ matrix.runs-on }}
4243
runs-on: ${{ matrix.runs-on }}
43-
needs: [pre-commit]
4444
strategy:
4545
fail-fast: false
4646
matrix:
@@ -66,7 +66,7 @@ jobs:
6666
- name: Install package
6767
run: uv sync
6868

69-
- name: Test package
69+
- name: Run the tests
7070
run: >-
7171
uv run pytest -ra --cov --cov-report=xml --cov-report=term
7272
--durations=20

CONTRIBUTING.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ download and install anything:
9494
* We'll review your changes and then merge them in if everything is OK.
9595
* Done 🎉🍺
9696

97-
Alternatively, you can make the changes offline to the files in the `doc` folder or the
97+
Alternatively, you can make the changes offline to the files in the `docs` folder or the
9898
example scripts. See [Contributing Code](#contributing-code) for instructions.
9999

100100
## Contributing Code
@@ -159,7 +159,7 @@ Now we need to configure Git to sync this fork to the main repository, not your
159159
`cd` into the directory you just cloned and run:
160160

161161
```bash
162-
git remote add upstream https://github.com/organizationname/samplepackagenamee.git
162+
git remote add upstream https://github.com/organizationname/samplepackagename.git
163163
```
164164

165165
### Setting up `nox`
@@ -387,10 +387,8 @@ PyPI release are made automatically via GitHub actions whenever a pull request i
387387
### Conda-Forge
388388
Once the new version is on PyPI, within a few hours a bot will automatically open a new PR in the [samplepackagename conda-forge feedstock](https://github.com/conda-forge/samplepackagename-feedstock). Go through the checklist on the PR. Most of the time the only actions needs are updated any changes made to the dependencies since the last release. Merge the PR and the new version will be available on conda-forge shortly.
389389

390-
Once the new version is on conda, update the binder .yml file, as below.
391-
392390
## Update the dependencies
393391

394392
To add or update a dependencies, add it to `pyproject.toml` either under `dependencies` or `optional-dependencies`. This will be included in the next build uploaded to PyPI.
395393

396-
If you add a dependency necessary for using the package, make sure to add it to the Binder config file and update the `environment.yml` file in the repository. See below.
394+
If you add a dependency necessary for using the package, make sure to update the `environment.yml` file in the repository. See below.

docs/conf.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -101,19 +101,3 @@
101101
"source_branch": "main",
102102
"source_directory": "docs/",
103103
}
104-
105-
# html_theme = "sphinx_book_theme"
106-
# html_theme_options = {
107-
# "repository_url": "https://github.com/organizationname/samplepackagename",
108-
# "repository_branch": "main",
109-
# "path_to_docs": "docs",
110-
# "launch_buttons": {
111-
# "binderhub_url": "https://mybinder.org",
112-
# "notebook_interface": "jupyterlab",
113-
# },
114-
# "use_edit_page_button": True,
115-
# "use_issues_button": True,
116-
# "use_repository_button": True,
117-
# "use_download_button": True,
118-
# "home_page_in_toc": False,
119-
# }

docs/install.md

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,5 @@
11
# Install
22

3-
## Online usage (Binder)
4-
5-
See below for the full installation instructions.
6-
If instead you'd like to use this package online, without needing to install anything, check out our [Binder link](https://mybinder.org/v2/gh/organizationname/samplepackagename/main), which gives full access the the package in an online environment.
7-
8-
This Binder environment can also be accessed by clicking the Binder icon in any of the `gallery` or `tutorial` examples.
9-
103
## Install Python
114

125
Before installing _samplepackagename_, ensure you have Python 3.9 or greater downloaded.

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ test = [
4040
]
4141
dev = [
4242
{ include-group = "test" },
43+
"jupyterlab",
4344
]
4445
docs = [
4546
"sphinx>=7.0",

0 commit comments

Comments
 (0)