improve prediction for fast action

Author: arch

funscript_editor/algorithms/signal.py

@@ -12,6 +12,7 @@
 
 @dataclass
 class SignalParameter:
+    local_min_max_filter_len: int = int(HYPERPARAMETER['signal']['local_max_min_filter_len'])
     avg_sec_for_local_min_max_extraction: float = float(HYPERPARAMETER['signal']['avg_sec_for_local_min_max_extraction'])
     additional_points_merge_time_threshold_in_ms: float = float(HYPERPARAMETER['signal']['additional_points_merge_time_threshold_in_ms'])
     additional_points_merge_distance_threshold: float = float(HYPERPARAMETER['signal']['additional_points_merge_distance_threshold'])
@@ -296,7 +297,7 @@ def get_edge_points(self, signal: list, base_points: list, threshold: float = 25
 
 
 
-    def get_local_min_max_points(self, signal: list, filter_len: int = 3) -> list:
+    def get_local_min_max_points(self, signal: list, filter_len: int = 1) -> list:
         """ Get the local max and min positions in given signal
 
         Args:
@@ -306,6 +307,10 @@ def get_local_min_max_points(self, signal: list, filter_len: int = 3) -> list:
         Returns:
             list:  with local max and min indexes
         """
+        filter_len = max((1, filter_len))
+        if filter_len % 2 == 0:
+            filter_len += 1
+
         avg = Signal.moving_average(signal, w=round(self.fps * self.params.avg_sec_for_local_min_max_extraction))
         smothed_signal = Signal.moving_average(signal, w=filter_len)
         points, tmp_min_start_idx, tmp_min_end_idx, tmp_max_start_idx, tmp_max_end_idx = [], -1, -1, -1, -1
@@ -532,7 +537,7 @@ def decimate(self,
         if base_point_algorithm == self.BasePointAlgorithm.direction_changes:
             decimated_indexes = self.get_direction_changes(signal, filter_len = self.params.direction_change_filter_len)
         elif base_point_algorithm == self.BasePointAlgorithm.local_min_max:
-            decimated_indexes = self.get_local_min_max_points(signal)
+            decimated_indexes = self.get_local_min_max_points(signal, filter_len = self.params.local_min_max_filter_len)
         else:
             raise NotImplementedError("Selected Base Point Algorithm is not implemented")
 

funscript_editor/config/hyperparameter.yaml

@@ -14,6 +14,11 @@ user_reaction_time_in_milliseconds: 1000
 
 # Signal Processing Hyperparameter
 signal:
+
+  # Specify the window size for the calculation of smothed tracking signal for the local min and max search.
+  # For slow actions in you video i recommend to set this to '3' to reduce the false positive predictions.
+  local_max_min_filter_len: 1
+
   # Specify the window size for the calculation of the reference value for the local min and max search.
   avg_sec_for_local_min_max_extraction: 2.0