fix exception source by removing playsound for now

Author: arch

funscript_editor/algorithms/funscriptgenerator.py

@@ -296,8 +296,8 @@ def min_max_selector(self,
         cv2.putText(image, "Use 'space' to quit and set the trackbar values",
             (self.x_text_start, 100), cv2.FONT_HERSHEY_SIMPLEX, self.font_size, (255,0,0), 2)
 
-        beep_thread = threading.Thread(target=self.beep)
-        beep_thread.start()
+        # beep_thread = threading.Thread(target=self.beep)
+        # beep_thread.start()
         self.clear_keypress_queue()
         trackbarValueMin = lower_limit
         trackbarValueMax = upper_limit
@@ -320,11 +320,13 @@ def min_max_selector(self,
 
     def beep(self) -> None:
         """ Play an sound to signal an event """
-        if NOTIFICATION_SOUND_FILE is not None:
-            if os.path.exists(NOTIFICATION_SOUND_FILE):
-                playsound(NOTIFICATION_SOUND_FILE)
-            else:
-                self.logger.warning("Notification sound file not found (%s)", NOTIFICATION_SOUND_FILE)
+        if False:
+            # we have problems on windows with this
+            if NOTIFICATION_SOUND_FILE is not None:
+                if os.path.exists(NOTIFICATION_SOUND_FILE):
+                    playsound(NOTIFICATION_SOUND_FILE)
+                else:
+                    self.logger.warning("Notification sound file not found (%s)", NOTIFICATION_SOUND_FILE)
 
 
     def calculate_score(self, bboxes) -> None:
@@ -858,8 +860,8 @@ def tracking(self) -> str:
 
                 scene_change_quit_flag = False
                 if scene_detector.is_scene_change(frame_num-1 + self.params.start_frame):
-                    beep_thread = threading.Thread(target=self.beep)
-                    beep_thread.start()
+                    # beep_thread = threading.Thread(target=self.beep)
+                    # beep_thread.start()
                     cv2.putText(last_frame, "Scene change detected, Press 'space' to continue tracking or press 'q' to finalize tracking",
                             (self.x_text_start, 75), cv2.FONT_HERSHEY_SIMPLEX, self.font_size, (255,0,0), 2)
                     cv2.imshow(self.window_name, self.preview_scaling(last_frame))

funscript_editor/config/settings.yaml

@@ -18,7 +18,8 @@ preview_scaling: 0.6
 tracker: 'CSRT'
 
 # Specify the wav file to play when tracking finished (write 'off' to disable the sound notification)
-notification_sound: 'sound_notification.wav'
+# This feature was removed in v0.1.1 due to problems on windows
+notification_sound: 'off'
 
 # Time in milliseconds at which the tracking is stopped if the selected feature is not found
 tracking_lost_time: 0

funscript_editor/ui/funscript_generator_window.py

@@ -106,11 +106,13 @@ def __funscript_generated(self, funscript, msg, success) -> None:
 
             self.__logger.info("Save result to %s", self.output_file)
             if not success: self.__show_message(msg, error=True)
-            if platform.system() == "Windows":
-                # On windows i have problems to close the process
-                # Workaround we kill with taskkill
-                os.system('taskkill /f /im funscript-editor.exe')
-            os._exit(os.EX_OK)
+            if False:
+                if platform.system() == "Windows":
+                    # On windows i have problems to close the process
+                    # Workaround we kill with taskkill
+                    os.system('taskkill /f /im funscript-editor.exe')
+                os._exit(os.EX_OK)
+            sys.exit()
 
 
     def run(self) -> None: