fix logging

Author: arch

funscript_editor/api.py

@@ -6,13 +6,15 @@
 from funscript_editor.utils.logging import setup_logging
 from funscript_editor.ui.funscript_editor_window import FunscriptEditorWindow
 from funscript_editor.ui.minimal import MinimalFunscriptGenerator
+from funscript_editor.utils.config import VERSION
 
 from PyQt5 import QtCore, QtGui, QtWidgets
 
 
 def show_editor() -> None:
     """ Show the Funscript Editor Main Window """
     setup_logging()
+    logging.info("Python Funscript Editor %s", VERSION)
     app = QtWidgets.QApplication(sys.argv)
     widget = FunscriptEditorWindow()
     widget.show()
@@ -28,6 +30,7 @@ def generate_funscript(video_file: str, start_time: int, output_file: str) -> No
         output_file (str): path for the output file
     """
     setup_logging()
+    logging.info("Python Funscript Generator %s", VERSION)
     app = QtWidgets.QApplication(sys.argv)
     generator = MinimalFunscriptGenerator(video_file, start_time, output_file)
     generator.run()

funscript_editor/config/logging_linux.yaml

@@ -4,73 +4,24 @@ disable_existing_loggers: false
 formatters:
     standard:
         format: "%(asctime)s - %(name)s - %(levelname)s - %(message)s"
-    error:
-        format: "%(levelname)s <PID %(process)d:%(processName)s> %(name)s.%(funcName)s(): %(message)s"
 
 handlers:
     console:
         class: logging.StreamHandler
-        level: DEBUG
+        level: INFO
         formatter: standard
         stream: ext://sys.stdout
 
-    info_file_handler:
+    file_handler:
         class: logging.handlers.RotatingFileHandler
         level: INFO
         formatter: standard
-        filename: /tmp/funscript_editor/info.log
-        maxBytes: 10485760 # 10MB
-        backupCount: 10
-        encoding: utf8
-
-    error_file_handler:
-        class: logging.handlers.RotatingFileHandler
-        level: ERROR
-        formatter: error
-        filename: /tmp/funscript_editor/errors.log
-        maxBytes: 10485760 # 10MB
-        backupCount: 10
-        encoding: utf8
-
-    debug_file_handler:
-        class: logging.handlers.RotatingFileHandler
-        level: DEBUG
-        formatter: standard
-        filename: /tmp/funscript_editor/debug.log
-        maxBytes: 10485760 # 10MB
-        backupCount: 10
-        encoding: utf8
-
-    critical_file_handler:
-        class: logging.handlers.RotatingFileHandler
-        level: CRITICAL
-        formatter: standard
-        filename: /tmp/funscript_editor/critical.log
-        maxBytes: 10485760 # 10MB
-        backupCount: 10
-        encoding: utf8
-
-    warn_file_handler:
-        class: logging.handlers.RotatingFileHandler
-        level: WARN
-        formatter: standard
-        filename: /tmp/funscript_editor/warn.log
+        filename: /tmp/funscript_editor.log
         maxBytes: 10485760 # 10MB
         backupCount: 10
         encoding: utf8
 
 root:
     level: NOTSET
-    handlers: [console]
+    handlers: [console, file_handler]
     propogate: yes
-
-loggers:
-    <module>:
-        level: DEBUG
-        handlers: [console, info_file_handler, error_file_handler, critical_file_handler, debug_file_handler, warn_file_handler]
-        propogate: no
-
-    <module.x>:
-        level: DEBUG
-        handlers: [info_file_handler, error_file_handler, critical_file_handler, debug_file_handler, warn_file_handler]
-        propogate: yes

funscript_editor/config/logging_windows.yaml

@@ -4,73 +4,24 @@ disable_existing_loggers: false
 formatters:
     standard:
         format: "%(asctime)s - %(name)s - %(levelname)s - %(message)s"
-    error:
-        format: "%(levelname)s <PID %(process)d:%(processName)s> %(name)s.%(funcName)s(): %(message)s"
 
 handlers:
     console:
         class: logging.StreamHandler
-        level: DEBUG
+        level: INFO
         formatter: standard
         stream: ext://sys.stdout
 
-    info_file_handler:
+    file_handler:
         class: logging.handlers.RotatingFileHandler
         level: INFO
         formatter: standard
-        filename: logs\\info.log
-        maxBytes: 10485760 # 10MB
-        backupCount: 20
-        encoding: utf8
-
-    error_file_handler:
-        class: logging.handlers.RotatingFileHandler
-        level: ERROR
-        formatter: error
-        filename: logs\\errors.log
-        maxBytes: 10485760 # 10MB
-        backupCount: 20
-        encoding: utf8
-
-    debug_file_handler:
-        class: logging.handlers.RotatingFileHandler
-        level: DEBUG
-        formatter: standard
-        filename: logs\\debug.log
-        maxBytes: 10485760 # 10MB
-        backupCount: 20
-        encoding: utf8
-
-    critical_file_handler:
-        class: logging.handlers.RotatingFileHandler
-        level: CRITICAL
-        formatter: standard
-        filename: logs\\critical.log
+        filename: logs/funscript_editor.log
         maxBytes: 10485760 # 10MB
-        backupCount: 20
-        encoding: utf8
-
-    warn_file_handler:
-        class: logging.handlers.RotatingFileHandler
-        level: WARN
-        formatter: standard
-        filename: logs\\warn.log
-        maxBytes: 10485760 # 10MB
-        backupCount: 20
+        backupCount: 10
         encoding: utf8
 
 root:
     level: NOTSET
-    handlers: [console]
+    handlers: [console, file_handler]
     propogate: yes
-
-loggers:
-    <module>:
-        level: DEBUG
-        handlers: [console, info_file_handler, error_file_handler, critical_file_handler, debug_file_handler, warn_file_handler]
-        propogate: no
-
-    <module.x>:
-        level: DEBUG
-        handlers: [info_file_handler, error_file_handler, critical_file_handler, debug_file_handler, warn_file_handler]
-        propogate: yes

funscript_editor/utils/logging.py

@@ -27,7 +27,7 @@ def setup_logging(
     """ Logging Setup
 
     Args:
-        default_level (int): logging level from logging python module e.g. `logging.INFO` (default is `logging.INFO`).
+        default_level (int): logging level e.g. `logging.INFO` (default is `logging.DEBUG`).
         env_key (str, optional): env variable name to load a configuration file via environment variable (default is `LOG_CFG`).
     """
     config_path = WINDOWS_LOG_CONFIG_FILE if platform.system() == 'Windows' else LINUX_LOG_CONFIG_FILE
@@ -39,7 +39,8 @@ def setup_logging(
                 config = yaml.safe_load(f.read())
                 create_log_directories(config)
                 logging.config.dictConfig(config)
-                coloredlogs.install()
+                coloredlogs.install(level=default_level)
+                logging.debug('Loging setup completed')
             except Exception as e:
                 print(e)
                 print('Error in Logging Configuration. Using default configs')