Skip to content

Commit 66c5c9a

Browse files
authored
Fix external transport example (#39)
* Initial * Revert "Add external transport example (#37)" This reverts commit ca78714. * Fix * Update
1 parent 8d51350 commit 66c5c9a

File tree

6 files changed

+13
-30
lines changed

6 files changed

+13
-30
lines changed

rclc/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ export_executable(timer)
5252
export_executable(string_publisher)
5353
export_executable(string_subscriber)
5454
export_executable(autodiscover_agent)
55-
export_executable(configuration_example custom_transports)
55+
# export_executable(configuration_example custom_transports)
5656

5757
if(EXISTS ${CMAKE_BINARY_DIR}/temp_install/)
5858
install(

rclc/configuration_example/configured_publisher/CMakeLists.txt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,14 @@ find_package(rcl REQUIRED)
77
find_package(rclc REQUIRED)
88
find_package(std_msgs REQUIRED)
99
find_package(rmw_microxrcedds REQUIRED)
10-
find_package(microxrcedds_client REQUIRED)
1110

1211
add_executable(${PROJECT_NAME} main.c)
1312

14-
target_link_libraries(${PROJECT_NAME}
15-
microxrcedds_client
16-
)
17-
1813
ament_target_dependencies(${PROJECT_NAME}
1914
rcl
2015
rclc
2116
std_msgs
2217
rmw_microxrcedds
23-
microxrcedds_client
2418
)
2519

2620
install(TARGETS ${PROJECT_NAME}

rclc/configuration_example/configured_publisher/main.c

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -43,18 +43,16 @@ int main(int argc, char * const argv[])
4343
RCCHECK(rmw_uros_options_set_udp_address(argv[1], argv[2], rmw_options))
4444
RCCHECK(rmw_uros_options_set_client_key(0xCAFEBABA, rmw_options))
4545

46-
size_t domain_id = (size_t)(argc == 4 ? atoi(argv[3]) : 0);
47-
const char * node_name = "int32_configured_publisher_rclc";
48-
49-
rcl_init_options_set_domain_id(&init_options, domain_id);
50-
printf("Initializing RCL '%s' with ROS Domain ID %ld...\n", node_name, domain_id);
51-
5246
// create init_options
5347
RCCHECK(rclc_support_init_with_options(&support, 0, NULL, &init_options, &allocator));
5448

5549
// create node
5650
rcl_node_t node = rcl_get_zero_initialized_node();
57-
RCCHECK(rclc_node_init_default(&node, node_name, "", &support));
51+
rcl_node_options_t node_ops = rcl_node_get_default_options();
52+
node_ops.domain_id = (size_t)(argc == 4 ? atoi(argv[3]) : 0);
53+
const char * node_name = "int32_configured_publisher_rclc";
54+
printf("Initializing node '%s' with ROS Domain ID %ld...\n",node_name, node_ops.domain_id);
55+
RCCHECK(rclc_node_init_with_options(&node, node_name, "", &support, &node_ops));
5856

5957
// create publisher
6058
RCCHECK(rclc_publisher_init_default(

rclc/configuration_example/configured_subscriber/CMakeLists.txt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,14 @@ find_package(rcl REQUIRED)
77
find_package(rclc REQUIRED)
88
find_package(std_msgs REQUIRED)
99
find_package(rmw_microxrcedds REQUIRED)
10-
find_package(microxrcedds_client REQUIRED)
1110

1211
add_executable(${PROJECT_NAME} main.c)
1312

14-
target_link_libraries(${PROJECT_NAME}
15-
microxrcedds_client
16-
)
17-
1813
ament_target_dependencies(${PROJECT_NAME}
1914
rcl
2015
rclc
2116
std_msgs
2217
rmw_microxrcedds
23-
microxrcedds_client
2418
)
2519

2620
install(TARGETS ${PROJECT_NAME}

rclc/configuration_example/configured_subscriber/main.c

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,18 +39,16 @@ int main(int argc, const char * const * argv)
3939
RCCHECK(rmw_uros_options_set_udp_address(argv[1], argv[2], rmw_options))
4040
RCCHECK(rmw_uros_options_set_client_key(0xCAFEBABE, rmw_options))
4141

42-
size_t domain_id = (size_t)(argc == 4 ? atoi(argv[3]) : 0);
43-
const char * node_name = "int32_configured_subscriber_rclc";
44-
45-
rcl_init_options_set_domain_id(&init_options, domain_id);
46-
printf("Initializing RCL '%s' with ROS Domain ID %ld...\n", node_name, domain_id);
47-
4842
// create init_options
4943
RCCHECK(rclc_support_init_with_options(&support, 0, NULL, &init_options, &allocator));
5044

5145
// create node
5246
rcl_node_t node = rcl_get_zero_initialized_node();
53-
RCCHECK(rclc_node_init_default(&node, node_name, "", &support));
47+
rcl_node_options_t node_ops = rcl_node_get_default_options();
48+
node_ops.domain_id = (size_t)(argc == 4 ? atoi(argv[3]) : 0);
49+
const char * node_name = "int32_configured_subscriber_rclc";
50+
printf("Initializing node '%s' with ROS Domain ID %ld...\n", node_name, node_ops.domain_id);
51+
RCCHECK(rclc_node_init_with_options(&node, node_name, "", &support, &node_ops));
5452

5553
// create subscriber
5654
RCCHECK(rclc_subscription_init_default(

rclc/configuration_example/custom_transports/main.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -135,14 +135,13 @@ int main(int argc, char * const argv[])
135135

136136
custom_transport_data_t custom_transport_data;
137137

138-
RCCHECK(rmw_uros_options_set_custom_transport(
138+
RCCHECK(rmw_uros_set_custom_transport(
139139
false,
140140
(void*) &custom_transport_data,
141141
custom_transport_open,
142142
custom_transport_close,
143143
custom_transport_write,
144-
custom_transport_read,
145-
rmw_options
144+
custom_transport_read
146145
))
147146

148147
// create init_options

0 commit comments

Comments
 (0)