Adding JWK client initialization code to cache keys#158
Closed
rodrigobr-msft wants to merge 2 commits intomainfrom
Closed
Adding JWK client initialization code to cache keys#158rodrigobr-msft wants to merge 2 commits intomainfrom
rodrigobr-msft wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the way JWKS (JSON Web Key Set) clients are managed in the
JwtTokenValidatorclass to improve efficiency and error handling. Instead of creating a new JWKS client for every token validation, the code now initializes and caches clients for each issuer, reducing unnecessary network requests and improving performance.Key improvements to JWKS client management:
_default_jwks_clientand_tenant_jwks_clientto cache JWKS clients for the default and tenant-specific issuers, respectively._init_jwks_clientmethod to initialize the appropriate JWKS client only once per issuer, with key caching enabled._get_clientmethod to safely retrieve the correct JWKS client for a given issuer, raising an error if the client is not initialized._get_public_key_or_secretto use the cached clients and improved error handling for missing issuer claims.