Enhance type annotations in various modules for improved clarity and consistency#162
Merged
cleemullins merged 1 commit intomainfrom Oct 10, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances type annotations in various modules across the codebase by updating docstring type references to use full class paths and adding missing documentation for methods and parameters. The changes improve clarity and consistency in the documentation.
- Updated type annotations from simple class names to full class path references using the
:class:directive - Added comprehensive docstrings for previously undocumented methods and parameters
- Standardized documentation format across multiple modules
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| channel_service_adapter.py | Added docstrings for multiple methods and updated type references to use full class paths |
| state.py | Enhanced documentation with complete parameter and return type annotations |
| authorization.py | Updated type references and added missing docstrings for private methods |
| agent_application.py | Added docstrings for properties and methods with full type annotations |
| activity_handler.py | Fixed parameter names and updated type references to use full class paths |
| msal_connection_manager.py | Enhanced method documentation with complete type annotations |
| semantic_action.py | Corrected class name reference in type annotation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
libraries/microsoft-agents-activity/microsoft_agents/activity/semantic_action.py
Show resolved
Hide resolved
rodrigobr-msft
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More doc reference fixes