Trace file is left when the process crashed before stopping the profiling

[xiaomi7732]

Describe the bug
RT. Basically, when the process is terminated unexpectedly, the temp profiling file will be left there.

To Reproduce

1. Start profiler.
2. Kill the process in the middle.
3. Check the tracing file.

Expect
temp file be deleted.

Actual
The temp file is still there.

[xiaomi7732]

Since the process was killed, there's little we can do during the session. However, what we can do, is to clean the trace files up in the next session, should the process started again.

The feature is built into the new beta release, no user action is needed to leverage it:

https://www.nuget.org/packages/Microsoft.ApplicationInsights.Profiler.AspNetCore/2.6.0-beta2

At the same time, it is also possible to customize the behavior:

{
    "ServiceProfiler": {
        "TraceScavenger": {
            "InitialDelay": "00:00:00",    // Delay 0 seconds, no delay effectively.
            "Interval": "01:00:00",          // Run trace scavenger every 1 hour.
            "GracePeriod": "00:10:00"   // Do not delete the file if it was accessed within 10 minuts.
    }
}

[esbenbach]

Nice improvement, looking forward to it...

[xiaomi7732]

@esbenbach Thanks for the comment. Will you be able to try it with the beta version or will you have to wait for the stable release? We are running tests but it will greatly increase our confidence of the feature if we have your confirmation that it is working.

[esbenbach]

Not sure we are going to test it with the beta. Regardless we are not going to release before january some time. Ill look into using the beta package for that relase though. One thing im almost certain about is that this is only half a solution. There is still something causing the profiler to get stuck in the first place, generating huge files. But one thing at a time

…

On Wed, 6 Dec 2023, 19:51 Saar Shen, ***@***.***> wrote: @esbenbach <https://github.com/esbenbach> Will you be able to try it with the beta version or will you have to wait for the stable release? We are running tests but it will greatly increase our confidence of the feature if we have your confirmation that it is working. — Reply to this email directly, view it on GitHub <#204 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKQP7WNXDBJAV4NNLGCJXDYIC5EFAVCNFSM6AAAAAA74XQ2QSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBTGUYDINBWGU> . You are receiving this because you were mentioned.Message ID: <microsoft/ApplicationInsights-Profiler-AspNetCore/issues/204/1843504465@ github.com>

[xiaomi7732]

2.6.0 is released. Please check out the stable package:
https://www.nuget.org/packages/Microsoft.ApplicationInsights.Profiler.AspNetCore/2.6.0

[esbenbach]

@xiami7732 We finally had the time to run this in production a bit.

The file is now removed, but it is still generated in the first place. So the issue is NOT solved, as a crash needs to occur before the file is cleaned up (and stops growing).

Secondly, all subsequent profiler writes (different processes on the same VM), will fail with "not enough disk space", even AFTER the file is removed and there is enough disk space.