build(client): upgrade react eslint plugins (#26007)

Updates the ESLint React and React Hooks plugin dependencies to their
latest versions and enables several new React Hooks linting rules that
are available in these newer versions.

**ESLint plugin upgrades:**

- Upgraded `eslint-plugin-react` from `~7.33.2` to `~7.35.0` and
`eslint-plugin-react-hooks` from `~5.2.0` to `~7.0.1` in both
`package.json` and `pnpm-lock.yaml`. This enables compatibility with
ESLint 9 and unlocks new linting rules.

Several of the rules were downgraded to warning while we get through the
eslint 9 upgrade. They can be revisited once the upgrade is done.

Author: tylerbutler

common/build/eslint-config-fluid/CHANGELOG.md

@@ -17,7 +17,30 @@ Packages can now use `eslint.config.mjs` instead of `.eslintrc.cjs`, but the leg
 
 ### ESLint Rule Changes
 
-**react-hooks/rules-of-hooks**: Temporarily downgraded from `"error"` to `"warn"` until ESLint 9 migration completes and React plugins are upgraded to more recent versions.
+**React Hooks plugin upgraded**: Upgraded from `~5.2.0` to `~7.0.1`, enabling several new React Hooks linting rules.
+
+**New react-hooks rules enabled as `"error"`**:
+
+- `react-hooks/component-hook-factories`
+- `react-hooks/config`
+- `react-hooks/error-boundaries`
+- `react-hooks/gating`
+- `react-hooks/globals`
+- `react-hooks/preserve-manual-memoization`
+- `react-hooks/purity`
+- `react-hooks/set-state-in-render`
+- `react-hooks/use-memo`
+
+**React-hooks rules temporarily downgraded to `"warn"`** (until ESLint 9 migration completes):
+
+- `react-hooks/rules-of-hooks`: Changed from `"error"` to `"warn"`
+- `react-hooks/exhaustive-deps`: Changed from `"error"` to `"warn"`
+- `react-hooks/immutability`: New rule set to `"warn"`
+- `react-hooks/incompatible-library`: New rule set to `"warn"`
+- `react-hooks/refs`: New rule set to `"warn"`
+- `react-hooks/set-state-in-effect`: New rule set to `"warn"`
+- `react-hooks/static-components`: New rule set to `"warn"`
+- `react-hooks/unsupported-syntax`: New rule set to `"warn"`
 
 **New unicorn rules** (enabled as `"error"` by default):
 

common/build/eslint-config-fluid/minimal-deprecated.js

@@ -422,9 +422,13 @@ module.exports = {
 			],
 			extends: ["plugin:react/recommended", "plugin:react-hooks/recommended"],
 			rules: {
-				// TODO: This should be re-enabled once we are on eslint 9
+				// TODO: These rules should be re-enabled once we are on eslint 9
 				// and the react plugins are upgraded to more recent versions
+				"react-hooks/immutability": "warn",
+				"react-hooks/refs": "warn",
 				"react-hooks/rules-of-hooks": "warn",
+				"react-hooks/set-state-in-effect": "warn",
+				"react-hooks/static-components": "warn",
 			},
 			settings: {
 				react: {

common/build/eslint-config-fluid/package.json

@@ -38,8 +38,8 @@
 		"eslint-plugin-import-x": "~4.16.1",
 		"eslint-plugin-jsdoc": "~61.4.1",
 		"eslint-plugin-promise": "~7.2.1",
-		"eslint-plugin-react": "~7.33.2",
-		"eslint-plugin-react-hooks": "~5.2.0",
+		"eslint-plugin-react": "~7.35.0",
+		"eslint-plugin-react-hooks": "~7.0.1",
 		"eslint-plugin-tsdoc": "~0.5.0",
 		"eslint-plugin-unicorn": "~54.0.0",
 		"eslint-plugin-unused-imports": "~4.3.0"