build(eslint-config-fluid): update @typescript-eslint to v8 (#25663)

Updates @typescript-eslint packages from v7 to v8 with necessary rule
migrations and configuration adjustments.

## Changes
- Update @typescript-eslint/eslint-plugin and @typescript-eslint/parser
to v8
- Migrate rule: `no-throw-literal` → `only-throw-error`
- Remove deprecated and deleted rules: `ban-types`,
`no-empty-interface`, and others
- I removed all typescript-eslint rules that are deleted or deprecated.
This resulted in some trivial changes to the config of some rules
(rulesets often keep the old, even deleted, rules around for awhile
"just in case" -- they just set them to "off" -- so we'll still see them
in the printed configs).
- Update codebase for new rule requirements (explicit returns, type
annotations)

## Test plan
- CI passes with updated ESLint configuration
- All lint errors resolved across codebase

Author: tylerbutler

azure/packages/azure-local-service/tsconfig.eslint.json

@@ -4,6 +4,7 @@
 	"extends": "../../../common/build/build-common/tsconfig.node16.json",
 	"include": ["index.js"],
 	"compilerOptions": {
+		"allowJs": true,
 		"noEmit": true,
 	},
 }

common/build/eslint-config-fluid/base.js

@@ -39,12 +39,6 @@ module.exports = {
 	plugins: ["import-x", "unicorn"],
 	reportUnusedDisableDirectives: true,
 	rules: {
-		// These rules were deprecated, then removed in `@typescript-eslint/eslint-plugin` v8.
-		// They are replaced by a set of more specific rules, which have been enabled in the list below.
-		// These explicit disable will need to be removed when this package is updated to v8+ of the plugin.
-		"@typescript-eslint/ban-types": "off",
-		"@typescript-eslint/no-empty-interface": "off",
-
 		// Please keep entries alphabetized within a group
 
 		// #region Fluid Custom Rules
@@ -72,9 +66,6 @@ module.exports = {
 		"@typescript-eslint/adjacent-overload-signatures": "error",
 		"@typescript-eslint/array-type": "error",
 		"@typescript-eslint/await-thenable": "error",
-		"@typescript-eslint/brace-style": "off",
-		"@typescript-eslint/comma-dangle": ["error", "always-multiline"],
-		"@typescript-eslint/comma-spacing": "off",
 		"@typescript-eslint/consistent-type-assertions": [
 			"error",
 			{
@@ -85,14 +76,10 @@ module.exports = {
 		"@typescript-eslint/consistent-type-definitions": "error",
 		"@typescript-eslint/dot-notation": "error",
 		"@typescript-eslint/explicit-function-return-type": "off",
-		"@typescript-eslint/func-call-spacing": "off",
-		"@typescript-eslint/keyword-spacing": "off",
-		"@typescript-eslint/member-delimiter-style": "off",
 		"@typescript-eslint/no-dynamic-delete": "error",
 		"@typescript-eslint/no-empty-function": "off",
 		"@typescript-eslint/no-empty-object-type": "error",
 		"@typescript-eslint/no-explicit-any": "off",
-		"@typescript-eslint/no-extra-semi": "error",
 		"@typescript-eslint/no-extraneous-class": "error",
 		"@typescript-eslint/no-floating-promises": "error",
 		"@typescript-eslint/no-for-in-array": "error",
@@ -110,45 +97,24 @@ module.exports = {
 			},
 		],
 		"@typescript-eslint/no-this-alias": "error",
-		"@typescript-eslint/no-throw-literal": "error",
 		"@typescript-eslint/no-unused-expressions": "error",
 		"@typescript-eslint/no-unused-vars": "off",
 		"@typescript-eslint/no-unnecessary-qualifier": "error",
 		"@typescript-eslint/no-unnecessary-type-arguments": "error",
 		"@typescript-eslint/no-unnecessary-type-assertion": "error",
 		"@typescript-eslint/no-unsafe-function-type": "error",
-		"@typescript-eslint/no-var-requires": "error",
-		"@typescript-eslint/object-curly-spacing": "off",
+		"@typescript-eslint/only-throw-error": "error",
 		"@typescript-eslint/prefer-for-of": "error",
 		"@typescript-eslint/prefer-function-type": "error",
 		"@typescript-eslint/prefer-namespace-keyword": "error",
 		"@typescript-eslint/prefer-readonly": "error",
 		"@typescript-eslint/promise-function-async": "error",
-		"@typescript-eslint/quotes": [
-			"error",
-			"double",
-			{
-				allowTemplateLiterals: true,
-				avoidEscape: true,
-			},
-		],
 		"@typescript-eslint/require-await": "off",
 		"@typescript-eslint/restrict-plus-operands": "error",
 		"@typescript-eslint/restrict-template-expressions": "off",
 		"@typescript-eslint/return-await": "error",
-		"@typescript-eslint/semi": ["error", "always"],
-		"@typescript-eslint/space-infix-ops": "error",
-		"@typescript-eslint/space-before-function-paren": [
-			"error",
-			{
-				anonymous: "never",
-				asyncArrow: "always",
-				named: "never",
-			},
-		],
 		"@typescript-eslint/strict-boolean-expressions": "error",
 		"@typescript-eslint/triple-slash-reference": "error",
-		"@typescript-eslint/type-annotation-spacing": "error",
 		"@typescript-eslint/unbound-method": [
 			"error",
 			{
@@ -361,7 +327,6 @@ module.exports = {
 			// Rules only for type validation files
 			files: ["**/types/*validate*Previous*.ts"],
 			rules: {
-				"@typescript-eslint/comma-spacing": "off",
 				"import-x/order": "off",
 			},
 		},

common/build/eslint-config-fluid/minimal-deprecated.js

@@ -232,10 +232,6 @@ module.exports = {
 		"@typescript-eslint/explicit-function-return-type": "off",
 		"@typescript-eslint/explicit-member-accessibility": "off",
 
-		/**
-		 * Disabled because we will lean on the formatter (i.e. prettier) to enforce indentation policy.
-		 */
-		"@typescript-eslint/indent": "off",
 		"@typescript-eslint/member-ordering": "off",
 		"@typescript-eslint/no-explicit-any": "off",
 		"@typescript-eslint/no-unused-vars": "off",
@@ -288,22 +284,7 @@ module.exports = {
 
 		// #region FORMATTING RULES
 
-		// We use formatting tools like Biome or prettier to format code, so most formatting-related rules are superfluous
-		// and are disabled. Running fewer rules also improves lint performance.
-
-		// The rules below are also deprecated in more recent versions of eslint/plugins
-		"@typescript-eslint/brace-style": "off",
-		"@typescript-eslint/comma-spacing": "off",
-		"@typescript-eslint/func-call-spacing": "off",
-		"@typescript-eslint/keyword-spacing": "off",
-		"@typescript-eslint/member-delimiter-style": "off",
-		"@typescript-eslint/semi": "off",
-		"@typescript-eslint/space-before-function-paren": "off",
-		"@typescript-eslint/space-infix-ops": "off",
-		"@typescript-eslint/type-annotation-spacing": "off",
-
 		// The rules below are deprecated in our current version of eslint/plugins
-		"@typescript-eslint/object-curly-spacing": "off",
 		"array-bracket-spacing": "off",
 		"arrow-spacing": "off",
 		"block-spacing": "off",

common/build/eslint-config-fluid/package.json

@@ -28,8 +28,8 @@
 		"@rushstack/eslint-patch": "~1.12.0",
 		"@rushstack/eslint-plugin": "~0.19.0",
 		"@rushstack/eslint-plugin-security": "~0.11.0",
-		"@typescript-eslint/eslint-plugin": "~7.18.0",
-		"@typescript-eslint/parser": "~7.18.0",
+		"@typescript-eslint/eslint-plugin": "~8.18.2",
+		"@typescript-eslint/parser": "~8.18.2",
 		"eslint-config-biome": "~2.1.3",
 		"eslint-config-prettier": "~10.1.8",
 		"eslint-import-resolver-typescript": "~4.4.4",