Commit 4e0431a
fix(fluid-build): shared eslint-config-fluid files to EsLintTask cache invalidation (#25997)
## Description
ESLint config changes in the shared
`@fluidframework/eslint-config-fluid` package were not properly
invalidating the eslint task because only the local config file was
tracked.
Extended `configFileFullPaths` in `EsLintTask` to include files from the
shared config:
- **Shared config tracking**: Tracks key files from
`@fluidframework/eslint-config-fluid` (index.js, base.js, strict.js,
recommended.js, minimal-deprecated.js, strict-biome.js, package.json) as
additional config files
- **Graceful handling**: Uses a path relative to the repo root
(`common/build/eslint-config-fluid`); if the directory doesn't exist,
gracefully skips this tracking
This keeps `EsLintTask` as a `TscDependentTask` while adding the
additional config file tracking needed to properly invalidate when
shared configs change.
## Reviewer Guidance
The change preserves existing behavior and simply extends
`configFileFullPaths` to include additional files. `TsLintTask` remains
unchanged.
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: tylerbutler <19589+tylerbutler@users.noreply.github.com>1 parent 87c1143 commit 4e0431a
File tree
1 file changed
+64
-1
lines changed- build-tools/packages/build-tools/src/fluidBuild/tasks/leaf
1 file changed
+64
-1
lines changedLines changed: 64 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
6 | 9 | | |
7 | 10 | | |
8 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
9 | 19 | | |
10 | 20 | | |
11 | 21 | | |
| |||
18 | 28 | | |
19 | 29 | | |
20 | 30 | | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
21 | 82 | | |
22 | 83 | | |
23 | 84 | | |
24 | 85 | | |
25 | 86 | | |
26 | 87 | | |
27 | 88 | | |
28 | | - | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
29 | 92 | | |
30 | 93 | | |
31 | 94 | | |
| |||
0 commit comments