Commit 7e80360
authored
fix(directory): Add clearInternal event and mark it as internal (#25927)
The standard clear event has the below limitation. It does not tell you
which subdirectory was cleared.
- It's emitted on the root SharedDirectory for all clear operations
- But it does NOT include the path of which directory was cleared
The event only provides:
- local: Whether it was a local or remote operation
- target: SharedDirectory itself
This limitation came to notice while adding event testing for directory:
#25477. The oracle needs
to track the state of every directory in the tree (root and all
subdirectories). When a clear operation happens:
- Without path information: The oracle would have to clear ALL
directories in its model, even though only one specific directory was
cleared
- Can't distinguish: A clear on /subdir1 vs /subdir2 vs root (/) would
all look the same
This change adds a new event `clearInternal` which takes in the absolute
path and it is marked as internal.
[AB#54326](https://dev.azure.com/fluidframework/internal/_workitems/edit/54326)1 parent 335ed1a commit 7e80360
2 files changed
+27
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| |||
402 | 402 | | |
403 | 403 | | |
404 | 404 | | |
405 | | - | |
| 405 | + | |
406 | 406 | | |
407 | 407 | | |
408 | 408 | | |
| |||
1570 | 1570 | | |
1571 | 1571 | | |
1572 | 1572 | | |
| 1573 | + | |
1573 | 1574 | | |
1574 | 1575 | | |
1575 | 1576 | | |
| |||
1581 | 1582 | | |
1582 | 1583 | | |
1583 | 1584 | | |
| 1585 | + | |
1584 | 1586 | | |
1585 | 1587 | | |
1586 | 1588 | | |
| |||
1907 | 1909 | | |
1908 | 1910 | | |
1909 | 1911 | | |
| 1912 | + | |
1910 | 1913 | | |
1911 | 1914 | | |
1912 | 1915 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
277 | 277 | | |
278 | 278 | | |
279 | 279 | | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
280 | 302 | | |
281 | 303 | | |
282 | 304 | | |
| |||
0 commit comments