Commit db4d93b
authored
feat(build-tools): add flag and environment variable to preserve version info in generated type tests (#25988)
## Description
Adds `skipVersionOutput` flag and `FLUB_TYPETEST_SKIP_VERSION_OUTPUT`
environment variable to `generate:typetests` command. When set,
preserves existing version information in generated type test file
headers instead of updating to current package versions.
**Implementation:**
- **`readExistingVersions()` function**: Parses existing type test files
to extract baseline and current version comments
- **`skipVersionOutput` flag**: Boolean flag with `env` property set to
`FLUB_TYPETEST_SKIP_VERSION_OUTPUT`, allowing the value to be set via
environment variable or command line. The flag is visible in help output
for discoverability.
- **Version preservation logic**: Uses the flag value to determine
whether to preserve existing versions; falls back to current versions if
file doesn't exist
- **Tests**: Added comprehensive test coverage including environment
variable behavior tests
- **Pipeline integration**: Automatically sets the environment variable
in the Build - client pipeline for `test/*` branches using the existing
`testBuild` variable
**Usage:**
```bash
# Regenerate type tests, preserving existing version comments (via environment variable)
FLUB_TYPETEST_SKIP_VERSION_OUTPUT=true flub generate:typetests --dir ./packages/my-package
# Or use the flag directly
flub generate:typetests --dir ./packages/my-package --skipVersionOutput
# Without flag/env var, versions update normally (default behavior)
flub generate:typetests --dir ./packages/my-package
```
**Pipeline behavior**: The environment variable is automatically set to
`true` when building from `test/*` branches in CI. The oclif flag system
automatically handles the type conversion from environment variable to
boolean. This preserves existing version information during test branch
builds without manual configuration.
Use case: in CI pipelines building from test branches, setting the
version may not be the preferred behavior. This flag/env variable allows
override.
## Breaking Changes
None. Feature only activates when environment variable is set or flag is
used.
## Reviewer Guidance
- Main logic in `processPackage()` around line 178-194
- `readExistingVersions()` uses `RegExp.exec()` and `"utf8"` encoding
per linting requirements
- Tests use `os.tmpdir()` for cross-platform compatibility and include
coverage for environment variable behavior
- Pipeline changes in `tools/pipelines/templates/include-build-lint.yml`
use existing `testBuild` variable to automatically set the environment
variable for `test/*` branches
- Flag definition at line 83-87 uses `env` property for environment
variable integration, following oclif best practices
- Flag is visible in help output for better discoverability
- ESLint errors fixed using object destructuring in test file1 parent cfbf960 commit db4d93b
File tree
4 files changed
+194
-8
lines changed- build-tools/packages/build-cli
- docs
- src
- commands/generate
- test/commands/generate
- tools/pipelines/templates
4 files changed
+194
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
443 | 443 | | |
444 | 444 | | |
445 | 445 | | |
446 | | - | |
447 | | - | |
448 | | - | |
449 | | - | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
450 | 451 | | |
451 | 452 | | |
452 | 453 | | |
| |||
458 | 459 | | |
459 | 460 | | |
460 | 461 | | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
461 | 465 | | |
462 | 466 | | |
463 | 467 | | |
| |||
Lines changed: 62 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
83 | 89 | | |
84 | 90 | | |
85 | 91 | | |
86 | 92 | | |
87 | 93 | | |
88 | 94 | | |
89 | | - | |
| 95 | + | |
90 | 96 | | |
91 | 97 | | |
92 | 98 | | |
| |||
168 | 174 | | |
169 | 175 | | |
170 | 176 | | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
171 | 196 | | |
172 | 197 | | |
173 | 198 | | |
| |||
178 | 203 | | |
179 | 204 | | |
180 | 205 | | |
181 | | - | |
182 | | - | |
| 206 | + | |
| 207 | + | |
183 | 208 | | |
184 | 209 | | |
185 | 210 | | |
| |||
254 | 279 | | |
255 | 280 | | |
256 | 281 | | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
257 | 315 | | |
258 | 316 | | |
259 | 317 | | |
| |||
Lines changed: 120 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
7 | 12 | | |
| 13 | + | |
8 | 14 | | |
9 | 15 | | |
10 | 16 | | |
| 17 | + | |
11 | 18 | | |
12 | 19 | | |
13 | 20 | | |
| |||
134 | 141 | | |
135 | 142 | | |
136 | 143 | | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
137 | 257 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
26 | 30 | | |
27 | 31 | | |
28 | 32 | | |
| |||
0 commit comments