Skip to content

Commit efb6e62

Browse files
Work around no longer functional assert tagging config (#26036)
## Description Our assert tagging started to try and tag packages under packages/test now ignoring the config which used to filter them out. I have added a workaround in the package filter to unblock assert tagging for Monday's release. I have filed a bug, and referenced it in the workaround.
1 parent bf869f5 commit efb6e62

File tree

5 files changed

+8
-5
lines changed

5 files changed

+8
-5
lines changed

fluidBuild.config.cjs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -599,7 +599,8 @@ module.exports = {
599599
},
600600

601601
assertTagging: {
602-
enabledPaths: [/^common\/lib\/common-utils/i, /^experimental/i, /^packages/i],
602+
// TODO: AB#55437: excluding packages under packages/test should not be required: there is a config file at packages/test/assertTagging.config.mjs which used to accomplish this but it stopped working.
603+
enabledPaths: [/^common\/lib\/common-utils/i, /^experimental/i, /^packages\/(?!test\/)/i],
603604
},
604605

605606
// `flub bump` config. These settings influence `flub bump` behavior for a release group. These settings can be

packages/dds/test-dds-utils/assertTagging.config.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*/
55

66
/**
7-
* @type {import("@fluid-tools/build-cli").AssertTaggingConfig}
7+
* @type {import("@fluid-tools/build-cli").AssertTaggingPackageConfig}
88
*/
99
export default {
1010
// Disables assert tagging by listing an empty set of functions that should be tagged.

packages/dds/tree/assertTagging.config.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*/
55

66
/**
7-
* @type {import("@fluid-tools/build-cli").AssertTaggingConfig}
7+
* @type {import("@fluid-tools/build-cli").AssertTaggingPackageConfig}
88
*/
99
export default {
1010
assertionFunctions: {

packages/runtime/test-runtime-utils/assertTagging.config.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@
44
*/
55

66
/**
7-
* @type {import("@fluid-tools/build-cli").AssertTaggingConfig}
7+
* @type {import("@fluid-tools/build-cli").AssertTaggingPackageConfig}
88
*/
99
export default { assertionFunctions: { assertionFunctions: {} } };

packages/test/assertTagging.config.mjs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@
44
*/
55

66
/**
7-
* @type {import("@fluid-tools/build-cli").AssertTaggingConfig}
7+
* @type {import("@fluid-tools/build-cli").AssertTaggingPackageConfig}
8+
*
9+
* TODO: AB#55437: This config file is not working as intended. There is a workaround in top level fluidBuild.config.cjs for now.
810
*/
911
export default {
1012
// Disables assert tagging by listing an empty set of functions that should be tagged.

0 commit comments

Comments
 (0)