Skip to content

Commit 688fcc5

Browse files
Copilotbaywet
andcommitted
Rewrite test assertions to use Assert methods instead of FluentAssertions and add V3 tests
Co-authored-by: baywet <7905502+baywet@users.noreply.github.com>
1 parent 33a219e commit 688fcc5

File tree

5 files changed

+56
-18
lines changed

5 files changed

+56
-18
lines changed

test/Microsoft.OpenApi.Readers.Tests/V31Tests/OpenApiExampleTests.cs

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
using System.IO;
55
using System.Text.Json.Nodes;
66
using System.Threading.Tasks;
7-
using FluentAssertions;
87
using Microsoft.OpenApi.Reader;
98
using Xunit;
109

@@ -26,11 +25,11 @@ public async Task ParseExampleWithDataValueExtensionShouldSucceed()
2625
SettingsFixture.ReaderSettings);
2726

2827
// Assert
29-
example.Should().NotBeNull();
30-
example.Summary.Should().Be("Example with dataValue (extension)");
31-
example.DataValue.Should().NotBeNull();
32-
example.DataValue["name"].GetValue<string>().Should().Be("Jane Smith");
33-
example.DataValue["age"].GetValue<decimal>().Should().Be(25);
28+
Assert.NotNull(example);
29+
Assert.Equal("Example with dataValue (extension)", example.Summary);
30+
Assert.NotNull(example.DataValue);
31+
Assert.Equal("Jane Smith", example.DataValue["name"].GetValue<string>());
32+
Assert.Equal(25, example.DataValue["age"].GetValue<decimal>());
3433
}
3534

3635
[Fact]
@@ -44,9 +43,9 @@ public async Task ParseExampleWithSerializedValueExtensionShouldSucceed()
4443
SettingsFixture.ReaderSettings);
4544

4645
// Assert
47-
example.Should().NotBeNull();
48-
example.Summary.Should().Be("Example with serializedValue (extension)");
49-
example.SerializedValue.Should().Be("custom serialized string with extension");
46+
Assert.NotNull(example);
47+
Assert.Equal("Example with serializedValue (extension)", example.Summary);
48+
Assert.Equal("custom serialized string with extension", example.SerializedValue);
5049
}
5150
}
5251
}

test/Microsoft.OpenApi.Readers.Tests/V32Tests/OpenApiExampleTests.cs

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
using System.IO;
55
using System.Text.Json.Nodes;
66
using System.Threading.Tasks;
7-
using FluentAssertions;
87
using Microsoft.OpenApi.Reader;
98
using Xunit;
109

@@ -26,11 +25,11 @@ public async Task ParseExampleWithDataValueShouldSucceed()
2625
SettingsFixture.ReaderSettings);
2726

2827
// Assert
29-
example.Should().NotBeNull();
30-
example.Summary.Should().Be("Example with dataValue");
31-
example.DataValue.Should().NotBeNull();
32-
example.DataValue["name"].GetValue<string>().Should().Be("John Doe");
33-
example.DataValue["age"].GetValue<decimal>().Should().Be(30);
28+
Assert.NotNull(example);
29+
Assert.Equal("Example with dataValue", example.Summary);
30+
Assert.NotNull(example.DataValue);
31+
Assert.Equal("John Doe", example.DataValue["name"].GetValue<string>());
32+
Assert.Equal(30, example.DataValue["age"].GetValue<decimal>());
3433
}
3534

3635
[Fact]
@@ -44,9 +43,9 @@ public async Task ParseExampleWithSerializedValueShouldSucceed()
4443
SettingsFixture.ReaderSettings);
4544

4645
// Assert
47-
example.Should().NotBeNull();
48-
example.Summary.Should().Be("Example with serializedValue");
49-
example.SerializedValue.Should().Be("custom serialized string");
46+
Assert.NotNull(example);
47+
Assert.Equal("Example with serializedValue", example.Summary);
48+
Assert.Equal("custom serialized string", example.SerializedValue);
5049
}
5150
}
5251
}

test/Microsoft.OpenApi.Readers.Tests/V3Tests/OpenApiExampleTests.cs

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,5 +73,39 @@ public async Task ParseExampleForcedStringSucceed()
7373
var result = await OpenApiDocument.LoadAsync(Path.Combine(SampleFolderPath, "explicitString.yaml"), SettingsFixture.ReaderSettings);
7474
Assert.Empty(result.Diagnostic.Errors);
7575
}
76+
77+
[Fact]
78+
public async Task ParseExampleWithDataValueExtensionShouldSucceed()
79+
{
80+
// Arrange & Act
81+
var example = await OpenApiModelFactory.LoadAsync<OpenApiExample>(
82+
Path.Combine(SampleFolderPath, "exampleWithDataValue.yaml"),
83+
OpenApiSpecVersion.OpenApi3_0,
84+
new(),
85+
SettingsFixture.ReaderSettings);
86+
87+
// Assert
88+
Assert.NotNull(example);
89+
Assert.Equal("Example with dataValue (extension)", example.Summary);
90+
Assert.NotNull(example.DataValue);
91+
Assert.Equal("Alice Johnson", example.DataValue["name"].GetValue<string>());
92+
Assert.Equal(28, example.DataValue["age"].GetValue<decimal>());
93+
}
94+
95+
[Fact]
96+
public async Task ParseExampleWithSerializedValueExtensionShouldSucceed()
97+
{
98+
// Arrange & Act
99+
var example = await OpenApiModelFactory.LoadAsync<OpenApiExample>(
100+
Path.Combine(SampleFolderPath, "exampleWithSerializedValue.yaml"),
101+
OpenApiSpecVersion.OpenApi3_0,
102+
new(),
103+
SettingsFixture.ReaderSettings);
104+
105+
// Assert
106+
Assert.NotNull(example);
107+
Assert.Equal("Example with serializedValue (extension)", example.Summary);
108+
Assert.Equal("custom serialized string for V3", example.SerializedValue);
109+
}
76110
}
77111
}
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
summary: Example with dataValue (extension)
2+
x-oai-dataValue:
3+
name: Alice Johnson
4+
age: 28
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
summary: Example with serializedValue (extension)
2+
x-oai-serializedValue: "custom serialized string for V3"

0 commit comments

Comments
 (0)