chore: implement PR feedback

Author: MaggieKimani1

src/Microsoft.OpenApi/Models/OpenApiDocument.cs

@@ -588,18 +588,19 @@ private static string ConvertByteArrayToString(byte[] hash)
             else
             {
                 string relativePath;
+                var referenceV3 = !string.IsNullOrEmpty(reference.ReferenceV3) ? reference.ReferenceV3! : string.Empty;
 
-                if (!string.IsNullOrEmpty(reference.ReferenceV3) && IsSubComponent(reference.ReferenceV3!))
+                if (!string.IsNullOrEmpty(referenceV3) && IsSubComponent(referenceV3))
                 {
                     // Enables setting the complete JSON path for nested subschemas e.g. #/components/schemas/person/properties/address
                     if (useExternal)
                     {
-                        var relPathSegment = reference.ReferenceV3!.Split('#')[1];
+                        var relPathSegment = referenceV3.Split(['#'], StringSplitOptions.RemoveEmptyEntries)[1];
                         relativePath = $"#{relPathSegment}";
                     }
                     else
                     {
-                        relativePath = reference.ReferenceV3!;
+                        relativePath = referenceV3;
                     }
                 }
                 else
@@ -614,7 +615,7 @@ private static string ConvertByteArrayToString(byte[] hash)
                     : BaseUri + relativePath;
             }
 
-            if (reference.Type is ReferenceType.Schema && !uriLocation.StartsWith("http", StringComparison.OrdinalIgnoreCase))
+            if (reference.Type is ReferenceType.Schema && uriLocation.Contains('#'))
             {
                 return Workspace?.ResolveJsonSchemaReference(new Uri(uriLocation).AbsoluteUri);
             }
@@ -630,11 +631,11 @@ private static bool IsSubComponent(string reference)
 
             if (fragment.StartsWith("/components/schemas/", StringComparison.OrdinalIgnoreCase))
             {
-                var segments = fragment.Split('/');
+                var segments = fragment.Split(['/'], StringSplitOptions.RemoveEmptyEntries);
 
-                // Expect exactly 4 segments for root-level schema: ["", "components", "schemas", "person"]
+                // Expect exactly 3 segments for root-level schema: ["components", "schemas", "person"]
                 // Anything longer means it's a subcomponent.
-                return segments.Length > 4;
+                return segments.Length > 3;
             }
 
             return false;

src/Microsoft.OpenApi/Models/OpenApiReference.cs

@@ -106,9 +106,9 @@ public string? ReferenceV3
                     return Id;
                 }
 
-                return _referenceV3 = "#/components/" + Type.GetDisplayName() + "/" + Id;
+                return _referenceV3 = $"#/components/{Type.GetDisplayName()}/{Id}";
             }
-            set 
+            private set 
             { 
                 if (value is not null)
                 {
@@ -139,7 +139,7 @@ public string? ReferenceV2
                     return Id;
                 }
 
-                return "#/" + GetReferenceTypeNameAsV2(Type) + "/" + Id;
+                return $"#/{GetReferenceTypeNameAsV2(Type)}/{Id}";
             }
         }
 
@@ -316,7 +316,7 @@ internal void SetSummaryAndDescriptionFromMapNode(MapNode mapNode)
         internal void SetJsonPointerPath(string pointer)
         {
             // Eg of an internal subcomponent's JSONPath: #/components/schemas/person/properties/address
-            if ((pointer.Contains("#") || pointer.StartsWith("http", StringComparison.OrdinalIgnoreCase)) 
+            if ((pointer.Contains('#') || pointer.StartsWith("http", StringComparison.OrdinalIgnoreCase)) 
                 && !string.IsNullOrEmpty(ReferenceV3) && !ReferenceV3!.Equals(pointer, StringComparison.OrdinalIgnoreCase))
             {
                 ReferenceV3 = pointer;

src/Microsoft.OpenApi/Services/OpenApiWorkspace.cs

@@ -336,7 +336,7 @@ public bool Contains(string location)
         /// </summary>
         /// <param name="location"></param>
         /// <returns></returns>
-        public IOpenApiSchema? ResolveJsonSchemaReference(string location)
+        internal IOpenApiSchema? ResolveJsonSchemaReference(string location)
         {
             /* Enables resolving references for nested subschemas
              * Examples:
@@ -360,7 +360,7 @@ public bool Contains(string location)
                     Fragment = fragment
                 }; // to avoid escaping the # character in the resulting Uri
 
-                if (_IOpenApiReferenceableRegistry.TryGetValue(uriBuilder.Uri, out var schema) && schema is OpenApiSchema targetSchema)
+                if (_IOpenApiReferenceableRegistry.TryGetValue(uriBuilder.Uri, out var schema) && schema is IOpenApiSchema targetSchema)
                 {
                     // traverse remaining segments after fetching the base schema
                     var remainingSegments = pathSegments.Skip(4).ToArray();

test/Microsoft.OpenApi.Readers.Tests/V31Tests/ReferenceSamples/rootComponentSchemaReference.yaml

@@ -16,7 +16,7 @@ paths:
                       $ref: '#/components/schemas/specialitem'
 components:
     schemas:
-      specialitem:  # Use the item type but provide a different title for the type
+      specialitem:
         title: Special Item
         $ref: "#/components/schemas/item"
       item:

test/Microsoft.OpenApi.Tests/PublicApi/PublicApi.approved.txt

@@ -965,7 +965,7 @@ namespace Microsoft.OpenApi.Models
         public bool IsFragment { get; init; }
         public bool IsLocal { get; }
         public string? ReferenceV2 { get; }
-        public string? ReferenceV3 { get; set; }
+        public string? ReferenceV3 { get; }
         public string? Summary { get; set; }
         public Microsoft.OpenApi.Models.ReferenceType Type { get; init; }
         public void SerializeAsV2(Microsoft.OpenApi.Writers.IOpenApiWriter writer) { }
@@ -1650,7 +1650,6 @@ namespace Microsoft.OpenApi.Services
         public System.Uri? GetDocumentId(string? key) { }
         public bool RegisterComponentForDocument<T>(Microsoft.OpenApi.Models.OpenApiDocument openApiDocument, T componentToRegister, string id) { }
         public void RegisterComponents(Microsoft.OpenApi.Models.OpenApiDocument document) { }
-        public Microsoft.OpenApi.Models.Interfaces.IOpenApiSchema? ResolveJsonSchemaReference(string location) { }
         public T? ResolveReference<T>(string location) { }
     }
     public class OperationSearch : Microsoft.OpenApi.Services.OpenApiVisitorBase