Skip to content

Commit d14936c

Browse files
committed
chore: use deep equals for json comparison in media type tests
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
1 parent 8fd882d commit d14936c

File tree

1 file changed

+8
-24
lines changed

1 file changed

+8
-24
lines changed

test/Microsoft.OpenApi.Tests/Models/OpenApiMediaTypeTests.cs

Lines changed: 8 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -182,9 +182,7 @@ public async Task SerializeAdvanceMediaTypeAsV3JsonWorks()
182182
var actual = await AdvanceMediaType.SerializeAsJsonAsync(OpenApiSpecVersion.OpenApi3_0);
183183

184184
// Assert
185-
actual = actual.MakeLineBreaksEnvironmentNeutral();
186-
expected = expected.MakeLineBreaksEnvironmentNeutral();
187-
Assert.Equal(expected, actual);
185+
Assert.True(JsonNode.DeepEquals(JsonNode.Parse(actual), JsonNode.Parse(expected)));
188186
}
189187

190188
[Fact]
@@ -292,9 +290,7 @@ public async Task SerializeMediaTypeWithObjectExampleAsV3JsonWorks()
292290
var actual = await MediaTypeWithObjectExample.SerializeAsJsonAsync(OpenApiSpecVersion.OpenApi3_0);
293291

294292
// Assert
295-
actual = actual.MakeLineBreaksEnvironmentNeutral();
296-
expected = expected.MakeLineBreaksEnvironmentNeutral();
297-
Assert.Equal(expected, actual);
293+
Assert.True(JsonNode.DeepEquals(JsonNode.Parse(actual), JsonNode.Parse(expected)));
298294
}
299295

300296
[Fact]
@@ -344,9 +340,7 @@ public async Task SerializeMediaTypeWithXmlExampleAsV3JsonWorks()
344340
var actual = await MediaTypeWithXmlExample.SerializeAsJsonAsync(OpenApiSpecVersion.OpenApi3_0);
345341

346342
// Assert
347-
actual = actual.MakeLineBreaksEnvironmentNeutral();
348-
expected = expected.MakeLineBreaksEnvironmentNeutral();
349-
Assert.Equal(expected, actual);
343+
Assert.True(JsonNode.DeepEquals(JsonNode.Parse(actual), JsonNode.Parse(expected)));
350344
}
351345

352346
[Fact]
@@ -438,9 +432,7 @@ public async Task SerializeMediaTypeWithObjectExamplesAsV3JsonWorks()
438432
_output.WriteLine(actual);
439433

440434
// Assert
441-
actual = actual.MakeLineBreaksEnvironmentNeutral();
442-
expected = expected.MakeLineBreaksEnvironmentNeutral();
443-
Assert.Equal(expected, actual);
435+
Assert.True(JsonNode.DeepEquals(JsonNode.Parse(actual), JsonNode.Parse(expected)));
444436
}
445437

446438
[Fact]
@@ -482,9 +474,7 @@ public async Task SerializeMediaTypeWithItemEncodingAsV32JsonWorks()
482474
var actual = await MediaTypeWithItemEncoding.SerializeAsJsonAsync(OpenApiSpecVersion.OpenApi3_2);
483475

484476
// Assert
485-
actual = actual.MakeLineBreaksEnvironmentNeutral();
486-
expected = expected.MakeLineBreaksEnvironmentNeutral();
487-
Assert.Equal(expected, actual);
477+
Assert.True(JsonNode.DeepEquals(JsonNode.Parse(actual), JsonNode.Parse(expected)));
488478
}
489479

490480
[Fact]
@@ -507,9 +497,7 @@ public async Task SerializeMediaTypeWithItemEncodingAsV31JsonWorks()
507497
var actual = await MediaTypeWithItemEncoding.SerializeAsJsonAsync(OpenApiSpecVersion.OpenApi3_1);
508498

509499
// Assert
510-
actual = actual.MakeLineBreaksEnvironmentNeutral();
511-
expected = expected.MakeLineBreaksEnvironmentNeutral();
512-
Assert.Equal(expected, actual);
500+
Assert.True(JsonNode.DeepEquals(JsonNode.Parse(actual), JsonNode.Parse(expected)));
513501
}
514502

515503
[Fact]
@@ -538,9 +526,7 @@ public async Task SerializeMediaTypeWithPrefixEncodingAsV32JsonWorks()
538526
var actual = await MediaTypeWithPrefixEncoding.SerializeAsJsonAsync(OpenApiSpecVersion.OpenApi3_2);
539527

540528
// Assert
541-
actual = actual.MakeLineBreaksEnvironmentNeutral();
542-
expected = expected.MakeLineBreaksEnvironmentNeutral();
543-
Assert.Equal(expected, actual);
529+
Assert.True(JsonNode.DeepEquals(JsonNode.Parse(actual), JsonNode.Parse(expected)));
544530
}
545531

546532
[Fact]
@@ -569,9 +555,7 @@ public async Task SerializeMediaTypeWithPrefixEncodingAsV31JsonWorks()
569555
var actual = await MediaTypeWithPrefixEncoding.SerializeAsJsonAsync(OpenApiSpecVersion.OpenApi3_1);
570556

571557
// Assert
572-
actual = actual.MakeLineBreaksEnvironmentNeutral();
573-
expected = expected.MakeLineBreaksEnvironmentNeutral();
574-
Assert.Equal(expected, actual);
558+
Assert.True(JsonNode.DeepEquals(JsonNode.Parse(actual), JsonNode.Parse(expected)));
575559
}
576560
}
577561
}

0 commit comments

Comments
 (0)