Apply suggestions from code review

desjoerd · baywet · web-flow · commit f72d77c9640c · 2025-12-15T20:40:32.000+01:00
Co-authored-by: Vincent Biret &lt;vincentbiret@hotmail.com&gt;
diff --git a/src/Microsoft.OpenApi/Models/OpenApiSchema.cs b/src/Microsoft.OpenApi/Models/OpenApiSchema.cs
@@ -865,14 +865,14 @@ private void SerializeNullable(IOpenApiWriter writer, OpenApiSpecVersion version
         private static (IList<IOpenApiSchema>? effective, JsonSchemaType? inferredType, bool hasNullInComposition)
             ProcessCompositionForNull(IList<IOpenApiSchema>? composition)
         {
-            if (composition is null || !composition.Any(s => s.Type is JsonSchemaType.Null))
+            if (composition is null || !composition.Any(static s => s.Type is JsonSchemaType.Null))
             {
                 // Nothing to patch
                 return (composition, null, false);
             }
 
             var nonNullSchemas = composition
-                .Where(s => s.Type is null or not JsonSchemaType.Null)
+                .Where(static s => s.Type is null or not JsonSchemaType.Null)
                 .ToList();
 
             if (nonNullSchemas.Count > 0)

Original file line number	Diff line number	Diff line change
`@@ -865,14 +865,14 @@ private void SerializeNullable(IOpenApiWriter writer, OpenApiSpecVersion version`
`865`	`865`	`private static (IList<IOpenApiSchema>? effective, JsonSchemaType? inferredType, bool hasNullInComposition)`
`866`	`866`	`ProcessCompositionForNull(IList<IOpenApiSchema>? composition)`
`867`	`867`	`{`
`868`		`- if (composition is null \|\| !composition.Any(s => s.Type is JsonSchemaType.Null))`
	`868`	`+ if (composition is null \|\| !composition.Any(static s => s.Type is JsonSchemaType.Null))`
`869`	`869`	`{`
`870`	`870`	`// Nothing to patch`
`871`	`871`	`return (composition, null, false);`
`872`	`872`	`}`
`873`	`873`
`874`	`874`	`var nonNullSchemas = composition`
`875`		`- .Where(s => s.Type is null or not JsonSchemaType.Null)`
	`875`	`+ .Where(static s => s.Type is null or not JsonSchemaType.Null)`
`876`	`876`	`.ToList();`
`877`	`877`
`878`	`878`	`if (nonNullSchemas.Count > 0)`