Skip to content

Commit 0dc24aa

Browse files
added overriding type to dom lib
1 parent e471abc commit 0dc24aa

File tree

8 files changed

+21
-8
lines changed

8 files changed

+21
-8
lines changed

baselines/dom.generated.d.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15071,7 +15071,7 @@ interface GlobalEventHandlers {
1507115071
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLMediaElement/ended_event) */
1507215072
onended: ((this: GlobalEventHandlers, ev: Event) => any) | null;
1507315073
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/error_event) */
15074-
onerror: OnErrorEventHandler;
15074+
onerror: DocumentOrGlobalOnErrorHandler;
1507515075
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/focus_event) */
1507615076
onfocus: ((this: GlobalEventHandlers, ev: FocusEvent) => any) | null;
1507715077
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLFormElement/formdata_event) */
@@ -41635,7 +41635,7 @@ declare var onemptied: ((this: Window, ev: Event) => any) | null;
4163541635
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLMediaElement/ended_event) */
4163641636
declare var onended: ((this: Window, ev: Event) => any) | null;
4163741637
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/error_event) */
41638-
declare var onerror: OnErrorEventHandler;
41638+
declare var onerror: DocumentOrGlobalOnErrorHandler;
4163941639
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/focus_event) */
4164041640
declare var onfocus: ((this: Window, ev: FocusEvent) => any) | null;
4164141641
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLFormElement/formdata_event) */
@@ -41912,6 +41912,7 @@ type ConstrainDouble = number | ConstrainDoubleRange;
4191241912
type ConstrainULong = number | ConstrainULongRange;
4191341913
type CookieList = CookieListItem[];
4191441914
type DOMHighResTimeStamp = number;
41915+
type DocumentOrGlobalOnErrorHandler = (((event: Event) => any) | ((event: UIEvent) => any) | OnErrorEventHandlerNonNull) | null;
4191541916
type EpochTimeStamp = number;
4191641917
type EventListenerOrEventListenerObject = EventListener | EventListenerObject;
4191741918
type FileSystemWriteChunkType = BufferSource | Blob | string | WriteParams;

baselines/ts5.5/dom.generated.d.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15057,7 +15057,7 @@ interface GlobalEventHandlers {
1505715057
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLMediaElement/ended_event) */
1505815058
onended: ((this: GlobalEventHandlers, ev: Event) => any) | null;
1505915059
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/error_event) */
15060-
onerror: OnErrorEventHandler;
15060+
onerror: DocumentOrGlobalOnErrorHandler;
1506115061
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/focus_event) */
1506215062
onfocus: ((this: GlobalEventHandlers, ev: FocusEvent) => any) | null;
1506315063
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLFormElement/formdata_event) */
@@ -41609,7 +41609,7 @@ declare var onemptied: ((this: Window, ev: Event) => any) | null;
4160941609
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLMediaElement/ended_event) */
4161041610
declare var onended: ((this: Window, ev: Event) => any) | null;
4161141611
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/error_event) */
41612-
declare var onerror: OnErrorEventHandler;
41612+
declare var onerror: DocumentOrGlobalOnErrorHandler;
4161341613
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/focus_event) */
4161441614
declare var onfocus: ((this: Window, ev: FocusEvent) => any) | null;
4161541615
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLFormElement/formdata_event) */
@@ -41886,6 +41886,7 @@ type ConstrainDouble = number | ConstrainDoubleRange;
4188641886
type ConstrainULong = number | ConstrainULongRange;
4188741887
type CookieList = CookieListItem[];
4188841888
type DOMHighResTimeStamp = number;
41889+
type DocumentOrGlobalOnErrorHandler = (((event: Event) => any) | ((event: UIEvent) => any) | OnErrorEventHandlerNonNull) | null;
4188941890
type EpochTimeStamp = number;
4189041891
type EventListenerOrEventListenerObject = EventListener | EventListenerObject;
4189141892
type FileSystemWriteChunkType = BufferSource | Blob | string | WriteParams;

baselines/ts5.6/dom.generated.d.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15068,7 +15068,7 @@ interface GlobalEventHandlers {
1506815068
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLMediaElement/ended_event) */
1506915069
onended: ((this: GlobalEventHandlers, ev: Event) => any) | null;
1507015070
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/error_event) */
15071-
onerror: OnErrorEventHandler;
15071+
onerror: DocumentOrGlobalOnErrorHandler;
1507215072
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/focus_event) */
1507315073
onfocus: ((this: GlobalEventHandlers, ev: FocusEvent) => any) | null;
1507415074
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLFormElement/formdata_event) */
@@ -41632,7 +41632,7 @@ declare var onemptied: ((this: Window, ev: Event) => any) | null;
4163241632
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLMediaElement/ended_event) */
4163341633
declare var onended: ((this: Window, ev: Event) => any) | null;
4163441634
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/error_event) */
41635-
declare var onerror: OnErrorEventHandler;
41635+
declare var onerror: DocumentOrGlobalOnErrorHandler;
4163641636
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/focus_event) */
4163741637
declare var onfocus: ((this: Window, ev: FocusEvent) => any) | null;
4163841638
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLFormElement/formdata_event) */
@@ -41909,6 +41909,7 @@ type ConstrainDouble = number | ConstrainDoubleRange;
4190941909
type ConstrainULong = number | ConstrainULongRange;
4191041910
type CookieList = CookieListItem[];
4191141911
type DOMHighResTimeStamp = number;
41912+
type DocumentOrGlobalOnErrorHandler = (((event: Event) => any) | ((event: UIEvent) => any) | OnErrorEventHandlerNonNull) | null;
4191241913
type EpochTimeStamp = number;
4191341914
type EventListenerOrEventListenerObject = EventListener | EventListenerObject;
4191441915
type FileSystemWriteChunkType = BufferSource | Blob | string | WriteParams;

inputfiles/addedTypes.jsonc

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -846,6 +846,12 @@
846846
// Full spec at https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#autofill.
847847
"name": "AutoFill",
848848
"overrideType": "AutoFillBase | `${OptionalPrefixToken<AutoFillSection>}${OptionalPrefixToken<AutoFillAddressKind>}${AutoFillField}${OptionalPostfixToken<AutoFillCredentialField>}`"
849+
},
850+
{
851+
"name": "DocumentOrGlobalOnErrorHandler",
852+
"nullable": true,
853+
"overrideType": "((event: Event) => any) | ((event: UIEvent) => any) | OnErrorEventHandlerNonNull",
854+
"exposed": "Window"
849855
}
850856
]
851857
}

inputfiles/knownTypes.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
"CompositeOperationOrAuto",
2222
"ComputedKeyframe",
2323
"DisplayCaptureSurfaceType",
24+
"DocumentOrGlobalOnErrorHandler",
2425
"EcdhKeyDeriveParams",
2526
"EcdsaParams",
2627
"EcKeyAlgorithm",

inputfiles/patches/events.kdl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ interface-mixin GlobalEventHandlers {
7474
event transitionstart type=TransitionEvent
7575
event transitionend type=TransitionEvent
7676
event transitioncancel type=TransitionEvent
77-
property onerror overrideType=OnErrorEventHandler
77+
property onerror overrideType=DocumentOrGlobalOnErrorHandler
7878
}
7979

8080
interface-mixin MessageEventTarget {

src/build/expose.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,9 @@ export function getExposedTypes(
8888

8989
if (webidl.typedefs) {
9090
const referenced = webidl.typedefs.typedef.filter(
91-
(t) => knownIDLTypes.has(t.name) || forceKnownTypesLogged.has(t.name),
91+
(t) =>
92+
(knownIDLTypes.has(t.name) || forceKnownTypesLogged.has(t.name)) &&
93+
exposesTo(t, target),
9294
);
9395
const { exposed, removed } = filterTypedefs(referenced, unexposedTypes);
9496
removed.forEach((s) => unexposedTypes.add(s));

src/build/types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,7 @@ export interface TypeDef extends Typed {
233233
deprecated?: boolean;
234234
legacyNamespace?: string;
235235
typeParameters?: TypeParameter[];
236+
exposed?: string;
236237
}
237238

238239
export interface Dictionary {

0 commit comments

Comments
 (0)