Skip to content

Commit ac32a76

Browse files
cosmic-pixel-paintercosmic-pixel-painter
committed
added event listener fix to html and svg element
1 parent 4be812a commit ac32a76

File tree

5 files changed

+131
-1
lines changed

5 files changed

+131
-1
lines changed

‎baselines/dom.generated.d.ts‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14183,6 +14183,12 @@ interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEdit
1418314183
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/togglePopover)
1418414184
*/
1418514185
togglePopover(options?: boolean): boolean;
14186+
/**
14187+
* The addEventListener() method of the EventTarget interface sets up a function that will be called whenever the specified event is delivered to the target.
14188+
*
14189+
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener)
14190+
*/
14191+
addEventListener(type: string, listener: ((event: Event) => void) | ((event: UIEvent) => void)): void;
1418614192
addEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
1418714193
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
1418814194
removeEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
@@ -27401,6 +27407,12 @@ interface SVGElement extends Element, ElementCSSInlineStyle, GlobalEventHandlers
2740127407
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/SVGElement/viewportElement)
2740227408
*/
2740327409
readonly viewportElement: SVGElement | null;
27410+
/**
27411+
* The addEventListener() method of the EventTarget interface sets up a function that will be called whenever the specified event is delivered to the target.
27412+
*
27413+
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener)
27414+
*/
27415+
addEventListener(type: string, listener: ((event: Event) => void) | ((event: UIEvent) => void)): void;
2740427416
addEventListener<K extends keyof SVGElementEventMap>(type: K, listener: (this: SVGElement, ev: SVGElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
2740527417
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
2740627418
removeEventListener<K extends keyof SVGElementEventMap>(type: K, listener: (this: SVGElement, ev: SVGElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
@@ -29763,6 +29775,12 @@ interface SVGSVGElement extends SVGGraphicsElement, SVGFitToViewBox, WindowEvent
2976329775
unsuspendRedraw(suspendHandleID: number): void;
2976429776
/** @deprecated */
2976529777
unsuspendRedrawAll(): void;
29778+
/**
29779+
* The addEventListener() method of the EventTarget interface sets up a function that will be called whenever the specified event is delivered to the target.
29780+
*
29781+
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener)
29782+
*/
29783+
addEventListener(type: string, listener: ((event: Event) => void) | ((event: UIEvent) => void)): void;
2976629784
addEventListener<K extends keyof SVGSVGElementEventMap>(type: K, listener: (this: SVGSVGElement, ev: SVGSVGElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
2976729785
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
2976829786
removeEventListener<K extends keyof SVGSVGElementEventMap>(type: K, listener: (this: SVGSVGElement, ev: SVGSVGElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;

‎baselines/ts5.5/dom.generated.d.ts‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14170,6 +14170,12 @@ interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEdit
1417014170
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/togglePopover)
1417114171
*/
1417214172
togglePopover(options?: boolean): boolean;
14173+
/**
14174+
* The addEventListener() method of the EventTarget interface sets up a function that will be called whenever the specified event is delivered to the target.
14175+
*
14176+
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener)
14177+
*/
14178+
addEventListener(type: string, listener: ((event: Event) => void) | ((event: UIEvent) => void)): void;
1417314179
addEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
1417414180
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
1417514181
removeEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
@@ -27379,6 +27385,12 @@ interface SVGElement extends Element, ElementCSSInlineStyle, GlobalEventHandlers
2737927385
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/SVGElement/viewportElement)
2738027386
*/
2738127387
readonly viewportElement: SVGElement | null;
27388+
/**
27389+
* The addEventListener() method of the EventTarget interface sets up a function that will be called whenever the specified event is delivered to the target.
27390+
*
27391+
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener)
27392+
*/
27393+
addEventListener(type: string, listener: ((event: Event) => void) | ((event: UIEvent) => void)): void;
2738227394
addEventListener<K extends keyof SVGElementEventMap>(type: K, listener: (this: SVGElement, ev: SVGElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
2738327395
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
2738427396
removeEventListener<K extends keyof SVGElementEventMap>(type: K, listener: (this: SVGElement, ev: SVGElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
@@ -29741,6 +29753,12 @@ interface SVGSVGElement extends SVGGraphicsElement, SVGFitToViewBox, WindowEvent
2974129753
unsuspendRedraw(suspendHandleID: number): void;
2974229754
/** @deprecated */
2974329755
unsuspendRedrawAll(): void;
29756+
/**
29757+
* The addEventListener() method of the EventTarget interface sets up a function that will be called whenever the specified event is delivered to the target.
29758+
*
29759+
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener)
29760+
*/
29761+
addEventListener(type: string, listener: ((event: Event) => void) | ((event: UIEvent) => void)): void;
2974429762
addEventListener<K extends keyof SVGSVGElementEventMap>(type: K, listener: (this: SVGSVGElement, ev: SVGSVGElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
2974529763
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
2974629764
removeEventListener<K extends keyof SVGSVGElementEventMap>(type: K, listener: (this: SVGSVGElement, ev: SVGSVGElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;

‎baselines/ts5.6/dom.generated.d.ts‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14183,6 +14183,12 @@ interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEdit
1418314183
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/togglePopover)
1418414184
*/
1418514185
togglePopover(options?: boolean): boolean;
14186+
/**
14187+
* The addEventListener() method of the EventTarget interface sets up a function that will be called whenever the specified event is delivered to the target.
14188+
*
14189+
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener)
14190+
*/
14191+
addEventListener(type: string, listener: ((event: Event) => void) | ((event: UIEvent) => void)): void;
1418614192
addEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
1418714193
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
1418814194
removeEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
@@ -27401,6 +27407,12 @@ interface SVGElement extends Element, ElementCSSInlineStyle, GlobalEventHandlers
2740127407
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/SVGElement/viewportElement)
2740227408
*/
2740327409
readonly viewportElement: SVGElement | null;
27410+
/**
27411+
* The addEventListener() method of the EventTarget interface sets up a function that will be called whenever the specified event is delivered to the target.
27412+
*
27413+
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener)
27414+
*/
27415+
addEventListener(type: string, listener: ((event: Event) => void) | ((event: UIEvent) => void)): void;
2740427416
addEventListener<K extends keyof SVGElementEventMap>(type: K, listener: (this: SVGElement, ev: SVGElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
2740527417
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
2740627418
removeEventListener<K extends keyof SVGElementEventMap>(type: K, listener: (this: SVGElement, ev: SVGElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
@@ -29763,6 +29775,12 @@ interface SVGSVGElement extends SVGGraphicsElement, SVGFitToViewBox, WindowEvent
2976329775
unsuspendRedraw(suspendHandleID: number): void;
2976429776
/** @deprecated */
2976529777
unsuspendRedrawAll(): void;
29778+
/**
29779+
* The addEventListener() method of the EventTarget interface sets up a function that will be called whenever the specified event is delivered to the target.
29780+
*
29781+
* [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener)
29782+
*/
29783+
addEventListener(type: string, listener: ((event: Event) => void) | ((event: UIEvent) => void)): void;
2976629784
addEventListener<K extends keyof SVGSVGElementEventMap>(type: K, listener: (this: SVGSVGElement, ev: SVGSVGElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
2976729785
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
2976829786
removeEventListener<K extends keyof SVGSVGElementEventMap>(type: K, listener: (this: SVGSVGElement, ev: SVGSVGElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;

‎inputfiles/overridingTypes.jsonc‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -421,6 +421,14 @@
421421
]
422422
}
423423
}
424+
},
425+
"addEventListener": {
426+
"mdnUrl": "https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener",
427+
"comment": "The addEventListener() method of the EventTarget interface sets up a function that will be called whenever the specified event is delivered to the target.",
428+
"overrideSignatures": [
429+
"addEventListener(type: string, listener: ((event: Event) => void) | ((event: UIEvent) => void)): void"
430+
]
431+
424432
}
425433
}
426434
}
@@ -1281,6 +1289,18 @@
12811289
"type": "any"
12821290
}
12831291
}
1292+
},
1293+
"methods": {
1294+
"method": {
1295+
"addEventListener": {
1296+
"mdnUrl": "https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener",
1297+
"comment": "The addEventListener() method of the EventTarget interface sets up a function that will be called whenever the specified event is delivered to the target.",
1298+
"overrideSignatures": [
1299+
"addEventListener(type: string, listener: ((event: Event) => void) | ((event: UIEvent) => void)): void"
1300+
]
1301+
1302+
}
1303+
}
12841304
}
12851305
},
12861306
"SVGSVGElement": {
@@ -1299,6 +1319,14 @@
12991319
"overrideType": "NodeListOf<SVGCircleElement | SVGEllipseElement | SVGImageElement | SVGLineElement | SVGPathElement | SVGPolygonElement | SVGPolylineElement | SVGRectElement | SVGTextElement | SVGUseElement>"
13001320
}
13011321
}
1322+
},
1323+
"addEventListener": {
1324+
"mdnUrl": "https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener",
1325+
"comment": "The addEventListener() method of the EventTarget interface sets up a function that will be called whenever the specified event is delivered to the target.",
1326+
"overrideSignatures": [
1327+
"addEventListener(type: string, listener: ((event: Event) => void) | ((event: UIEvent) => void)): void"
1328+
]
1329+
13021330
}
13031331
}
13041332
}

‎unittests/files/eventlistener.ts‎

Lines changed: 49 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,55 @@ document.addEventListener("arbitrary_invalid_event", (ev) => {
33
});
44

55
document.addEventListener("arbitrary_invalid_event", {
6-
handleEvent(ev) {
6+
handleEvent(ev) {
77
return ev.returnValue;
8+
},
9+
});
10+
const divElement: HTMLElement = document.createElement("div");
11+
12+
13+
divElement.addEventListener(
14+
"click",
15+
(event: Event) => {
16+
if (event) {
17+
return;
18+
}
19+
},
20+
false,
21+
);
22+
23+
divElement.addEventListener("click", (event: Event) => {
24+
if (event) {
25+
return;
26+
}
27+
});
28+
29+
divElement.addEventListener("beep", (event: UIEvent) => {
30+
if (event) {
31+
return;
32+
}
33+
});
34+
35+
const svgElement = document.createElementNS("http://www.w3.org/2000/svg", "svg");
36+
37+
svgElement.addEventListener(
38+
"click",
39+
(event: Event) => {
40+
if (event) {
41+
return;
42+
}
43+
},
44+
false,
45+
);
46+
47+
svgElement.addEventListener("click", (event: Event) => {
48+
if (event) {
49+
return;
50+
}
51+
});
52+
53+
svgElement.addEventListener("beep", (event: UIEvent) => {
54+
if (event) {
55+
return;
856
}
957
});

0 commit comments

Comments
 (0)