Skip to content

Commit bd92e81

Browse files
added overriding type to dom lib
1 parent a650695 commit bd92e81

File tree

8 files changed

+21
-8
lines changed

8 files changed

+21
-8
lines changed

baselines/dom.generated.d.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13142,7 +13142,7 @@ interface GlobalEventHandlers {
1314213142
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLMediaElement/ended_event) */
1314313143
onended: ((this: GlobalEventHandlers, ev: Event) => any) | null;
1314413144
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/error_event) */
13145-
onerror: OnErrorEventHandler;
13145+
onerror: DocumentOrGlobalOnErrorHandler;
1314613146
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/focus_event) */
1314713147
onfocus: ((this: GlobalEventHandlers, ev: FocusEvent) => any) | null;
1314813148
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLFormElement/formdata_event) */
@@ -39572,7 +39572,7 @@ declare var onemptied: ((this: Window, ev: Event) => any) | null;
3957239572
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLMediaElement/ended_event) */
3957339573
declare var onended: ((this: Window, ev: Event) => any) | null;
3957439574
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/error_event) */
39575-
declare var onerror: OnErrorEventHandler;
39575+
declare var onerror: DocumentOrGlobalOnErrorHandler;
3957639576
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/focus_event) */
3957739577
declare var onfocus: ((this: Window, ev: FocusEvent) => any) | null;
3957839578
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLFormElement/formdata_event) */
@@ -39849,6 +39849,7 @@ type ConstrainDouble = number | ConstrainDoubleRange;
3984939849
type ConstrainULong = number | ConstrainULongRange;
3985039850
type CookieList = CookieListItem[];
3985139851
type DOMHighResTimeStamp = number;
39852+
type DocumentOrGlobalOnErrorHandler = (((event: Event) => any) | ((event: UIEvent) => any) | OnErrorEventHandlerNonNull) | null;
3985239853
type EpochTimeStamp = number;
3985339854
type EventListenerOrEventListenerObject = EventListener | EventListenerObject;
3985439855
type FileSystemWriteChunkType = BufferSource | Blob | string | WriteParams;

baselines/ts5.5/dom.generated.d.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13131,7 +13131,7 @@ interface GlobalEventHandlers {
1313113131
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLMediaElement/ended_event) */
1313213132
onended: ((this: GlobalEventHandlers, ev: Event) => any) | null;
1313313133
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/error_event) */
13134-
onerror: OnErrorEventHandler;
13134+
onerror: DocumentOrGlobalOnErrorHandler;
1313513135
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/focus_event) */
1313613136
onfocus: ((this: GlobalEventHandlers, ev: FocusEvent) => any) | null;
1313713137
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLFormElement/formdata_event) */
@@ -39549,7 +39549,7 @@ declare var onemptied: ((this: Window, ev: Event) => any) | null;
3954939549
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLMediaElement/ended_event) */
3955039550
declare var onended: ((this: Window, ev: Event) => any) | null;
3955139551
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/error_event) */
39552-
declare var onerror: OnErrorEventHandler;
39552+
declare var onerror: DocumentOrGlobalOnErrorHandler;
3955339553
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/focus_event) */
3955439554
declare var onfocus: ((this: Window, ev: FocusEvent) => any) | null;
3955539555
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLFormElement/formdata_event) */
@@ -39826,6 +39826,7 @@ type ConstrainDouble = number | ConstrainDoubleRange;
3982639826
type ConstrainULong = number | ConstrainULongRange;
3982739827
type CookieList = CookieListItem[];
3982839828
type DOMHighResTimeStamp = number;
39829+
type DocumentOrGlobalOnErrorHandler = (((event: Event) => any) | ((event: UIEvent) => any) | OnErrorEventHandlerNonNull) | null;
3982939830
type EpochTimeStamp = number;
3983039831
type EventListenerOrEventListenerObject = EventListener | EventListenerObject;
3983139832
type FileSystemWriteChunkType = BufferSource | Blob | string | WriteParams;

baselines/ts5.6/dom.generated.d.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13142,7 +13142,7 @@ interface GlobalEventHandlers {
1314213142
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLMediaElement/ended_event) */
1314313143
onended: ((this: GlobalEventHandlers, ev: Event) => any) | null;
1314413144
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/error_event) */
13145-
onerror: OnErrorEventHandler;
13145+
onerror: DocumentOrGlobalOnErrorHandler;
1314613146
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/focus_event) */
1314713147
onfocus: ((this: GlobalEventHandlers, ev: FocusEvent) => any) | null;
1314813148
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLFormElement/formdata_event) */
@@ -39572,7 +39572,7 @@ declare var onemptied: ((this: Window, ev: Event) => any) | null;
3957239572
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLMediaElement/ended_event) */
3957339573
declare var onended: ((this: Window, ev: Event) => any) | null;
3957439574
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/error_event) */
39575-
declare var onerror: OnErrorEventHandler;
39575+
declare var onerror: DocumentOrGlobalOnErrorHandler;
3957639576
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/focus_event) */
3957739577
declare var onfocus: ((this: Window, ev: FocusEvent) => any) | null;
3957839578
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLFormElement/formdata_event) */
@@ -39849,6 +39849,7 @@ type ConstrainDouble = number | ConstrainDoubleRange;
3984939849
type ConstrainULong = number | ConstrainULongRange;
3985039850
type CookieList = CookieListItem[];
3985139851
type DOMHighResTimeStamp = number;
39852+
type DocumentOrGlobalOnErrorHandler = (((event: Event) => any) | ((event: UIEvent) => any) | OnErrorEventHandlerNonNull) | null;
3985239853
type EpochTimeStamp = number;
3985339854
type EventListenerOrEventListenerObject = EventListener | EventListenerObject;
3985439855
type FileSystemWriteChunkType = BufferSource | Blob | string | WriteParams;

inputfiles/addedTypes.jsonc

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1216,6 +1216,12 @@
12161216
// Full spec at https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#autofill.
12171217
"name": "AutoFill",
12181218
"overrideType": "AutoFillBase | `${OptionalPrefixToken<AutoFillSection>}${OptionalPrefixToken<AutoFillAddressKind>}${AutoFillField}${OptionalPostfixToken<AutoFillCredentialField>}`"
1219+
},
1220+
{
1221+
"name": "DocumentOrGlobalOnErrorHandler",
1222+
"nullable": true,
1223+
"overrideType": "((event: Event) => any) | ((event: UIEvent) => any) | OnErrorEventHandlerNonNull",
1224+
"exposed": "Window"
12191225
}
12201226
]
12211227
}

inputfiles/knownTypes.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
"CompositeOperationOrAuto",
2222
"ComputedKeyframe",
2323
"DisplayCaptureSurfaceType",
24+
"DocumentOrGlobalOnErrorHandler",
2425
"EcdhKeyDeriveParams",
2526
"EcdsaParams",
2627
"EcKeyAlgorithm",

inputfiles/patches/events.kdl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ interface-mixin GlobalEventHandlers {
7474
event transitionstart type=TransitionEvent
7575
event transitionend type=TransitionEvent
7676
event transitioncancel type=TransitionEvent
77-
property onerror overrideType=OnErrorEventHandler
77+
property onerror overrideType=DocumentOrGlobalOnErrorHandler
7878
}
7979

8080
interface-mixin MessageEventTarget {

src/build/expose.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,9 @@ export function getExposedTypes(
8888

8989
if (webidl.typedefs) {
9090
const referenced = webidl.typedefs.typedef.filter(
91-
(t) => knownIDLTypes.has(t.name) || forceKnownTypesLogged.has(t.name),
91+
(t) =>
92+
(knownIDLTypes.has(t.name) || forceKnownTypesLogged.has(t.name)) &&
93+
exposesTo(t, target),
9294
);
9395
const { exposed, removed } = filterTypedefs(referenced, unexposedTypes);
9496
removed.forEach((s) => unexposedTypes.add(s));

src/build/types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,7 @@ export interface TypeDef extends Typed {
227227
deprecated?: boolean;
228228
legacyNamespace?: string;
229229
typeParameters?: TypeParameter[];
230+
exposed?: string;
230231
}
231232

232233
export interface Dictionary {

0 commit comments

Comments
 (0)