Tighten the linter

Author: orta

docs/typescriptlang/id/index.ts

@@ -1,6 +1,6 @@
 export const indexCopy = {
   index_headline: "<bold>JavaScript dengan Tipe dalam skala apapun.</bold>",
-  index_byline: `TypeScript ${""}}memperluas JavaScript dengan menambahkan tipe.`,
+  index_byline: "TypeScript memperluas JavaScript dengan menambahkan tipe.",
   index_summary:
     "Dengan memahami JavaScript, TypeScript menghemat waktu Anda dalam menangkap galat dan memberikan perbaikan sebelum Anda menjalankan kode.",
   index_locations:

docs/typescriptlang/pl/index.ts

@@ -1,5 +1,5 @@
 export const indexCopy = {
-  index_headline: `<bold>${""}}Typowany JavaScript w każdej skali.</bold>`,
+  index_headline: "<bold>Typowany JavaScript w każdej skali.</bold>",
   index_byline: "TypeScript rozszerza JavaScript poprzez dodatek typów.",
   index_summary:
     "TypeScript rozumie JavaScript, przez co oszczędzaj Twój czas wyłapując błędy i dostarczając rozwiązania problemów zanim uruchomisz kod.",

docs/typescriptlang/zh/community.ts

@@ -20,9 +20,5 @@ export const comCopy = {
   com_online_typed_available_for: "可用的通用库和框架",
   com_person: "亲身参与",
   com_conferences: "会议",
-  com_conferences_alt_img: "标识",
-  nav_: {
-    id: "foo",
-    defaultMessage: "foo",
-  },
+  com_conferences_alt_img: "标识"
 }

scripts/lint.js

@@ -13,7 +13,7 @@
 const chalk = require("chalk");
 const { readFileSync, watch } = require("fs");
 const { join, basename, sep, dirname } = require("path");
-const readline = require('readline')
+const readline = require("readline");
 
 const ts = require("typescript");
 const remark = require("remark");
@@ -32,19 +32,19 @@ const filterString = process.argv[2] ? process.argv[2] : "";
 
 if (filterString === "--watch") {
   const clear = () => {
-    const blank = '\n'.repeat(process.stdout.rows)
-    console.log(blank)
-    readline.cursorTo(process.stdout, 0, 0)
-    readline.clearScreenDown(process.stdout)
-  }
+    const blank = "\n".repeat(process.stdout.rows);
+    console.log(blank);
+    readline.cursorTo(process.stdout, 0, 0);
+    readline.clearScreenDown(process.stdout);
+  };
 
   if (process.platform === "linux") throw new Error("Sorry linux peeps, the node watcher doesn't support linux.");
   watch(join(__dirname, "..", "docs"), { recursive: true }, (_, filename) => {
-    clear()
-    process.stdout.write("♲ ")
+    clear();
+    process.stdout.write("♲ ");
     validateAtPaths([join(docsPath, filename)]);
   });
-  clear()
+  clear();
   console.log(`${chalk.bold("Started the watcher")}, pressing save on a file in ./docs will lint that file.`);
 } else {
   const toValidate = docs
@@ -170,96 +170,100 @@ function lintTSLanguageFile(file) {
     ts.ScriptKind.TS
   );
 
-  
-  const filename = basename(file, ".ts")
-  const lastDir = dirname(file).split(sep).pop()
+  const filename = basename(file, ".ts");
+  const lastDir = dirname(file).split(sep).pop();
 
-  const isRootImport = filename === lastDir
+  const isRootImport = filename === lastDir;
   if (isRootImport) {
     // This is the import for the language which pulls in all the existing messages
     //
-    const notImportStatements = sourceFile.statements.filter(f => f.kind !== 261)
+    const notImportStatements = sourceFile.statements.filter((f) => f.kind !== 261);
     const lastStatementIsDeclaration = sourceFile.statements[0].kind !== 232;
-    const onlyImportsAndOneExport = lastStatementIsDeclaration && notImportStatements.length === 1
-    
+    const onlyImportsAndOneExport = lastStatementIsDeclaration && notImportStatements.length === 1;
+
     if (!onlyImportsAndOneExport) {
-      errors.push( new Error("A root language import can only include imports and an export called 'lang' "));
+      errors.push(new Error("A root language import can only include imports and an export called 'lang' "));
     }
 
     if (lastStatementIsDeclaration) {
       /** @type {import("typescript").VariableDeclarationList} */
       // @ts-ignore
-      const declarationList = notImportStatements[0].declarationList
+      const declarationList = notImportStatements[0].declarationList;
 
-      const declaration = declarationList.declarations[0]
-      if (!declaration.initializer) errors.push( new Error(`Something is off with the export in this file`));
+      const declaration = declarationList.declarations[0];
+      if (!declaration.initializer) errors.push(new Error(`Something is off with the export in this file`));
 
       /** @type {import("typescript").CallExpression} */
       // @ts-ignore
-      const callExpression = declaration.initializer.expression
-      if (callExpression.getText(sourceFile) !== "defineMessages") errors.push( new Error(`The export needs to call define messages`));
-      
+      const callExpression = declaration.initializer.expression;
+      if (callExpression.getText(sourceFile) !== "defineMessages")
+        errors.push(new Error(`The export needs to call define messages`));
+
       /** @type {import("typescript").ObjectLiteralExpression} */
       // @ts-ignore
-      const arg0 = declaration.initializer.arguments[0]
-      arg0.properties.forEach(p => {
-        if (p.kind !== 290) errors.push( new Error(`You can only have spreads (...) in the export`));
-      })
+      const arg0 = declaration.initializer.arguments[0];
+      arg0.properties.forEach((p) => {
+        if (p.kind !== 290) errors.push(new Error(`You can only have spreads (...) in the export`));
+      });
     }
 
-    sourceFile.statements.forEach(s => {
-      if (!ts.isImportDeclaration(s)) return
-      if (!s.importClause) errors.push( new Error(`The import ${s.moduleSpecifier.getText(sourceFile)} is not importing an object`));
-      
-      const allowed = ['"react-intl"']
-      const specifier = s.moduleSpecifier.getText(sourceFile)
+    sourceFile.statements.forEach((s) => {
+      if (!ts.isImportDeclaration(s)) return;
+      if (!s.importClause)
+        errors.push(new Error(`The import ${s.moduleSpecifier.getText(sourceFile)} is not importing an object`));
+
+      const allowed = ['"react-intl"'];
+      const specifier = s.moduleSpecifier.getText(sourceFile);
 
       if (!allowed.includes(specifier) && !specifier.startsWith('".')) {
-        errors.push( new Error(`The import ${specifier} is not allowlisted ([${allowed.join(", ")}]) nor relative`));
+        errors.push(new Error(`The import ${specifier} is not allowlisted ([${allowed.join(", ")}]) nor relative`));
       }
-    })
+    });
 
   } else {
     // This should just be a simple lint that it only has a declaration
     const tooManyStatements = sourceFile.statements.length > 1;
     const notDeclarationList = sourceFile.statements.length > 0 && sourceFile.statements[0].kind !== 232;
-  
+
     if (tooManyStatements) {
-      errors.push( new Error("TS files had more than one statement (e.g. more than `export const somethingCopy = { ... }` "));
+      errors.push(
+        new Error("TS files had more than one statement (e.g. more than `export const somethingCopy = { ... }` ")
+      );
     }
-  
+
     if (notDeclarationList) {
-      errors.push(new Error("TS files should only look like: `export const somethingCopy = { ... }` "))
+      errors.push(new Error("TS files should only look like: `export const somethingCopy = { ... }` "));
     }
-  // @ts-ignore
-    const lastStatement = sourceFile.statements[0].declarationList
-    if (!ts.isVariableDeclarationList(lastStatement))  {
-      errors.push(new Error("TS files should only look like: `export const somethingCopy = { ... }` "))
-    } else {
-      /** @type {import("typescript").ObjectLiteralExpression} */
+    
+    // @ts-ignore
+    if (sourceFile.statements[0] && sourceFile.statements[0].declarationList) {
       // @ts-ignore
-      const init = lastStatement.declarations[0].initializer
-      if (!init) {
-        errors.push(new Error("Something is off in the const in that file"))
+      const lastStatement = sourceFile.statements[0].declarationList;
+      if (!ts.isVariableDeclarationList(lastStatement)) {
+        errors.push(new Error("TS files should only look like: `export const somethingCopy = { ... }` "));
       } else {
-        init.properties.forEach(prop => {
-          /** @type {import("typescript").PropertyAssignment} */
-          // @ts-ignore
-          const init = prop.initializer 
-          if (init.kind !== 10 && init.kind !== 14) {
-            if (init.kind === 218) {
-              errors.push(new Error(`The template string at ${prop.name.getText(sourceFile)} can't have evaluated code ( no \${} allowed )`))
-            } else {
-              errors.push(new Error(`The value at ${prop.name.getText(sourceFile)} isn't a string`))
+        /** @type {import("typescript").ObjectLiteralExpression} */
+        // @ts-ignore
+        const init = lastStatement.declarations[0].initializer;
+        if (!init) {
+          errors.push(new Error("Something is off in the const in that file"));
+        } else {
+          init.properties.forEach((prop) => {
+            /** @type {import("typescript").PropertyAssignment} */
+            // @ts-ignore
+            const init = prop.initializer;
+            if (init.kind !== 10 && init.kind !== 14) {
+              if (init.kind === 218) {
+                errors.push(new Error(`The template string at ${prop.name.getText(sourceFile)} can't have evaluated code ( no \${} allowed )`));
+              } else {
+                errors.push(new Error(`The value at ${prop.name.getText(sourceFile)} isn't a string`));
+              }
             }
-          }
-        });
+          });
+        }
       }
-      // declarationList.declarations[0]
     }
   }
 
-
   return errors.map((e) => ({ path: file, error: e }));
-
 }