Allow to define valid static fields with names conflicting with builtin properties (#54198)

Author: Andarist

src/compiler/checker.ts

@@ -38334,6 +38334,10 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                     case "length":
                     case "caller":
                     case "arguments":
+                        if (compilerOptions.useDefineForClassFields) {
+                            break;
+                        }
+                        // fall through
                     case "prototype":
                         const message = Diagnostics.Static_property_0_conflicts_with_built_in_property_Function_0_of_constructor_function_1;
                         const className = getNameOfSymbolAsWritten(getSymbolOfDeclaration(node));

…e/staticPropertyNameConflicts.errors.txt …sedefineforclassfields=false).errors.txttests/baselines/reference/staticPropertyNameConflicts.errors.txt renamed to tests/baselines/reference/staticPropertyNameConflicts(usedefineforclassfields=false).errors.txt tests/baselines/reference/staticPropertyNameConflicts.errors.txt renamed to tests/baselines/reference/staticPropertyNameConflicts(usedefineforclassfields=false).errors.txt

@@ -44,44 +44,44 @@ tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameCon
 ==== tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameConflicts.ts (41 errors) ====
     // name
     class StaticName {
-        static name: number; // error
+        static name: number; // error without useDefineForClassFields
                ~~~~
 !!! error TS2699: Static property 'name' conflicts with built-in property 'Function.name' of constructor function 'StaticName'.
         name: string; // ok
     }
 
     class StaticNameFn {
-        static name() {} // error
+        static name() {} // error without useDefineForClassFields
                ~~~~
 !!! error TS2699: Static property 'name' conflicts with built-in property 'Function.name' of constructor function 'StaticNameFn'.
         name() {} // ok
     }
 
     // length
     class StaticLength {
-        static length: number; // error
+        static length: number; // error without useDefineForClassFields
                ~~~~~~
 !!! error TS2699: Static property 'length' conflicts with built-in property 'Function.length' of constructor function 'StaticLength'.
         length: string; // ok
     }
 
     class StaticLengthFn {
-        static length() {} // error
+        static length() {} // error without useDefineForClassFields
                ~~~~~~
 !!! error TS2699: Static property 'length' conflicts with built-in property 'Function.length' of constructor function 'StaticLengthFn'.
         length() {} // ok
     }
 
     // prototype
     class StaticPrototype {
-        static prototype: number; // error
+        static prototype: number; // always an error
                ~~~~~~~~~
 !!! error TS2699: Static property 'prototype' conflicts with built-in property 'Function.prototype' of constructor function 'StaticPrototype'.
         prototype: string; // ok
     }
 
     class StaticPrototypeFn {
-        static prototype() {} // error
+        static prototype() {} // always an error
                ~~~~~~~~~
 !!! error TS2300: Duplicate identifier 'prototype'.
                ~~~~~~~~~
@@ -91,29 +91,29 @@ tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameCon
 
     // caller
     class StaticCaller {
-        static caller: number; // error
+        static caller: number; // error without useDefineForClassFields
                ~~~~~~
 !!! error TS2699: Static property 'caller' conflicts with built-in property 'Function.caller' of constructor function 'StaticCaller'.
         caller: string; // ok
     }
 
     class StaticCallerFn {
-        static caller() {} // error
+        static caller() {} // error without useDefineForClassFields
                ~~~~~~
 !!! error TS2699: Static property 'caller' conflicts with built-in property 'Function.caller' of constructor function 'StaticCallerFn'.
         caller() {} // ok
     }
 
     // arguments
     class StaticArguments {
-        static arguments: number; // error
+        static arguments: number; // error without useDefineForClassFields
                ~~~~~~~~~
 !!! error TS2699: Static property 'arguments' conflicts with built-in property 'Function.arguments' of constructor function 'StaticArguments'.
         arguments: string; // ok
     }
 
     class StaticArgumentsFn {
-        static arguments() {} // error
+        static arguments() {} // error without useDefineForClassFields
                ~~~~~~~~~
 !!! error TS2699: Static property 'arguments' conflicts with built-in property 'Function.arguments' of constructor function 'StaticArgumentsFn'.
         arguments() {} // ok
@@ -125,44 +125,44 @@ tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameCon
 
     // name
     var StaticName_Anonymous = class {
-        static name: number; // error
+        static name: number; // error without useDefineForClassFields
                ~~~~
 !!! error TS2699: Static property 'name' conflicts with built-in property 'Function.name' of constructor function 'StaticName_Anonymous'.
         name: string; // ok
     }
 
     var StaticNameFn_Anonymous = class {
-        static name() {} // error
+        static name() {} // error without useDefineForClassFields
                ~~~~
 !!! error TS2699: Static property 'name' conflicts with built-in property 'Function.name' of constructor function 'StaticNameFn_Anonymous'.
         name() {} // ok
     }
 
     // length
     var StaticLength_Anonymous = class {
-        static length: number; // error
+        static length: number; // error without useDefineForClassFields
                ~~~~~~
 !!! error TS2699: Static property 'length' conflicts with built-in property 'Function.length' of constructor function 'StaticLength_Anonymous'.
         length: string; // ok
     }
 
     var StaticLengthFn_Anonymous = class {
-        static length() {} // error
+        static length() {} // error without useDefineForClassFields
                ~~~~~~
 !!! error TS2699: Static property 'length' conflicts with built-in property 'Function.length' of constructor function 'StaticLengthFn_Anonymous'.
         length() {} // ok
     }
 
     // prototype
     var StaticPrototype_Anonymous = class {
-        static prototype: number; // error
+        static prototype: number; // always an error
                ~~~~~~~~~
 !!! error TS2699: Static property 'prototype' conflicts with built-in property 'Function.prototype' of constructor function 'StaticPrototype_Anonymous'.
         prototype: string; // ok
     }
 
     var StaticPrototypeFn_Anonymous = class {
-        static prototype() {} // error
+        static prototype() {} // always an error
                ~~~~~~~~~
 !!! error TS2300: Duplicate identifier 'prototype'.
                ~~~~~~~~~
@@ -172,29 +172,29 @@ tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameCon
 
     // caller
     var StaticCaller_Anonymous = class {
-        static caller: number; // error
+        static caller: number; // error without useDefineForClassFields
                ~~~~~~
 !!! error TS2699: Static property 'caller' conflicts with built-in property 'Function.caller' of constructor function 'StaticCaller_Anonymous'.
         caller: string; // ok
     }
 
     var StaticCallerFn_Anonymous = class {
-        static caller() {} // error
+        static caller() {} // error without useDefineForClassFields
                ~~~~~~
 !!! error TS2699: Static property 'caller' conflicts with built-in property 'Function.caller' of constructor function 'StaticCallerFn_Anonymous'.
         caller() {} // ok
     }
 
     // arguments
     var StaticArguments_Anonymous = class {
-        static arguments: number; // error
+        static arguments: number; // error without useDefineForClassFields
                ~~~~~~~~~
 !!! error TS2699: Static property 'arguments' conflicts with built-in property 'Function.arguments' of constructor function 'StaticArguments_Anonymous'.
         arguments: string; // ok
     }
 
     var StaticArgumentsFn_Anonymous = class {
-        static arguments() {} // error
+        static arguments() {} // error without useDefineForClassFields
                ~~~~~~~~~
 !!! error TS2699: Static property 'arguments' conflicts with built-in property 'Function.arguments' of constructor function 'StaticArgumentsFn_Anonymous'.
         arguments() {} // ok
@@ -206,7 +206,7 @@ tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameCon
     // name
     module TestOnDefaultExportedClass_1 {
         class StaticName {
-            static name: number; // error
+            static name: number; // error without useDefineForClassFields
                    ~~~~
 !!! error TS2699: Static property 'name' conflicts with built-in property 'Function.name' of constructor function 'StaticName'.
             name: string; // ok
@@ -215,7 +215,7 @@ tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameCon
 
     module TestOnDefaultExportedClass_2 {
         class StaticNameFn {
-            static name() {} // error
+            static name() {} // error without useDefineForClassFields
                    ~~~~
 !!! error TS2699: Static property 'name' conflicts with built-in property 'Function.name' of constructor function 'StaticNameFn'.
             name() {} // ok
@@ -227,7 +227,7 @@ tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameCon
         export default class StaticLength {
                ~~~~~~~
 !!! error TS1319: A default export can only be used in an ECMAScript-style module.
-            static length: number; // error
+            static length: number; // error without useDefineForClassFields
                    ~~~~~~
 !!! error TS2699: Static property 'length' conflicts with built-in property 'Function.length' of constructor function 'StaticLength'.
             length: string; // ok
@@ -238,19 +238,19 @@ tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameCon
         export default class StaticLengthFn {
                ~~~~~~~
 !!! error TS1319: A default export can only be used in an ECMAScript-style module.
-            static length() {} // error
+            static length() {} // error without useDefineForClassFields
                    ~~~~~~
 !!! error TS2699: Static property 'length' conflicts with built-in property 'Function.length' of constructor function 'StaticLengthFn'.
             length() {} // ok
         }
     }
 
     // prototype
-    module TestOnDefaultExportedClass_5 {    
+    module TestOnDefaultExportedClass_5 {
         export default class StaticPrototype {
                ~~~~~~~
 !!! error TS1319: A default export can only be used in an ECMAScript-style module.
-            static prototype: number; // error
+            static prototype: number; // always an error
                    ~~~~~~~~~
 !!! error TS2699: Static property 'prototype' conflicts with built-in property 'Function.prototype' of constructor function 'StaticPrototype'.
             prototype: string; // ok
@@ -261,7 +261,7 @@ tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameCon
         export default class StaticPrototypeFn {
                ~~~~~~~
 !!! error TS1319: A default export can only be used in an ECMAScript-style module.
-            static prototype() {} // error
+            static prototype() {} // always an error
                    ~~~~~~~~~
 !!! error TS2300: Duplicate identifier 'prototype'.
                    ~~~~~~~~~
@@ -275,7 +275,7 @@ tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameCon
         export default class StaticCaller {
                ~~~~~~~
 !!! error TS1319: A default export can only be used in an ECMAScript-style module.
-            static caller: number; // error
+            static caller: number; // error without useDefineForClassFields
                    ~~~~~~
 !!! error TS2699: Static property 'caller' conflicts with built-in property 'Function.caller' of constructor function 'StaticCaller'.
             caller: string; // ok
@@ -286,7 +286,7 @@ tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameCon
         export default class StaticCallerFn {
                ~~~~~~~
 !!! error TS1319: A default export can only be used in an ECMAScript-style module.
-            static caller() {} // error
+            static caller() {} // error without useDefineForClassFields
                    ~~~~~~
 !!! error TS2699: Static property 'caller' conflicts with built-in property 'Function.caller' of constructor function 'StaticCallerFn'.
             caller() {} // ok
@@ -298,7 +298,7 @@ tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameCon
         export default class StaticArguments {
                ~~~~~~~
 !!! error TS1319: A default export can only be used in an ECMAScript-style module.
-            static arguments: number; // error
+            static arguments: number; // error without useDefineForClassFields
                    ~~~~~~~~~
 !!! error TS2699: Static property 'arguments' conflicts with built-in property 'Function.arguments' of constructor function 'StaticArguments'.
             arguments: string; // ok
@@ -309,9 +309,10 @@ tests/cases/conformance/classes/propertyMemberDeclarations/staticPropertyNameCon
         export default class StaticArgumentsFn {
                ~~~~~~~
 !!! error TS1319: A default export can only be used in an ECMAScript-style module.
-            static arguments() {} // error
+            static arguments() {} // error without useDefineForClassFields
                    ~~~~~~~~~
 !!! error TS2699: Static property 'arguments' conflicts with built-in property 'Function.arguments' of constructor function 'StaticArgumentsFn'.
             arguments() {} // ok
         }
-    }
+    }
+