tweak fix

Andarist · Andarist · commit 170d9fd109ef · 2024-12-19T18:49:52.000+01:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -6267,7 +6267,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                     return true;
                 }
                 if (requiresAddingUndefined && annotationType) {
-                    annotationType = getOptionalType(annotationType, !isParameter(node));
+                    annotationType = addOptionality(annotationType, !isParameter(node));
                 }
                 return !!annotationType && typeNodeIsEquivalentToType(node, type, annotationType) && existingTypeNodeIsNotReferenceOrIsReferenceWithCompatibleTypeArgumentCount(existing, type);
             },
diff --git a/src/compiler/expressionToTypeNode.ts b/src/compiler/expressionToTypeNode.ts
@@ -814,7 +814,7 @@ export function createSyntacticTypeNodeBuilder(
     }
     function typeFromProperty(node: PropertyDeclaration | PropertySignature | JSDocPropertyTag, symbol: Symbol, context: SyntacticTypeNodeBuilderContext) {
         const declaredType = getEffectiveTypeAnnotationNode(node);
-        const requiresAddingUndefined = strictNullChecks && resolver.requiresAddingImplicitUndefined(node, symbol, context.enclosingDeclaration);
+        const requiresAddingUndefined = resolver.requiresAddingImplicitUndefined(node, symbol, context.enclosingDeclaration);
         let resultType = failed;
         if (declaredType) {
             resultType = syntacticResult(serializeTypeAnnotationOfDeclaration(declaredType, context, node, symbol, requiresAddingUndefined));

Original file line number	Diff line number	Diff line change
`@@ -6267,7 +6267,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {`
`6267`	`6267`	`return true;`
`6268`	`6268`	`}`
`6269`	`6269`	`if (requiresAddingUndefined && annotationType) {`
`6270`		`- annotationType = getOptionalType(annotationType, !isParameter(node));`
	`6270`	`+ annotationType = addOptionality(annotationType, !isParameter(node));`
`6271`	`6271`	`}`
`6272`	`6272`	`return !!annotationType && typeNodeIsEquivalentToType(node, type, annotationType) && existingTypeNodeIsNotReferenceOrIsReferenceWithCompatibleTypeArgumentCount(existing, type);`
`6273`	`6273`	`},`
Original file line number	Diff line number	Diff line change
`@@ -814,7 +814,7 @@ export function createSyntacticTypeNodeBuilder(`
`814`	`814`	`}`
`815`	`815`	`function typeFromProperty(node: PropertyDeclaration \| PropertySignature \| JSDocPropertyTag, symbol: Symbol, context: SyntacticTypeNodeBuilderContext) {`
`816`	`816`	`const declaredType = getEffectiveTypeAnnotationNode(node);`
`817`		`- const requiresAddingUndefined = strictNullChecks && resolver.requiresAddingImplicitUndefined(node, symbol, context.enclosingDeclaration);`
	`817`	`+ const requiresAddingUndefined = resolver.requiresAddingImplicitUndefined(node, symbol, context.enclosingDeclaration);`
`818`	`818`	`let resultType = failed;`
`819`	`819`	`if (declaredType) {`
`820`	`820`	`resultType = syntacticResult(serializeTypeAnnotationOfDeclaration(declaredType, context, node, symbol, requiresAddingUndefined));`