Merge remote-tracking branch 'origin/main' into fix/for-of-iteration-optional-tuple-members

Author: Andarist

.c8rc.json

@@ -1,7 +1,7 @@
 {
-    "reporter": ["lcovonly", "cobertura"],
+    "reporter": ["lcovonly", "cobertura", "v8", "v8-json", "codecov"],
     "src": "src",
     "include": ["src/**", "built/local/**"],
     "exclude": ["**/node_modules/**"],
     "mergeAsync": true
-}
+}

.devcontainer/Dockerfile

@@ -1,11 +1,26 @@
+// For format details, see https://aka.ms/devcontainer.json. For config options, see the
+// README at: https://github.com/devcontainers/templates/tree/main/src/javascript-node
 {
     "name": "Node.js",
-    "build": {
-        "dockerfile": "Dockerfile",
-        "args": {
-            "VARIANT": "18"
-        }
+    // Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
+    "image": "mcr.microsoft.com/devcontainers/javascript-node:1-22-bookworm",
+
+    // Features to add to the dev container. More info: https://containers.dev/features.
+    "features": {
+        "ghcr.io/devcontainers/features/go:1": {}
+    },
+
+    // Use 'forwardPorts' to make a list of ports inside the container available locally.
+    // "forwardPorts": [],
+
+    // Use 'postCreateCommand' to run commands after the container is created.
+    "postCreateCommand": {
+        "Configure Build Tools": "sudo corepack enable npm; sudo npm install -g hereby; npm ci",
+        "Install pprof": "go install github.com/google/pprof@latest",
+        "Install Graphviz": "sudo apt install graphviz"
     },
+
+    // Configure tool-specific properties.
     "customizations": {
         "vscode": {
             "settings": {
@@ -23,5 +38,7 @@
             ]
         }
     },
+
+    // More info: https://aka.ms/dev-containers-non-root.
     "remoteUser": "node"
 }

.devcontainer/devcontainer.json

@@ -1,4 +1,5 @@
 {
+    // If updating this, also update the config in dtsBundler.mjs.
     "indentWidth": 4,
     "lineWidth": 1000,
     "newLineKind": "auto",
@@ -19,26 +20,25 @@
         "arrowFunction.useParentheses": "preferNone",
         "conditionalExpression.linePerExpression": false, // Keep our "match/case"-ish conditionals.
         "functionExpression.spaceAfterFunctionKeyword": true,
-        "importDeclaration.forceMultiLine": true,
+        "importDeclaration.forceMultiLine": "whenMultiple",
         "constructorType.spaceAfterNewKeyword": true,
         "constructSignature.spaceAfterNewKeyword": true,
 
-        // Let eslint-plugin-simple-import-sort handle this.
-        "module.sortImportDeclarations": "maintain",
-        "module.sortExportDeclarations": "maintain",
-        "exportDeclaration.sortNamedExports": "maintain",
-        "importDeclaration.sortNamedImports": "maintain"
+        "module.sortImportDeclarations": "caseInsensitive",
+        "module.sortExportDeclarations": "caseInsensitive",
+        "exportDeclaration.sortNamedExports": "caseInsensitive",
+        "importDeclaration.sortNamedImports": "caseInsensitive"
     },
-    "prettier": {
-        "associations": [
-            "**/*.{yaml,yml}"
-        ],
-        "yml.tabWidth": 2,
-        "yaml.tabWidth": 2,
-        "yml.singleQuote": true,
-        "yaml.singleQuote": true
+    "yaml": {
+        "indentWidth": 2,
+        "quotes": "preferSingle"
+    },
+    "json": {
+        // This would be good to do in known-JSONC files, but VS Code warns on trailing commas.
+        "trailingCommas": "never"
     },
     "excludes": [
+        "**/.git",
         "**/node_modules",
         "**/*-lock.json",
         "coverage/**",
@@ -47,10 +47,14 @@
         "tests/**",
         "internal/**",
         "**/*.generated.*",
-        "scripts/*.d.*"
+        "scripts/*.d.*",
+        "**/_namespaces/**"
     ],
+    // Note: if adding new languages, make sure settings.template.json is updated too.
+    // Also, if updating typescript, update the one in package.json.
     "plugins": [
-        "https://plugins.dprint.dev/typescript-0.86.1.wasm",
-        "https://plugins.dprint.dev/prettier-0.27.0.json@3557a62b4507c55a47d8cde0683195b14d13c41dda66d0f0b0e111aed107e2fe"
+        "https://plugins.dprint.dev/typescript-0.93.4.wasm",
+        "https://plugins.dprint.dev/json-0.19.4.wasm",
+        "https://plugins.dprint.dev/g-plane/pretty_yaml-v0.5.0.wasm"
     ]
 }

.dprint.jsonc

@@ -3,7 +3,10 @@ description: 'Create a report to help us improve TypeScript'
 body:
   - type: markdown
     attributes:
-      value: Please fill in each section completely. Thank you!
+      value: |
+        🔍 Please [search thoroughly in GitHub](https://github.com/Microsoft/TypeScript/search?type=Issues) or by the query `site:github.com/microsoft/TypeScript <your keywords>` in your favorite search engine before reporting a new bug as most bugs are very likely to find precedents.
+
+        Please fill in each section completely. Thank you!
   - type: textarea
     id: search_terms
     attributes:
@@ -13,8 +16,7 @@ body:
 
         List them here so people in the future can find this one more easily.
       placeholder: |
-        List of keywords you searched for before creating this issue.
-        Write them down here so that others can find this bug more easily and help provide feedback.
+        List of keywords you searched for before creating this issue. Write them down here so that others can find this bug more easily and help provide feedback.
 
         e.g. "function inference any", "jsx attribute spread", "move to file duplicate imports", "discriminated union inference", "ts2822"
     validations:
@@ -26,21 +28,18 @@ body:
       description: |
         When did you start seeing this bug occur?
 
-        "Bugs" that have existed in TS for a long time are very likely to be FAQs; refer to
-        https://github.com/Microsoft/TypeScript/wiki/FAQ#common-bugs-that-arent-bugs
-
-
-        If possible, please try testing the nightly version of TS to see if it's already been fixed. For npm: `typescript@next`
+        "Bugs" that have existed in TS for a long time are very likely to be FAQs; please refer to the [FAQ wiki page](https://github.com/Microsoft/TypeScript/wiki/FAQ#common-bugs-that-arent-bugs).
 
-        This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
+        Please try the nightly version of TS to see if it's already been fixed. Install `typescript@next` or use the [Playground](http://www.typescriptlang.org/play/?ts=Nightly).
 
+        If possible, try bisecting the issue using [every-ts](https://www.npmjs.com/package/every-ts#bisecting), which should narrow down the problem to a specific change.
 
-        Note: The TypeScript Playground can be used to try older versions of TypeScript.
+        The Playground also supports versions of TypeScript back to TypeScript 3.3.
 
         Please keep and fill in the line that best applies.
       value: |
-        - This is a crash
         - This changed between versions ______ and _______
+        - This changed in commit or PR _______
         - This is the behavior in every version I tried, and I reviewed the FAQ for entries about _________
         - I was unable to test this on prior versions because _______
     validations:
@@ -54,7 +53,6 @@ body:
 
         This should have the same code as the code snippet below, and use whichever settings are relevant to your report.
 
-
         As a last resort, you can link to a repo, but these will be slower for us to investigate.
       placeholder: 'Playground link with relevant code: https://www.typescriptlang.org/play?#code/PTAEFkE9QYwewCYFNQHM5IM6gBZIE5JA'
     validations:
@@ -65,6 +63,7 @@ body:
       label: 💻 Code
       description: |
         Please post the relevant code sample here as well.
+
         This code and the Playground code should be the same, do not use separate examples.
 
         We can quickly address your report if:
@@ -74,6 +73,7 @@ body:
           - The incorrectness of the behavior is readily apparent from reading the sample.
 
         Reports are slower to investigate if:
+
           - We have to pare too much extraneous code.
           - We have to clone a large repo and validate that the problem isn't elsewhere.
           - The sample is confusing or doesn't clearly demonstrate what's wrong.