fix(54085): Cannot navigate down object hierarchy if an interface is not directly implemented (#54108)

Author: a-tarasyuk

src/services/findAllReferences.ts

@@ -198,6 +198,7 @@ import {
     nodeSeenTracker,
     NumericLiteral,
     ObjectLiteralExpression,
+    or,
     ParameterDeclaration,
     ParenthesizedExpression,
     Path,
@@ -2177,9 +2178,9 @@ export namespace Core {
         }
 
         // Check if the node is within an extends or implements clause
-        const containingClass = getContainingClassIfInHeritageClause(refNode);
-        if (containingClass) {
-            addReference(containingClass);
+        const containingNode = getContainingNodeIfInHeritageClause(refNode);
+        if (containingNode) {
+            addReference(containingNode);
             return;
         }
 
@@ -2212,9 +2213,9 @@ export namespace Core {
         }
     }
 
-    function getContainingClassIfInHeritageClause(node: Node): ClassLikeDeclaration | InterfaceDeclaration | undefined {
-        return isIdentifier(node) || isPropertyAccessExpression(node) ? getContainingClassIfInHeritageClause(node.parent)
-            : isExpressionWithTypeArguments(node) ? tryCast(node.parent.parent, isClassLike) : undefined;
+    function getContainingNodeIfInHeritageClause(node: Node): ClassLikeDeclaration | InterfaceDeclaration | undefined {
+        return isIdentifier(node) || isPropertyAccessExpression(node) ? getContainingNodeIfInHeritageClause(node.parent)
+            : isExpressionWithTypeArguments(node) ? tryCast(node.parent.parent, or(isClassLike, isInterfaceDeclaration)) : undefined;
     }
 
     /**

tests/baselines/reference/goToImplementationInterface_00.baseline.jsonc

@@ -4,26 +4,44 @@
 //     hello: () => void
 // }
 // 
-// interface Baz extends Foo {}
+// <|interface [|{| defId: 0 |}Baz|] extends Foo {}|>
 // 
-// var bar: Foo = [|{| defId: 0 |}{ hello: helloImpl /**0*/ }|];
-// var baz: Foo[] = [|{| defId: 1 |}[{ hello: helloImpl /**4*/ }]|];
+// var bar: Foo = [|{| defId: 1 |}{ hello: helloImpl /**0*/ }|];
+// var baz: Foo[] = [|{| defId: 2 |}[{ hello: helloImpl /**4*/ }]|];
 // 
 // function helloImpl () {}
 // 
-// function whatever(x: Foo = [|{| defId: 2 |}{ hello() {/**1*/} }|] ) {
+// function whatever(x: Foo = [|{| defId: 3 |}{ hello() {/**1*/} }|] ) {
 // }
 // 
 // class Bar {
-//     x: Foo = [|{| defId: 3 |}{ hello() {} }|]
+//     x: Foo = [|{| defId: 4 |}{ hello() {} }|]
 // 
-//     constructor(public f: Foo = [|{| defId: 4 |}{ hello() {/**3*/} }|] ) {}
+//     constructor(public f: Foo = [|{| defId: 5 |}{ hello() {/**3*/} }|] ) {}
 // }
 
   // === Details ===
   [
    {
     "defId": 0,
+    "displayParts": [
+     {
+      "text": "interface",
+      "kind": "keyword"
+     },
+     {
+      "text": " ",
+      "kind": "space"
+     },
+     {
+      "text": "Baz",
+      "kind": "interfaceName"
+     }
+    ],
+    "kind": "interface"
+   },
+   {
+    "defId": 1,
     "kind": "interface",
     "displayParts": [
      {
@@ -41,12 +59,12 @@
     ]
    },
    {
-    "defId": 1,
+    "defId": 2,
     "kind": "",
     "displayParts": []
    },
    {
-    "defId": 2,
+    "defId": 3,
     "kind": "interface",
     "displayParts": [
      {
@@ -64,7 +82,7 @@
     ]
    },
    {
-    "defId": 3,
+    "defId": 4,
     "kind": "interface",
     "displayParts": [
      {
@@ -82,7 +100,7 @@
     ]
    },
    {
-    "defId": 4,
+    "defId": 5,
     "kind": "interface",
     "displayParts": [
      {

tests/baselines/reference/goToImplementationInterface_10.baseline.jsonc

@@ -0,0 +1,71 @@
+// === goToImplementation ===
+// === /a.ts ===
+// interface /*GOTO IMPL*/A {
+// 	foo: boolean;
+// }
+// <|interface [|{| defId: 0 |}B|] extends A {
+// 	bar: boolean;
+// }|>
+// <|export class [|{| defId: 1 |}C|] implements B {
+// 	foo = true;
+// 	bar = true;
+// }|>
+// <|export class [|{| defId: 2 |}D|] extends C { }|>
+
+  // === Details ===
+  [
+   {
+    "defId": 0,
+    "displayParts": [
+     {
+      "text": "interface",
+      "kind": "keyword"
+     },
+     {
+      "text": " ",
+      "kind": "space"
+     },
+     {
+      "text": "B",
+      "kind": "interfaceName"
+     }
+    ],
+    "kind": "interface"
+   },
+   {
+    "defId": 1,
+    "displayParts": [
+     {
+      "text": "class",
+      "kind": "keyword"
+     },
+     {
+      "text": " ",
+      "kind": "space"
+     },
+     {
+      "text": "C",
+      "kind": "className"
+     }
+    ],
+    "kind": "class"
+   },
+   {
+    "defId": 2,
+    "displayParts": [
+     {
+      "text": "class",
+      "kind": "keyword"
+     },
+     {
+      "text": " ",
+      "kind": "space"
+     },
+     {
+      "text": "D",
+      "kind": "className"
+     }
+    ],
+    "kind": "class"
+   }
+  ]

tests/cases/fourslash/goToImplementationInterface_10.ts

@@ -0,0 +1,16 @@
+/// <reference path='fourslash.ts'/>
+
+// @Filename: /a.ts
+////interface /*def*/A {
+////	foo: boolean;
+////}
+////interface [|B|] extends A {
+////	bar: boolean;
+////}
+////export class [|C|] implements B {
+////	foo = true;
+////	bar = true;
+////}
+////export class [|D|] extends C { }
+
+verify.baselineGoToImplementation("def");