Add test for --tsbuildinfo not as absolute or relative path

Author: sheetalkamat

src/harness/fakes.ts

@@ -524,7 +524,7 @@ ${indentText}${text}`;
 
     export const version = "FakeTSVersion";
 
-    export function patchSolutionBuilderHost(host: ts.SolutionBuilderHost<ts.BuilderProgram>, sys: System) {
+    export function patchHostForBuildInfoReadWrite(host: ts.CompilerHost | ts.SolutionBuilderHost<ts.BuilderProgram>) {
         const originalReadFile = host.readFile;
         host.readFile = (path, encoding) => {
             const value = originalReadFile.call(host, path, encoding);
@@ -537,14 +537,18 @@ ${indentText}${text}`;
 
         if (host.writeFile) {
             const originalWriteFile = host.writeFile;
-            host.writeFile = (fileName, content, writeByteOrderMark) => {
+            host.writeFile = (fileName: string, content: string, writeByteOrderMark: boolean) => {
                 if (!ts.isBuildInfoFile(fileName)) return originalWriteFile.call(host, fileName, content, writeByteOrderMark);
                 const buildInfo = ts.getBuildInfo(content);
                 sanitizeBuildInfoProgram(buildInfo);
                 buildInfo.version = version;
                 originalWriteFile.call(host, fileName, ts.getBuildInfoText(buildInfo), writeByteOrderMark);
             };
         }
+    }
+
+    export function patchSolutionBuilderHost(host: ts.SolutionBuilderHost<ts.BuilderProgram>, sys: System) {
+        patchHostForBuildInfoReadWrite(host);
 
         ts.Debug.assert(host.now === undefined);
         host.now = () => new Date(sys.vfs.time());

src/testRunner/tsconfig.json

@@ -113,6 +113,7 @@
         "unittests/tsbuild/watchEnvironment.ts",
         "unittests/tsbuild/watchMode.ts",
         "unittests/tsc/declarationEmit.ts",
+        "unittests/tsc/incremental.ts",
         "unittests/tscWatch/consoleClearing.ts",
         "unittests/tscWatch/emit.ts",
         "unittests/tscWatch/emitAndErrorUpdates.ts",

src/testRunner/unittests/tsbuild/helpers.ts

@@ -290,7 +290,7 @@ interface Symbol {
         baselineSourceMap, modifyFs, baselineReadFileCalls,
         incrementalScenarios
     }: VerifyTsBuildInput) {
-        describe(`tsc --b ${scenario}:: ${subScenario}`, () => {
+        describe(`tsc ${commandLineArgs.join(" ")} ${scenario}:: ${subScenario}`, () => {
             let tick: () => void;
             let sys: TscCompileSystem;
             before(() => {

src/testRunner/unittests/tsc/helpers.ts

@@ -79,6 +79,7 @@ namespace ts {
         const { fileNames, options, projectReferences } = config;
         const reportDiagnostic = createDiagnosticReporter(sys, options.pretty);
         const host = createCompilerHostWorker(options, /*setParentPos*/ undefined, sys);
+        fakes.patchHostForBuildInfoReadWrite(host);
         const currentDirectory = host.getCurrentDirectory();
         const getCanonicalFileName = createGetCanonicalFileName(host.useCaseSensitiveFileNames());
         changeCompilerHostLikeToUseCache(host, fileName => toPath(fileName, currentDirectory, getCanonicalFileName));
@@ -102,7 +103,10 @@ namespace ts {
     function performIncrementalCompilation(sys: TscCompileSystem, config: ParsedCommandLine) {
         const reportDiagnostic = createDiagnosticReporter(sys, config.options.pretty);
         const { options, fileNames, projectReferences } = config;
+        const host = createIncrementalCompilerHost(options, sys);
+        fakes.patchHostForBuildInfoReadWrite(host);
         const exitCode = ts.performIncrementalCompilation({
+            host,
             system: sys,
             rootNames: fileNames,
             options,

src/testRunner/unittests/tsc/incremental.ts

@@ -0,0 +1,26 @@
+namespace ts {
+    describe("unittests:: tsc:: incremental::", () => {
+        verifyTscIncrementalEdits({
+            scenario: "incremental",
+            subScenario: "when passing passing filename for buildinfo on commandline",
+            fs: () => loadProjectFromFiles({
+                "/src/project/src/main.ts": "export const x = 10;",
+                "/src/project/tsconfig.json": utils.dedent`
+                    {
+                        "compilerOptions": {
+                            "target": "es5",
+                            "module": "commonjs",
+                        },
+                        "include": [
+                            "src/**/*.ts"
+                        ]
+                    }`,
+            }),
+            commandLineArgs: ["--incremental", "--p", "src/project", "--tsBuildInfoFile", "src/project/.tsbuildinfo"],
+            incrementalScenarios: [{
+                buildKind: BuildKind.IncrementalDtsUnchanged,
+                modifyFs: noop,
+            }]
+        });
+    });
+}

tests/baselines/reference/tsc/incremental/incremental-declaration-doesnt-change/when-passing-passing-filename-for-buildinfo-on-commandline.js

@@ -0,0 +1,7 @@
+//// [/lib/incremental-declaration-doesnt-changeOutput.txt]
+/lib/tsc --incremental --p src/project --tsBuildInfoFile src/project/.tsbuildinfo
+exitCode:: 0
+
+
+//// [/src/project/.tsbuildinfo] file written with same contents
+//// [/src/project/src/main.js] file written with same contents

tests/baselines/reference/tsc/incremental/initial-build/when-passing-passing-filename-for-buildinfo-on-commandline.js

@@ -0,0 +1,42 @@
+//// [/lib/initial-buildOutput.txt]
+/lib/tsc --incremental --p src/project --tsBuildInfoFile src/project/.tsbuildinfo
+exitCode:: 0
+
+
+//// [/src/project/.tsbuildinfo]
+{
+  "program": {
+    "fileInfos": {
+      "../../lib/lib.d.ts": {
+        "version": "3858781397-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }\ninterface ReadonlyArray<T> {}\ndeclare const console: { log(msg: any): void; };",
+        "signature": "3858781397-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }\ninterface ReadonlyArray<T> {}\ndeclare const console: { log(msg: any): void; };"
+      },
+      "./src/main.ts": {
+        "version": "-10726455937-export const x = 10;",
+        "signature": "-6057683066-export declare const x = 10;\r\n"
+      }
+    },
+    "options": {
+      "target": 1,
+      "module": 1,
+      "incremental": true,
+      "project": "./",
+      "tsBuildInfoFile": "./.tsbuildinfo",
+      "configFilePath": "./tsconfig.json"
+    },
+    "referencedMap": {},
+    "exportedModulesMap": {},
+    "semanticDiagnosticsPerFile": [
+      "../../lib/lib.d.ts",
+      "./src/main.ts"
+    ]
+  },
+  "version": "FakeTSVersion"
+}
+
+//// [/src/project/src/main.js]
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.x = 10;
+
+