Template string literals now participate in occurrences highlighting

[andrewitsover]

TS Template added by @mjbvz

TypeScript Version: 4.2+

Search Terms

• documentHighlights

---

The new release has added the feature in the screenshot. I looked through all of the release notes and couldn't find a single mention of it. All it does is reduce the readability of the string I am looking at. How do I turn it off? Why don't the release notes mention it? I can't even find a commit or pull request linked to it.

[IllusionMH]

/needsMoreInfo

Is it reproducible with all extensions disabled?
You can try this with F1 and >Developer: Reload Window With Extensions Disabled

Is it reproducible wit any theme? Do you need to have cursor inside of template literal?

[vscode-triage-bot]

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.

Happy Coding!

[andrewitsover]

Everything I have is default except for Chrome debugger extension. This is MacOS Big Sur, 1.54 release. I assume it is supposed to be a feature? Whenever the cursor is placed in a string literal, the entire thing is highlighted. It is the same with string literals and template literals.

[andrewitsover]

If it is a feature, it doesn't even work properly because it depends where you put the cursor in the string.

Screen.Recording.2021-03-05.at.10.00.08.pm.mov

[IllusionMH]

No need to post new comment every time - you can update previous and reduce spam.

OK, clicked on different strings in different files and some of them started to highlight as in your screenshot.

Looks like it can be disabled by "editor.occurrencesHighlight": false ATM.

As I can see it is usually highlights strings that have string literal type in JS/TS and are highlighted as occurrences of constant.

@alexdima @mjbvz do you know why strings started to contribute to occurrences highlights list?

[dzzzzzy]

Same confusion for me

Before update vscode:

Only line 2 highlight

After update vscode to 1.54.2:

Both of line 1, line 2 and line3 highlight

System: MacOS Big Sur 11.2.3 (20D91)
vscode version: 1.54.2

[mjbvz]

Moving this upstream for feedback from the TypeScript team. I believe this was added in TS 4.2.

The new highlighting is consistent with how ' and " string are highlighted

[RyanCavanaugh]

@mjbvz what's being requested here?

[mjbvz]

Just a point of user feedback on the new behavior

We could consider disabling this for multiline template strings or for strings where there is only a single occurrence