Skip to content

Commit 984d784

Browse files
hpsinhpsin
authored
BREAKING CHANGE 0.9.5 release (#259)
* Update content for WER * Update docs for XML. * Update Copyright to 2017 :) * fixes for #226, 227 and 228 * enable xml documentation generation (#232) * enable xml documentation generation * only generate xml documentation in release builds * Update docs * Filenames to StorageFiles * Update README.md (#235) Somebody decided to move all of the Hololens documentation and as a result pretty much every existing link on the internet is broken. Fixing this one. * Fixes a minor bug with xbox sample and cleans up StyleCop (#237) * Add an IsFolder method to FileOrFolderInformation class. * Updated per review feedback * Adds PackageOrigin to PackageInfo class. * PackageOrigin details and helper method Quick helper method to determine if the app is sideloaded. * Clean up some StyleCop errors. * Restores our CSRF token handling (#238) Addresses Issue #216 * Make underlying HTTP methods public so they can be called on a DevicePortal instance (#243) * Prelim setup of namespaces * Move HTTP Stream apis to public. Finish move of namespaces. * Revert "Move HTTP Stream apis to public. Finish move of namespaces." This reverts commit 2e715ff. * Revert "Revert Namespaces changes in Master" This reverts commit 871564eb18f525878063ca8cc4b0b9af2bb2ee79. * Revert Namespaces changes in Master * Finish Revert * Setup files for internal CI server and NuGet package creation (#247) * Create signConfig.xml * Create DelaySign.extcomp * Add DelaySign to NET * Add DelaySign to UWP * Testing INPATHROOT and full path for codesign * Update signConfig.xml * Update signConfig.xml * Create WindowsDevicePortalWrapper.nuspec * Changing to unsigned files * Knowing my coworkers aliases * Temp test for signing. * Add StrongNameSigning. * DelaySign * New snk * It's sourceS not source * Update for XES Setup * Authenticode Only * .NET doesn't do sub directories ok * Set nuspec relative to output * Wrong folder for nuspec * Copy also copies folders * Update required fields in nuspec * Correct names for signing * Delete DelaySign.extcomp * Removing extcomp * Remove XEF delay sign * Remove XEFDelay sign from net * Fix blank version. * Add TimeSpan field to Battery API results #161 (#250) * Add IC server info for maintainers. * fix field sizes in DeviceProcessInfo * Fix SystemPerformanceInformation DataContract and add asserrt when websocket fails to parse data. * Fix automated tests. * Consolidate the assert on a deserialization failure to all rest requests and reduce duplicated logic. * Fix spacing. * Increase version number to 0.9.5.0. (#257) * Make generic Stream REST APIs public as well. (#258)
1 parent e69aa95 commit 984d784

34 files changed

+301
-253
lines changed

‎CONTRIBUTING.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ When creating a new NuGet and GitHub release, the following steps should be take
8080
2. Merge from Master to Release, with a PR appropriately named ("v1.2.3 release")
8181
3. Squash and merge commits, leaving major feature entries and fixes in the description.
8282
4. Compile release builds of the .NET and UWP libraries, sign them, and upload to NuGet
83+
a. We now have a CI server for this that builds, signs, and packages the NuGet package [here](https://microsoft.visualstudio.com/DefaultCollection/OS/_build/index?path=%5C&definitionId=14239).
8384
5. Cut a new release on GitHub using the same version number ("v1.2.3") and attach the signed libraries to the release.
8485
6. Update code documentation.
8586

‎WindowsDevicePortalWrapper/UnitTestProject/Core/PerformanceDataTests.cs‎

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -145,14 +145,14 @@ private static void ValidateRunningProcessesAsync(RunningProcesses runningProces
145145
Assert.AreEqual(systemIdleprocess.Name, "System Idle Process");
146146
Assert.IsNull(systemIdleprocess.PackageFullName);
147147
Assert.AreEqual(systemIdleprocess.PageFile, 0U);
148-
Assert.AreEqual(systemIdleprocess.PrivateWorkingSet, 4096);
149-
Assert.AreEqual(systemIdleprocess.ProcessId, 0);
148+
Assert.AreEqual(systemIdleprocess.PrivateWorkingSet, 4096U);
149+
Assert.AreEqual(systemIdleprocess.ProcessId, 0U);
150150
Assert.IsNull(systemIdleprocess.Publisher);
151151
Assert.AreEqual(systemIdleprocess.SessionId, 0U);
152-
Assert.AreEqual(systemIdleprocess.TotalCommit, 0);
152+
Assert.AreEqual(systemIdleprocess.TotalCommit, 0U);
153153
Assert.AreEqual(systemIdleprocess.UserName, "NT AUTHORITY\\SYSTEM");
154154
Assert.IsNull(systemIdleprocess.Version);
155-
Assert.AreEqual(systemIdleprocess.VirtualSize, 65536);
155+
Assert.AreEqual(systemIdleprocess.VirtualSize, 65536U);
156156
Assert.AreEqual(systemIdleprocess.WorkingSet, 4096U);
157157

158158
DeviceProcessInfo devHomeProcess = processes[1];
@@ -163,14 +163,14 @@ private static void ValidateRunningProcessesAsync(RunningProcesses runningProces
163163
Assert.AreEqual(devHomeProcess.Name, "svchost.exe");
164164
Assert.IsNull(devHomeProcess.PackageFullName);
165165
Assert.AreEqual(devHomeProcess.PageFile, 5472256U);
166-
Assert.AreEqual(devHomeProcess.PrivateWorkingSet, 4755456);
167-
Assert.AreEqual(devHomeProcess.ProcessId, 892);
166+
Assert.AreEqual(devHomeProcess.PrivateWorkingSet, 4755456U);
167+
Assert.AreEqual(devHomeProcess.ProcessId, 892U);
168168
Assert.IsNull(devHomeProcess.Publisher);
169169
Assert.AreEqual(devHomeProcess.SessionId, 0U);
170-
Assert.AreEqual(devHomeProcess.TotalCommit, 5914624);
170+
Assert.AreEqual(devHomeProcess.TotalCommit, 5914624U);
171171
Assert.AreEqual(devHomeProcess.UserName, "NT AUTHORITY\\SYSTEM");
172172
Assert.IsNull(devHomeProcess.Version);
173-
Assert.AreEqual(devHomeProcess.VirtualSize, 2203387539456);
173+
Assert.AreEqual(devHomeProcess.VirtualSize, 2203387539456U);
174174
Assert.AreEqual(devHomeProcess.WorkingSet, 17285120U);
175175
}
176176

@@ -181,18 +181,18 @@ private static void ValidateRunningProcessesAsync(RunningProcesses runningProces
181181
private static void ValidateSystemPerm(SystemPerformanceInformation systemPerfInfo)
182182
{
183183
// Check some known things about this response.
184-
Assert.AreEqual(systemPerfInfo.AvailablePages, 369054);
185-
Assert.AreEqual(systemPerfInfo.CommitLimit, 784851);
186-
Assert.AreEqual(systemPerfInfo.CommittedPages, 322627);
187-
Assert.AreEqual(systemPerfInfo.CpuLoad, 1);
188-
Assert.AreEqual(systemPerfInfo.IoOtherSpeed, 3692);
189-
Assert.AreEqual(systemPerfInfo.IoReadSpeed, 36);
190-
Assert.AreEqual(systemPerfInfo.IoWriteSpeed, 6480);
191-
Assert.AreEqual(systemPerfInfo.NonPagedPoolPages, 42504);
192-
Assert.AreEqual(systemPerfInfo.PageSize, 4096);
193-
Assert.AreEqual(systemPerfInfo.PagedPoolPages, 30697);
194-
Assert.AreEqual(systemPerfInfo.TotalInstalledKb, 1048592);
195-
Assert.AreEqual(systemPerfInfo.TotalPages, 655360);
184+
Assert.AreEqual(systemPerfInfo.AvailablePages, 369054U);
185+
Assert.AreEqual(systemPerfInfo.CommitLimit, 784851U);
186+
Assert.AreEqual(systemPerfInfo.CommittedPages, 322627U);
187+
Assert.AreEqual(systemPerfInfo.CpuLoad, 1U);
188+
Assert.AreEqual(systemPerfInfo.IoOtherSpeed, 3692U);
189+
Assert.AreEqual(systemPerfInfo.IoReadSpeed, 36U);
190+
Assert.AreEqual(systemPerfInfo.IoWriteSpeed, 6480U);
191+
Assert.AreEqual(systemPerfInfo.NonPagedPoolPages, 42504U);
192+
Assert.AreEqual(systemPerfInfo.PageSize, 4096U);
193+
Assert.AreEqual(systemPerfInfo.PagedPoolPages, 30697U);
194+
Assert.AreEqual(systemPerfInfo.TotalInstalledKb, 1048592U);
195+
Assert.AreEqual(systemPerfInfo.TotalPages, 655360U);
196196

197197
Assert.AreEqual(systemPerfInfo.GpuData.Adapters.Count, 1);
198198
GpuAdapter gpuAdapter = systemPerfInfo.GpuData.Adapters[0];
@@ -204,11 +204,11 @@ private static void ValidateSystemPerm(SystemPerformanceInformation systemPerfIn
204204

205205
Assert.AreEqual(gpuAdapter.EnginesUtilization.Count, 7);
206206
double enguineUtilization = gpuAdapter.EnginesUtilization[0];
207-
Assert.AreEqual(enguineUtilization, 0.0011459999950602651);
207+
Assert.AreEqual(enguineUtilization, 0.001146);
208208

209209
NetworkPerformanceData networkPerformanceData = systemPerfInfo.NetworkData;
210-
Assert.AreEqual(networkPerformanceData.BytesIn, 15000);
211-
Assert.AreEqual(networkPerformanceData.BytesOut, 0);
210+
Assert.AreEqual(networkPerformanceData.BytesIn, 15000U);
211+
Assert.AreEqual(networkPerformanceData.BytesOut, 0U);
212212
}
213213
}
214214
}

‎WindowsDevicePortalWrapper/UnitTestProject/Device-VersionTests/HoloLens/HoloLensHelpers.cs‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -22,18 +22,18 @@ public static class HoloLensHelpers
2222
internal static void ValidateSystemPerfAsync(SystemPerformanceInformation systemPerfInfo)
2323
{
2424
// Check some known things about this response.
25-
Assert.AreEqual(275897, systemPerfInfo.AvailablePages);
26-
Assert.AreEqual(764290, systemPerfInfo.CommitLimit);
27-
Assert.AreEqual(225486, systemPerfInfo.CommittedPages);
28-
Assert.AreEqual(20, systemPerfInfo.CpuLoad);
29-
Assert.AreEqual(4337544, systemPerfInfo.IoOtherSpeed);
30-
Assert.AreEqual(1717438, systemPerfInfo.IoReadSpeed);
31-
Assert.AreEqual(788621, systemPerfInfo.IoWriteSpeed);
32-
Assert.AreEqual(15470, systemPerfInfo.NonPagedPoolPages);
33-
Assert.AreEqual(4096, systemPerfInfo.PageSize);
34-
Assert.AreEqual(18894, systemPerfInfo.PagedPoolPages);
35-
Assert.AreEqual(2097152, systemPerfInfo.TotalInstalledKb);
36-
Assert.AreEqual(502146, systemPerfInfo.TotalPages);
25+
Assert.AreEqual(275897U, systemPerfInfo.AvailablePages);
26+
Assert.AreEqual(764290U, systemPerfInfo.CommitLimit);
27+
Assert.AreEqual(225486U, systemPerfInfo.CommittedPages);
28+
Assert.AreEqual(20U, systemPerfInfo.CpuLoad);
29+
Assert.AreEqual(4337544U, systemPerfInfo.IoOtherSpeed);
30+
Assert.AreEqual(1717438U, systemPerfInfo.IoReadSpeed);
31+
Assert.AreEqual(788621U, systemPerfInfo.IoWriteSpeed);
32+
Assert.AreEqual(15470U, systemPerfInfo.NonPagedPoolPages);
33+
Assert.AreEqual(4096U, systemPerfInfo.PageSize);
34+
Assert.AreEqual(18894U, systemPerfInfo.PagedPoolPages);
35+
Assert.AreEqual(2097152U, systemPerfInfo.TotalInstalledKb);
36+
Assert.AreEqual(502146U, systemPerfInfo.TotalPages);
3737

3838
Assert.AreEqual(systemPerfInfo.GpuData.Adapters.Count, 1);
3939
GpuAdapter gpuAdapter = systemPerfInfo.GpuData.Adapters[0];
@@ -47,8 +47,8 @@ internal static void ValidateSystemPerfAsync(SystemPerformanceInformation system
4747
Assert.AreEqual("7.098184", gpuAdapter.EnginesUtilization[0].ToString("n6"));
4848

4949
NetworkPerformanceData networkPerformanceData = systemPerfInfo.NetworkData;
50-
Assert.AreEqual(0, networkPerformanceData.BytesIn);
51-
Assert.AreEqual(0, networkPerformanceData.BytesOut);
50+
Assert.AreEqual(0U, networkPerformanceData.BytesIn);
51+
Assert.AreEqual(0U, networkPerformanceData.BytesOut);
5252
}
5353

5454
/// <summary>

‎WindowsDevicePortalWrapper/UnitTestProject/Device-VersionTests/XboxOne/XboxOne_rs1_xbox_rel_1608.cs‎

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -682,14 +682,14 @@ private static void ValidateRunningProcessesAsync(RunningProcesses runningProces
682682
Assert.AreEqual(systemIdleprocess.Name, "System Idle Process");
683683
Assert.IsNull(systemIdleprocess.PackageFullName);
684684
Assert.AreEqual(systemIdleprocess.PageFile, 0U);
685-
Assert.AreEqual(systemIdleprocess.PrivateWorkingSet, 4096);
686-
Assert.AreEqual(systemIdleprocess.ProcessId, 0);
685+
Assert.AreEqual(systemIdleprocess.PrivateWorkingSet, 4096U);
686+
Assert.AreEqual(systemIdleprocess.ProcessId, 0U);
687687
Assert.IsNull(systemIdleprocess.Publisher);
688688
Assert.AreEqual(systemIdleprocess.SessionId, 0U);
689-
Assert.AreEqual(systemIdleprocess.TotalCommit, 0);
689+
Assert.AreEqual(systemIdleprocess.TotalCommit, 0U);
690690
Assert.AreEqual(systemIdleprocess.UserName, "NT AUTHORITY\\SYSTEM");
691691
Assert.IsNull(systemIdleprocess.Version);
692-
Assert.AreEqual(systemIdleprocess.VirtualSize, 65536);
692+
Assert.AreEqual(systemIdleprocess.VirtualSize, 65536U);
693693
Assert.AreEqual(systemIdleprocess.WorkingSet, 4096U);
694694

695695
DeviceProcessInfo devHomeProcess = processes[56];
@@ -700,18 +700,18 @@ private static void ValidateRunningProcessesAsync(RunningProcesses runningProces
700700
Assert.AreEqual(devHomeProcess.Name, "WWAHost.exe");
701701
Assert.AreEqual(devHomeProcess.PackageFullName, "Microsoft.Xbox.DevHome_100.1607.9000.0_x64__8wekyb3d8bbwe");
702702
Assert.AreEqual(devHomeProcess.PageFile, 47067136U);
703-
Assert.AreEqual(devHomeProcess.PrivateWorkingSet, 32796672);
704-
Assert.AreEqual(devHomeProcess.ProcessId, 3424);
703+
Assert.AreEqual(devHomeProcess.PrivateWorkingSet, 32796672U);
704+
Assert.AreEqual(devHomeProcess.ProcessId, 3424U);
705705
Assert.AreEqual(devHomeProcess.Publisher, "CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US");
706706
Assert.AreEqual(devHomeProcess.SessionId, 0U);
707-
Assert.AreEqual(devHomeProcess.TotalCommit, 49213440);
707+
Assert.AreEqual(devHomeProcess.TotalCommit, 49213440U);
708708

709709
Assert.AreEqual(devHomeProcess.UserName, "TESTXBOX\\DefaultAccount");
710710
Assert.AreEqual(devHomeProcess.Version.Build, 9000U);
711711
Assert.AreEqual(devHomeProcess.Version.Major, 100U);
712712
Assert.AreEqual(devHomeProcess.Version.Minor, 1607U);
713713
Assert.AreEqual(devHomeProcess.Version.Revision, 0U);
714-
Assert.AreEqual(devHomeProcess.VirtualSize, 2234032066560);
714+
Assert.AreEqual(devHomeProcess.VirtualSize, 2234032066560U);
715715
Assert.AreEqual(devHomeProcess.WorkingSet, 79466496U);
716716
}
717717

@@ -722,18 +722,18 @@ private static void ValidateRunningProcessesAsync(RunningProcesses runningProces
722722
private static void ValidateSystemPerm(SystemPerformanceInformation systemPerfInfo)
723723
{
724724
// Check some known things about this response.
725-
Assert.AreEqual(systemPerfInfo.AvailablePages, 369054);
726-
Assert.AreEqual(systemPerfInfo.CommitLimit, 784851);
727-
Assert.AreEqual(systemPerfInfo.CommittedPages, 322627);
728-
Assert.AreEqual(systemPerfInfo.CpuLoad, 1);
729-
Assert.AreEqual(systemPerfInfo.IoOtherSpeed, 3692);
730-
Assert.AreEqual(systemPerfInfo.IoReadSpeed, 36);
731-
Assert.AreEqual(systemPerfInfo.IoWriteSpeed, 6480);
732-
Assert.AreEqual(systemPerfInfo.NonPagedPoolPages, 42504);
733-
Assert.AreEqual(systemPerfInfo.PageSize, 4096);
734-
Assert.AreEqual(systemPerfInfo.PagedPoolPages, 30697);
735-
Assert.AreEqual(systemPerfInfo.TotalInstalledKb, 1048592);
736-
Assert.AreEqual(systemPerfInfo.TotalPages, 655360);
725+
Assert.AreEqual(systemPerfInfo.AvailablePages, 369054U);
726+
Assert.AreEqual(systemPerfInfo.CommitLimit, 784851U);
727+
Assert.AreEqual(systemPerfInfo.CommittedPages, 322627U);
728+
Assert.AreEqual(systemPerfInfo.CpuLoad, 1U);
729+
Assert.AreEqual(systemPerfInfo.IoOtherSpeed, 3692U);
730+
Assert.AreEqual(systemPerfInfo.IoReadSpeed, 36U);
731+
Assert.AreEqual(systemPerfInfo.IoWriteSpeed, 6480U);
732+
Assert.AreEqual(systemPerfInfo.NonPagedPoolPages, 42504U);
733+
Assert.AreEqual(systemPerfInfo.PageSize, 4096U);
734+
Assert.AreEqual(systemPerfInfo.PagedPoolPages, 30697U);
735+
Assert.AreEqual(systemPerfInfo.TotalInstalledKb, 1048592U);
736+
Assert.AreEqual(systemPerfInfo.TotalPages, 655360U);
737737

738738
Assert.AreEqual(systemPerfInfo.GpuData.Adapters.Count, 1);
739739
GpuAdapter gpuAdapter = systemPerfInfo.GpuData.Adapters[0];
@@ -745,11 +745,11 @@ private static void ValidateSystemPerm(SystemPerformanceInformation systemPerfIn
745745

746746
Assert.AreEqual(gpuAdapter.EnginesUtilization.Count, 7);
747747
double enguineUtilization = gpuAdapter.EnginesUtilization[0];
748-
Assert.AreEqual(enguineUtilization, 0.0011459999950602651);
748+
Assert.AreEqual(enguineUtilization, 0.001146);
749749

750750
NetworkPerformanceData networkPerformanceData = systemPerfInfo.NetworkData;
751-
Assert.AreEqual(networkPerformanceData.BytesIn, 15000);
752-
Assert.AreEqual(networkPerformanceData.BytesOut, 0);
751+
Assert.AreEqual(networkPerformanceData.BytesIn, 15000U);
752+
Assert.AreEqual(networkPerformanceData.BytesOut, 0U);
753753
}
754754
}
755755
}

‎WindowsDevicePortalWrapper/Utilities/WindowsDevicePortalWrapper.nuspec‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<package xmlns="http://schemas.microsoft.com/packaging/2011/08/nuspec.xsd">
3+
<metadata>
4+
<id>WindowsDevicePortalWrapper</id>
5+
<version>0.0.0.0</version>
6+
<title>Windows Device Portal Wrapper</title>
7+
<authors>Windows Device Portal</authors>
8+
<owners>Microsoft; Windows Device Portal</owners>
9+
<licenseUrl>https://github.com/Microsoft/WindowsDevicePortalWrapper/blob/master/License.txt</licenseUrl>
10+
<projectUrl>https://github.com/microsoft/windowsdeviceportalwrapper</projectUrl>
11+
<requireLicenseAcceptance>false</requireLicenseAcceptance>
12+
<description>The Device Portal Wrapper is a library that allows a client application to connect to a Device Portal instance on a Windows 10 device and call the REST APIs presented. This allows an application to e.g. install apps, reboot the device, or get performance metrics.
13+
14+
See the GitHub repo at https://github.com/microsoft/windowsdeviceportalwrapper</description>
15+
<summary>Remote control of Windows 10 device for developers and device labs.</summary>
16+
<releaseNotes>[FILL IN BEFORE RELEASE]</releaseNotes>
17+
<copyright>Microsoft Corp</copyright>
18+
<language />
19+
<tags>WDP Windows 10 Device Portal</tags>
20+
</metadata>
21+
<files>
22+
<file src="WindowsDevicePortalWrapper.dll" target="lib\net452" />
23+
<file src="release\AnyCPU\WindowsDevicePortalWrapper.pdb" target="lib\net452" />
24+
<file src="release\AnyCPU\WindowsDevicePortalWrapper.xml" target="lib\net452" />
25+
26+
<file src="WindowsDevicePortalWrapper.UniversalWindows.dll" target="lib\uap10.0" />
27+
<file src="release\AnyCPU\WindowsDevicePortalWrapper.UniversalWindows\WindowsDevicePortalWrapper.UniversalWindows.pdb" target="lib\uap10.0" />
28+
<file src="release\AnyCPU\WindowsDevicePortalWrapper.UniversalWindows\WindowsDevicePortalWrapper.UniversalWindows.XML" target="lib\uap10.0" />
29+
</files>
30+
</package>

‎WindowsDevicePortalWrapper/Utilities/signConfig.xml‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
<?xml version="1.0" encoding="utf-8" ?>
2+
<SignConfigXML>
3+
4+
<job platform="" configuration="Release" dest="" jobname="WDPW Sign" approvers="hirsin;aaronste">
5+
<file src="__INPATHROOT__\WindowsDevicePortalWrapper.dll" signType="Authenticode" dest="__OUTPATHROOT__\WindowsDevicePortalWrapper.dll" />
6+
<file src="__INPATHROOT__\WindowsDevicePortalWrapper.UniversalWindows\WindowsDevicePortalWrapper.UniversalWindows.dll" signType="Authenticode" dest="__OUTPATHROOT__\WindowsDevicePortalWrapper.UniversalWindows.dll" />
7+
</job>
8+
9+
</SignConfigXML>

0 commit comments

Comments
 (0)