Skip to content

Commit c11ac43

Browse files
committed
fixes
1 parent 6fbd98a commit c11ac43

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

Source/HTTP/WinHttp/winhttp_connection.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -830,7 +830,9 @@ void WinHttpConnection::callback_status_sending_request(
830830
_In_ WinHttpConnection* pRequestContext,
831831
_In_ void* /*statusInfo*/)
832832
{
833-
if (hRequestHandle != nullptr)
833+
// Only verify server certificate if XNetworking security information is available
834+
// (it won't be available when XNetworking feature is not present, e.g., on PC GDK builds)
835+
if (hRequestHandle != nullptr && pRequestContext->m_securityInformation.securityInformation != nullptr)
834836
{
835837
HRESULT hr = XNetworkingVerifyServerCertificate(hRequestHandle, pRequestContext->m_securityInformation.securityInformation);
836838
if (FAILED(hr))

Source/HTTP/WinHttp/winhttp_provider.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,11 @@ Result<HC_UNIQUE_PTR<WinHttpProvider>> WinHttpProvider::Initialize()
2222
{
2323
RETURN_IF_FAILED(XNetworkingRegisterConnectivityHintChanged(provider->m_immediateQueue, provider.get(), WinHttpProvider::NetworkConnectivityChangedCallback, &provider->m_networkConnectivityChangedToken));
2424
}
25+
else
26+
{
27+
// XNetworking not available (e.g., PC GDK build), assume network is ready
28+
provider->m_networkInitialized = true;
29+
}
2530

2631
RETURN_IF_FAILED(RegisterAppStateChangeNotification(WinHttpProvider::AppStateChangedCallback, provider.get(), &provider->m_appStateChangedToken));
2732

0 commit comments

Comments
 (0)