Python linting issue

Author: jahnvi480

mssql_python/connection.py

@@ -59,7 +59,8 @@
 
 # Valid encoding characters (alphanumeric, dash, underscore only)
 import string
-VALID_ENCODING_CHARS: frozenset[str] = frozenset(string.ascii_letters + string.digits + '-_')
+
+VALID_ENCODING_CHARS: frozenset[str] = frozenset(string.ascii_letters + string.digits + "-_")
 
 
 def _validate_encoding(encoding: str) -> bool:
@@ -80,11 +81,11 @@ def _validate_encoding(encoding: str) -> bool:
     # First check for dangerous characters (security validation)
     if not all(c in VALID_ENCODING_CHARS for c in encoding):
         return False
-    
+
     # Check length limit (prevent DOS)
     if len(encoding) > 100:
         return False
-    
+
     # Then check if it's a valid Python codec
     try:
         codecs.lookup(encoding)
@@ -241,7 +242,7 @@ def __init__(
         # Initialize output converters dictionary and its lock for thread safety
         self._output_converters = {}
         self._converters_lock = threading.Lock()
-        
+
         # Initialize encoding/decoding settings lock for thread safety
         # This lock protects both _encoding_settings and _decoding_settings dictionaries
         # to prevent race conditions when multiple threads are reading/writing encoding settings
@@ -449,7 +450,7 @@ def setencoding(self, encoding: Optional[str] = None, ctype: Optional[int] = Non
         # Normalize encoding to casefold for more robust Unicode handling
         encoding = encoding.casefold()
         logger.debug("setencoding: Encoding normalized to %s", encoding)
-        
+
         # Reject 'utf-16' with BOM for SQL_WCHAR (ambiguous byte order)
         if encoding == "utf-16" and ctype == ConstantsDDBC.SQL_WCHAR.value:
             logger.debug(
@@ -489,7 +490,7 @@ def setencoding(self, encoding: Optional[str] = None, ctype: Optional[int] = Non
                     f"SQL_WCHAR ({ConstantsDDBC.SQL_WCHAR.value})"
                 ),
             )
-        
+
         # Validate that SQL_WCHAR ctype only used with UTF-16 encodings (not utf-16 with BOM)
         if ctype == ConstantsDDBC.SQL_WCHAR.value:
             if encoding == "utf-16":
@@ -540,7 +541,7 @@ def getencoding(self) -> Dict[str, Union[str, int]]:
             settings = cnxn.getencoding()
             print(f"Current encoding: {settings['encoding']}")
             print(f"Current ctype: {settings['ctype']}")
-            
+
         Note:
             This method is thread-safe and can be called from multiple threads concurrently.
         """
@@ -638,7 +639,7 @@ def setdecoding(
 
         # Normalize encoding to lowercase for consistency
         encoding = encoding.lower()
-        
+
         # Reject 'utf-16' with BOM for SQL_WCHAR (ambiguous byte order)
         if sqltype == ConstantsDDBC.SQL_WCHAR.value and encoding == "utf-16":
             logger.debug(
@@ -667,7 +668,7 @@ def setdecoding(
                     f"SQL_WCHAR requires UTF-16 encodings (utf-16le, utf-16be)"
                 ),
             )
-        
+
         # SQL_WMETADATA can use any valid encoding (UTF-8, UTF-16, etc.)
         # No restriction needed here - let users configure as needed
 
@@ -693,7 +694,7 @@ def setdecoding(
                     f"SQL_WCHAR ({ConstantsDDBC.SQL_WCHAR.value})"
                 ),
             )
-        
+
         # Validate that SQL_WCHAR ctype only used with UTF-16 encodings (not utf-16 with BOM)
         if ctype == ConstantsDDBC.SQL_WCHAR.value:
             if encoding == "utf-16":
@@ -755,7 +756,7 @@ def getdecoding(self, sqltype: int) -> Dict[str, Union[str, int]]:
             settings = cnxn.getdecoding(mssql_python.SQL_CHAR)
             print(f"SQL_CHAR encoding: {settings['encoding']}")
             print(f"SQL_CHAR ctype: {settings['ctype']}")
-            
+
         Note:
             This method is thread-safe and can be called from multiple threads concurrently.
         """

mssql_python/cursor.py

@@ -20,7 +20,13 @@
 from mssql_python.helpers import check_error
 from mssql_python.logging import logger
 from mssql_python import ddbc_bindings
-from mssql_python.exceptions import InterfaceError, NotSupportedError, ProgrammingError, OperationalError, DatabaseError
+from mssql_python.exceptions import (
+    InterfaceError,
+    NotSupportedError,
+    ProgrammingError,
+    OperationalError,
+    DatabaseError,
+)
 from mssql_python.row import Row
 from mssql_python import get_settings
 
@@ -292,23 +298,21 @@ def _get_encoding_settings(self):
         Returns:
             dict: A dictionary with 'encoding' and 'ctype' keys, or default settings if not available
         """
-        if hasattr(self._connection, 'getencoding'):
+        if hasattr(self._connection, "getencoding"):
             try:
                 return self._connection.getencoding()
             except (OperationalError, DatabaseError) as db_error:
                 # Only catch database-related errors, not programming errors
                 from mssql_python.helpers import log
-                log('warning', f"Failed to get encoding settings from connection due to database error: {db_error}")
-                return {
-                    'encoding': 'utf-16le',
-                    'ctype': ddbc_sql_const.SQL_WCHAR.value
-                }
+
+                log(
+                    "warning",
+                    f"Failed to get encoding settings from connection due to database error: {db_error}",
+                )
+                return {"encoding": "utf-16le", "ctype": ddbc_sql_const.SQL_WCHAR.value}
 
         # Return default encoding settings if getencoding is not available
-        return {
-            'encoding': 'utf-16le',
-            'ctype': ddbc_sql_const.SQL_WCHAR.value
-        }
+        return {"encoding": "utf-16le", "ctype": ddbc_sql_const.SQL_WCHAR.value}
 
     def _get_decoding_settings(self, sql_type):
         """
@@ -326,11 +330,15 @@ def _get_decoding_settings(self, sql_type):
         except (OperationalError, DatabaseError) as db_error:
             # Only handle expected database-related errors
             from mssql_python.helpers import log
-            log('warning', f"Failed to get decoding settings for SQL type {sql_type} due to database error: {db_error}")
+
+            log(
+                "warning",
+                f"Failed to get decoding settings for SQL type {sql_type} due to database error: {db_error}",
+            )
             if sql_type == ddbc_sql_const.SQL_WCHAR.value:
-                return {'encoding': 'utf-16le', 'ctype': ddbc_sql_const.SQL_WCHAR.value}
+                return {"encoding": "utf-16le", "ctype": ddbc_sql_const.SQL_WCHAR.value}
             else:
-                return {'encoding': 'utf-8', 'ctype': ddbc_sql_const.SQL_CHAR.value}
+                return {"encoding": "utf-8", "ctype": ddbc_sql_const.SQL_CHAR.value}
 
     def _map_sql_type(  # pylint: disable=too-many-arguments,too-many-positional-arguments,too-many-locals,too-many-return-statements,too-many-branches
         self,
@@ -1252,7 +1260,7 @@ def execute(  # pylint: disable=too-many-locals,too-many-branches,too-many-state
             parameters_type,
             self.is_stmt_prepared,
             use_prepare,
-            encoding_settings
+            encoding_settings,
         )
         # Check return code
         try:
@@ -2130,7 +2138,12 @@ def fetchone(self) -> Union[None, Row]:
         # Fetch raw data
         row_data = []
         try:
-            ret = ddbc_bindings.DDBCSQLFetchOne(self.hstmt, row_data, char_decoding.get('encoding', 'utf-8'), wchar_decoding.get('encoding', 'utf-16le'))
+            ret = ddbc_bindings.DDBCSQLFetchOne(
+                self.hstmt,
+                row_data,
+                char_decoding.get("encoding", "utf-8"),
+                wchar_decoding.get("encoding", "utf-16le"),
+            )
 
             if self.hstmt:
                 self.messages.extend(ddbc_bindings.DDBCSQLGetAllDiagRecords(self.hstmt))
@@ -2184,7 +2197,13 @@ def fetchmany(self, size: Optional[int] = None) -> List[Row]:
         # Fetch raw data
         rows_data = []
         try:
-            ret = ddbc_bindings.DDBCSQLFetchMany(self.hstmt, rows_data, size, char_decoding.get('encoding', 'utf-8'), wchar_decoding.get('encoding', 'utf-16le'))
+            ret = ddbc_bindings.DDBCSQLFetchMany(
+                self.hstmt,
+                rows_data,
+                size,
+                char_decoding.get("encoding", "utf-8"),
+                wchar_decoding.get("encoding", "utf-16le"),
+            )
 
             if self.hstmt:
                 self.messages.extend(ddbc_bindings.DDBCSQLGetAllDiagRecords(self.hstmt))
@@ -2230,7 +2249,12 @@ def fetchall(self) -> List[Row]:
         # Fetch raw data
         rows_data = []
         try:
-            ret = ddbc_bindings.DDBCSQLFetchAll(self.hstmt, rows_data, char_decoding.get('encoding', 'utf-8'), wchar_decoding.get('encoding', 'utf-16le'))
+            ret = ddbc_bindings.DDBCSQLFetchAll(
+                self.hstmt,
+                rows_data,
+                char_decoding.get("encoding", "utf-8"),
+                wchar_decoding.get("encoding", "utf-16le"),
+            )
 
             if self.hstmt:
                 self.messages.extend(ddbc_bindings.DDBCSQLGetAllDiagRecords(self.hstmt))