Skip to content

Commit 948bba1

Browse files
authored
[QNN-EP] Remove outdated comment for per-channel quantization (#26523)
### Description <!-- Describe your changes. --> Conv2D supports per-channel uint8 quantized weights since QNN SDK 2.36. This PR updates outdated comments related to signed quantization checks for Conv. The check itself was removed in #25986 , which has been merged. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> #25986 Co-authored-by: -qti <@qti.qualcomm.com>
1 parent db6d83b commit 948bba1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

onnxruntime/core/providers/qnn/builder/opbuilder/conv_op_builder.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ Status ConvOpBuilder::IsOpSupported(QnnModelWrapper& qnn_model_wrapper,
110110
}
111111
}
112112

113-
// Validate that weight is signed type for per-channel quantization (required by QNN docs).
113+
// Validate quantization axis for per-channel quantized weights.
114114
bool is_npu_backend = IsNpuBackend(qnn_model_wrapper.GetQnnBackendType());
115115
if (is_npu_backend) {
116116
const auto& input_1 = inputs[1]; // weight

0 commit comments

Comments
 (0)