Merge pull request #13250 from microsoft/seanmcm/1_24_0_insiders

Merge for 1.24.0

Author: sean-mcmanus

.github/actions/package-lock.json

@@ -23,6 +23,7 @@ jobs:
         with:
           readonly: ${{ github.event.inputs.readonly }}
           labels: bug,debugger
-          ignoreLabels: "investigate: costing,investigate,external,by design,question,more info needed,language service,internal"
+          ignoreLabels: "investigate: costing,investigate,external,by design,question,more info needed,Language Service,internal"
           createdAfter: "2024-07-22"
           addComment: "Thank you for reporting this issue. We’ll let you know if we need more information to investigate it. Additionally, if you're working with GDB/LLDB, please note that the code is open source at https://github.com/microsoft/MIEngine/wiki/Contributing-Code . Your contributions are always welcome and appreciated."
+          addLabels: help wanted

.github/workflows/bug-debugger.yml

@@ -23,6 +23,6 @@ jobs:
         with:
           readonly: ${{ github.event.inputs.readonly }}
           labels: by design,debugger
-          ignoreLabels: language service,internal
+          ignoreLabels: Language Service,internal
           closeDays: 0
           closeComment: "This issue has been closed because the described behavior was determined to be by design."

.github/workflows/by-design-closer-debugger .yml

@@ -23,6 +23,6 @@ jobs:
         with:
           readonly: ${{ github.event.inputs.readonly }}
           labels: external,debugger
-          ignoreLabels: language service,internal
+          ignoreLabels: Language Service,internal
           closeDays: 0
           closeComment: "This issue has been closed because it is external or not applicable to the extension."

.github/workflows/external-closer-debugger.yml

@@ -22,7 +22,8 @@ jobs:
         uses: ./.github/actions/AddComment
         with:
           readonly: ${{ github.event.inputs.readonly }}
-          labels: feature request,debugger
-          ignoreLabels: "investigate: costing,investigate,external,by design,question,more info needed,language service,internal"
+          labels: Feature Request,debugger
+          ignoreLabels: "investigate: costing,investigate,external,by design,question,more info needed,Language Service,internal"
           createdAfter: "2024-07-22"
           addComment: "Thank you for your feature request. While we may not be able to implement it immediately, we will monitor community reactions to see how it fits into our backlog. Additionally, if you're working with GDB/LLDB, please note that the code is open source at https://github.com/microsoft/MIEngine/wiki/Contributing-Code . Your contributions are always welcome and appreciated."
+          addLabels: help wanted

.github/workflows/feature-request-debugger.yml

@@ -23,6 +23,6 @@ jobs:
         with:
           readonly: ${{ github.event.inputs.readonly }}
           labels: investigate,debugger
-          ignoreLabels: language service,internal
+          ignoreLabels: Language Service,internal
           closeDays: 180
           closeComment: "This issue has been closed as lower priority. We're sorry if this issue still impacts you but unfortunately we're not able to address this. We will accept a pull request from the community if it's applicable for this issue."

.github/workflows/investigate-closer-debugger.yml

@@ -23,6 +23,6 @@ jobs:
         with:
           readonly: ${{ github.event.inputs.readonly }}
           labels: "investigate: costing,debugger"
-          ignoreLabels: language service,internal
+          ignoreLabels: Language Service,internal
           closeDays: 180
           closeComment: "This issue has been closed as lower priority. We're sorry if this issue still impacts you but unfortunately we're not able to address this. We will accept a pull request from the community if it's applicable for this issue."

.github/workflows/investigate-costing-closer-debugger.yml

@@ -23,7 +23,7 @@ jobs:
         with:
           readonly: ${{ github.event.inputs.readonly }}
           labels: more info needed,debugger
-          ignoreLabels: language service,internal
+          ignoreLabels: Language Service,internal
           involves: wardengnaw,pieandcakes,calgagi
           closeDays: 14
           closeComment: "This issue has been closed because it needs more information and has not had recent activity."

.github/workflows/more-info-needed-closer-debugger.yml

@@ -23,7 +23,7 @@ jobs:
         with:
           readonly: ${{ github.event.inputs.readonly }}
           labels: question,debugger
-          ignoreLabels: language service,internal
+          ignoreLabels: Language Service,internal
           involves: wardengnaw,pieandcakes,calgagi
           closeDays: 14
           closeComment: "This issue has been closed because it is a question and has not had recent activity."

.github/workflows/question-closer-debugger.yml

@@ -48,7 +48,7 @@ export const Git = async (...args: Parameters<Awaited<CommandFunction>>) => (awa
 export const GitClean = async (...args: Parameters<Awaited<CommandFunction>>) => (await new Command(await git, 'clean'))(...args);
 
 export async function getModifiedIgnoredFiles() {
-    const {code, error, stdio } = await GitClean('-Xd', '-n');
+    const { code, error, stdio } = await GitClean('-Xd', '-n');
     if (code) {
         throw new Error(`\n${error.all().join('\n')}`);
     }
@@ -65,11 +65,11 @@ export async function rimraf(...paths: string[]) {
         }
         if (await filepath.isFolder(each)) {
             verbose(`Removing folder ${red(each)}`);
-            all.push(rm(each, {recursive: true, force: true}));
+            all.push(rm(each, { recursive: true, force: true }));
             continue;
         }
         verbose(`Removing file ${red(each)}`);
-        all.push(rm(each, {force: true}));
+        all.push(rm(each, { force: true }));
     }
     await Promise.all(all);
 }
@@ -345,3 +345,15 @@ export async function checkBinaries() {
     }
     return failing;
 }
+
+export async function checkProposals() {
+    let failing = false;
+
+    await rm(`${$root}/vscode.proposed.chatParticipantAdditions.d.ts`);
+    failing = await assertAnyFile('vscode.proposed.chatParticipantAdditions.d.ts') && (quiet || warn(`The VSCode import file '${$root}/vscode.proposed.chatParticipantAdditions.d.ts' should not be present.`)) || failing;
+
+    if (!failing) {
+        verbose('VSCode proposals appear to be in place.');
+    }
+    return failing;
+}